https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36932 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36932 [Bug 36932] koha-plack: Add parameter for specifically enabling Starman development environment -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Follow-up for bug 36932 |[Follow-up of 36932] Check | |is_test_system for stack | |trace in koha-plack -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #3)

Marking as a minor fix of the change in 36932 which was minor too.

Minor? Devs do not have stacktrace for several months, it's critical :D -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- KTD_HOME is not set within the ktd container, this does not work. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)

KTD_HOME is not set within the ktd container, this does not work.

Please list the exported env vars. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #8)

Just curious about this statement in the KTD repo btw:

Set some mandatory environment variables:

echo "export PROJECTS_DIR=$PROJECTS_DIR" >> ~/.bashrc echo 'export SYNC_REPO=$PROJECTS_DIR/koha' >> ~/.bashrc echo 'export KTD_HOME=$PROJECTS_DIR/koha-testing-docker' >> ~/.bashrc echo 'export PATH=$PATH:$KTD_HOME/bin' >> ~/.bashrc echo 'export LOCAL_USER_ID=$(id -u)' >> ~/.bashrc

Yes, on the host. This is to make the `ktd` script working on the host, to startup the container. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #11 from Jonathan Druart <jonathan.druart@gmail.com> --- Why not splitting the config finally? we should not consider ktd is the only koha dev env. Checking for a "ktd" env var from koha-plack is too specific. for me the "is dev env setup" config flag is the correct solution -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #14 from Jonathan Druart <jonathan.druart@gmail.com> --- Suggestion (same as before): 1. Replace the existing dev_install/DEV_INSTALL (that is dealing with paths adjustement) with "gitified" 2. Add the dev_install that is going to be used for dev purpose (here passing -dev to koha-plack) We will need a trivial change in ktd (add gitified): files/templates/koha-conf-site.xml.in: <dev_install>1</dev_install> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #16 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)

KTD_HOME is not set within the ktd container, this does not work.

Removed from the patch. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #19 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #18)

I'd say KTD should set an env flag and we should query for it.

Hi. This patch checks TEST_SYSTEM in the env. Does that correspond with what you meant here? We could rename DEV_INSTALL to GIT_INSTALL btw to perhaps lower confusion? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #21 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #18)

I'd say KTD should set an env flag and we should query for it.

Let me clarify my comment :-D I think we should have a `koha-conf.xml` entry or section for this things. I would like to be able to enable stack traces in koha-conf.xml instead of detecting how it is being run. We could also override using variables which `run.sh` (the startup script KTD uses) could set. This could be useful for running in jenkins where we might want to disable stacktraces for (say) Cypress tasks so they are similar to production, but enable them by default in KTD. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #22 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184798&action=edit Bug 39740: Add is_git_install and is_test_system Test plan: Copy koha-functions.sh to /usr/share/koha/bin. Source bin/koha-functions.sh ('. bin/koha-functions.sh') Test in bash (Yes expected; adjust instance name): GIT_INSTALL=1; if is_git_install your_instance; then echo Yes; fi Add/set git_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi Set git_install to 0 in koha-conf.xml. Test in bash (No expected): unset GIT_INSTALL; if ! is_git_install your_instance; then echo No; fi Remove git_install and add/set dev_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi A few similar tests with test_system. Add/set test_system to 0 in koha-conf.xml. Test in bash (Yes expected): TEST_SYSTEM=1; if is_test_system your_instance; then echo Yes; fi Test in bash (No expected): unset TEST_SYSTEM; if ! is_test_system your_instance; then echo No; fi Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #24 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184800&action=edit Bug 39740: Replace DEV_INSTALL by GIT_INSTALL Resulting from the following sed statement: git grep -l DEV_INSTALL | xargs sed -i -e "s/DEV_INSTALL/GIT_INSTALL/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #26 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184802&action=edit Bug 39740: Replace envvar check by calling is_git_install on instance level Replace the $GIT_INSTALL check by is_git_install. Some scripts did call is_git_install once while potentially looping over multiple instances. Note: koha-reset-passwd only runs on one instance (unlike most). Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Note: We will still test koha-plack and -z3950-responder later. Test running a few of the other changed koha-* scripts on one or more instances. Verify that things work as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #28 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184804&action=edit Bug 39740: Adjust koha-conf.xml Test plan: Look at changes in this patch. Note that we already tested these settings with former patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #29 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #21)

(In reply to Tomás Cohen Arazi (tcohen) from comment #18)

...

I'd say KTD should set an env flag and we should query for it.

Let me clarify my comment :-D Thanks

I think we should have a `koha-conf.xml` entry or section for this things. I would like to be able to enable stack traces in koha-conf.xml instead of detecting how it is being run.

We could also override using variables which `run.sh` (the startup script KTD uses) could set. This could be useful for running in jenkins where we might want to disable stacktraces for (say) Cypress tasks so they are similar to production, but enable them by default in KTD.

Two koha-conf entries: git_install and test_system. Two (optional) env vars overriding them: GIT_INSTALL and TEST_SYSTEM. Please have a look. Patch 5 includes a few more changes for consistency between koha scripts. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #31 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #30)

Excellent, thanks for the patches.

Just wondering if TEST_SYSTEM shouldn't actually be DEBUG_MODE (?)

It was already used ;) But they sound very close indeed.. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #33 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #32)

Hmm. Spotting

- if [ "$GIT_INSTALL" = "" ]; then + if ! is_git_install $name; then

Thats correct. Scratch it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #35 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #30)

Excellent, thanks for the patches.

Just wondering if TEST_SYSTEM shouldn't actually be DEBUG_MODE (?)

I agree we should pick DEBUG_MODE. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #35)

(In reply to Jonathan Druart from comment #30)

...

Excellent, thanks for the patches.

Just wondering if TEST_SYSTEM shouldn't actually be DEBUG_MODE (?)

I agree we should pick DEBUG_MODE.

Thx Will do. 2 - 1 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #37 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 184873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184873&action=edit Bug 39740: (QA follow-up) Rename test_system/TEST_SYSTEM See comment30 and comment36. Result of two sed's: git grep -l test_system | xargs sed -i -e "s/test_system/debug_mode/g" git grep -l TEST_SYSTEM | xargs sed -i -e "s/TEST_SYSTEM/DEBUG_MODE/g" The next patch will take care of the debugger options in the plack and z3950 responder scripts. Test plan: Read the patch. (Testing in next patch.) git grep -i test_system Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Open for testing again ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #40 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 184920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184920&action=edit Bug 39740: Fix adjust_paths_git_install in koha-es-indexer -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #42 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #40)

Created attachment 184920 [details] [review] Bug 39740: Fix adjust_paths_git_install in koha-es-indexer

Patch 2 did change it ;) But another patch restored the old name: + adjust_paths_dev_install $name -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #44 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Marcel de Rooy from comment #43)

(In reply to Jonathan Druart from comment #41)

...

2. I am wondering if there is an easy way to keep backward compatibility for dev_install: for instance ktd images for 25.05 won't be able to test "main". And ktd's main won't be able to test older commits. We will always have to reset_all or adjust koha-conf.

I kept a second check for dev_install in the function: # now check koha-conf; looking at dev_install as historical fallback if [ "$instancename" != "" ] && is_instance $instancename; then git_install=$(run_safe_xmlstarlet $instancename git_install) if [ -z "$git_install" ]; then git_install=$(run_safe_xmlstarlet $instancename dev_install); fi

Perfect, I missed that! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184798|0 |1 is obsolete| | Attachment #184799|0 |1 is obsolete| | Attachment #184800|0 |1 is obsolete| | Attachment #184801|0 |1 is obsolete| | Attachment #184802|0 |1 is obsolete| | Attachment #184803|0 |1 is obsolete| | Attachment #184804|0 |1 is obsolete| | Attachment #184873|0 |1 is obsolete| | Attachment #184874|0 |1 is obsolete| | Attachment #184920|0 |1 is obsolete| | --- Comment #45 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184989&action=edit Bug 39740: Add is_git_install and is_test_system Test plan: Copy koha-functions.sh to /usr/share/koha/bin. Source bin/koha-functions.sh ('. bin/koha-functions.sh') Test in bash (Yes expected; adjust instance name): GIT_INSTALL=1; if is_git_install your_instance; then echo Yes; fi Add/set git_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi Set git_install to 0 in koha-conf.xml. Test in bash (No expected): unset GIT_INSTALL; if ! is_git_install your_instance; then echo No; fi Remove git_install and add/set dev_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi A few similar tests with test_system. Add/set test_system to 0 in koha-conf.xml. Test in bash (Yes expected): TEST_SYSTEM=1; if is_test_system your_instance; then echo Yes; fi Test in bash (No expected): unset TEST_SYSTEM; if ! is_test_system your_instance; then echo No; fi Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #47 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184991&action=edit Bug 39740: Replace DEV_INSTALL by GIT_INSTALL Resulting from the following sed statement: git grep -l DEV_INSTALL | xargs sed -i -e "s/DEV_INSTALL/GIT_INSTALL/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #49 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184993&action=edit Bug 39740: Replace envvar check by calling is_git_install on instance level Replace the $GIT_INSTALL check by is_git_install. Some scripts did call is_git_install once while potentially looping over multiple instances. Note: koha-reset-passwd only runs on one instance (unlike most). Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Note: We will still test koha-plack and -z3950-responder later. Test running a few of the other changed koha-* scripts on one or more instances. Verify that things work as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #51 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184995&action=edit Bug 39740: Adjust koha-conf.xml Test plan: Look at changes in this patch. Note that we already tested these settings with former patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #53 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 184997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184997&action=edit Bug 39740: (QA follow-up) Adjust debugger for koha-plack and koha-z3950-responder This patch mainly renames var debug_mode in both scripts when it refers to the debugger instead of the instance's debug_mode. Note: Removing $environment from responder, probably copied. Test plan: cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Repeat steps from patch: "Replace envvar check by calling..." Repeat steps from patch: "Adjust koha-plack and koha-z3950-responder" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #55 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi (tcohen) from comment #45)

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>

Thx ! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184989|0 |1 is obsolete| | Attachment #184990|0 |1 is obsolete| | Attachment #184991|0 |1 is obsolete| | Attachment #184992|0 |1 is obsolete| | Attachment #184993|0 |1 is obsolete| | Attachment #184994|0 |1 is obsolete| | Attachment #184995|0 |1 is obsolete| | Attachment #184996|0 |1 is obsolete| | Attachment #184997|0 |1 is obsolete| | Attachment #184998|0 |1 is obsolete| | --- Comment #56 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186194&action=edit Bug 39740: Add is_git_install and is_test_system Test plan: Copy koha-functions.sh to /usr/share/koha/bin. Source bin/koha-functions.sh ('. bin/koha-functions.sh') Test in bash (Yes expected; adjust instance name): GIT_INSTALL=1; if is_git_install your_instance; then echo Yes; fi Add/set git_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi Set git_install to 0 in koha-conf.xml. Test in bash (No expected): unset GIT_INSTALL; if ! is_git_install your_instance; then echo No; fi Remove git_install and add/set dev_install to 1 in koha-conf.xml. Test in bash (Yes expected): unset GIT_INSTALL; if is_git_install your_instance; then echo Yes; fi A few similar tests with test_system. Add/set test_system to 0 in koha-conf.xml. Test in bash (Yes expected): TEST_SYSTEM=1; if is_test_system your_instance; then echo Yes; fi Test in bash (No expected): unset TEST_SYSTEM; if ! is_test_system your_instance; then echo No; fi Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #58 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186196&action=edit Bug 39740: Replace DEV_INSTALL by GIT_INSTALL Resulting from the following sed statement: git grep -l DEV_INSTALL | xargs sed -i -e "s/DEV_INSTALL/GIT_INSTALL/g" Test plan: Read the patch. The scripts will be tested later on. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #60 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186198&action=edit Bug 39740: Replace envvar check by calling is_git_install on instance level Replace the $GIT_INSTALL check by is_git_install. Some scripts did call is_git_install once while potentially looping over multiple instances. Note: koha-reset-passwd only runs on one instance (unlike most). Test plan: Check/adjust git_install and test_system in koha-conf.xml for used instances. cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ Note: We will still test koha-plack and -z3950-responder later. Test running a few of the other changed koha-* scripts on one or more instances. Verify that things work as expected. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #62 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186200&action=edit Bug 39740: Adjust koha-conf.xml Test plan: Look at changes in this patch. Note that we already tested these settings with former patches. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #64 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 186202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=186202&action=edit Bug 39740: (QA follow-up) Adjust debugger for koha-plack and koha-z3950-responder This patch mainly renames var debug_mode in both scripts when it refers to the debugger instead of the instance's debug_mode. Note: Removing $environment from responder, probably copied. Test plan: cp debian/scripts/koha-functions.sh /usr/share/koha/bin/ cp debian/scripts/koha-* /usr/sbin/ cp debian/templates/plack.psgi /etc/koha/plack.psgi Repeat steps from patch: "Replace envvar check by calling..." Repeat steps from patch: "Adjust koha-plack and koha-z3950-responder" Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #66 from Jonathan Druart <jonathan.druart@gmail.com> --- Opened https://gitlab.com/koha-community/koha-testing-docker/-/issues/502 and created a merge request. Lucas, we need the merge request to be merged right before you push this! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 --- Comment #67 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #69 from David Nind <david@davidnind.com> --- No changes to the manual required (as far as I can tell - more development-related). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39740 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42366 -- You are receiving this mail because: You are watching all bug changes.