[Bug 10860] New: In-House Use
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Bug ID: 10860 Summary: In-House Use Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jonathan.druart@biblibre.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com This feature implements the In-House Use feature for Koha. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- We currently use statistical patrons for recording in-house use - can you describe a bit more how the new feature will work? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #2 from Jared Camins-Esakov <jcamins@cpbibliography.com> --- Doesn't Koha already have in-house use tracking with both statistical patrons and RecordLocalUseOnReturn? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |jonathan.druart@biblibre.co |ity.org |m --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- The feature will allow to distinguish a checkout to an in-house use (visually: tabs in the circulation history, line "(In-house use)" in the checkout list at the OPAC and staff interfaces, etc.). It will be possible to do a checkout to a debarred patron, which is not possible with the existing feature. The patch won't delete the RecordLocalUseOnReturn, so the 2 features can cohabit ; if this one wins unanimous support, I will submit a followup in order to migrate data from the existing ones (statistics table), if it is possible. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---
It will be possible to do a checkout to a debarred patron, which is not possible with the existing feature.
Hm, why would you want to check out to a debarred patron? And is it a real checkout? (ends on the patron account - or only for counting? Is there a special option you have to check? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #4)
It will be possible to do a checkout to a debarred patron, which is not possible with the existing feature.
Hm, why would you want to check out to a debarred patron?
It is not a check out but an in-house use, sorry...
And is it a real checkout? (ends on the patron account - or only for counting?
Yes, it is a check out, with a new flag in DB.
Is there a special option you have to check?
A new checkbox will be added on the circulation page. Patch coming... :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #6 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20959 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20959&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #7 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20960 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20960&action=edit quick view: checkout list -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #8 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 20961 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20961&action=edit quick view: circulation history -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |gitbot@bugs.koha-community. | |org --- Comment #9 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... M C4/Circulation.pm M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/js/datatables.js M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging C4/Circulation.pm Patch failed at 0001 Bug 10860: In-House Use The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20959|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21195 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21195&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot| |2013-09-29 last check this| | --- Comment #11 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Items.pm M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt M koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging C4/Items.pm Auto-merging C4/Circulation.pm Patch failed at 0001 Bug 10860: In-House Use The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21195|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 21642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21642&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 I'm just a bot <gitbot@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply When did the bot|2013-09-29 00:00:00 |2013-10-28 last check this| | --- Comment #13 from I'm just a bot <gitbot@bugs.koha-community.org> --- Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... M C4/Circulation.pm M C4/Items.pm M circ/circulation.pl M installer/data/mysql/kohastructure.sql M installer/data/mysql/sysprefs.sql M installer/data/mysql/updatedatabase.pl M koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css M koha-tmpl/intranet-tmpl/prog/en/js/datatables.js M koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js M koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref M koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/kohastructure.sql Auto-merging circ/circulation.pl Auto-merging C4/Items.pm Auto-merging C4/Circulation.pm Patch failed at 0001 Bug 10860: In-House Use The copy of the patch that failed is found in: /home/christopher/git/koha/.git/rebase-apply/patch When you have resolved this problem, run "git am --continue". If you prefer to skip this patch, run "git am --skip" instead. To restore the original branch and stop patching, run "git am --abort". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #21642|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 22461 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22461&action=edit Bug 10860: In-House Use -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |11201 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Nicole C. Engard <nengard@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |mathieu.saby@univ-rennes2.f | |r --- Comment #15 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Hi. I wanted to test, but I've got the following message. Maybe my VM is not clean, or it is something to fix in the patch? <stdin>:1276: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... error: The following untracked working tree files would be overwritten by merge: misc/cronjobs/bulk_transferts.pl Please move or remove them before you can merge. Aborting If it needs rebase, could you replace "13.00" by "15.00" in updatedatabase ? Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to mathieu saby from comment #15)
error: The following untracked working tree files would be overwritten by merge: misc/cronjobs/bulk_transferts.pl
This file does not exist in master. Remove it before applying the patch. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #17 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- (In reply to Jonathan Druart from comment #16)
(In reply to mathieu saby from comment #15)
error: The following untracked working tree files would be overwritten by merge: misc/cronjobs/bulk_transferts.pl
This file does not exist in master. Remove it before applying the patch.
Oups. OK, sorry for that -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr --- Comment #18 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- The sandbox you've requested is not ready. Some problems occurred applying patches from bug 10860: <h1>Something went wrong !</h1>Applying: Bug 10860: In-House Use Using index info to reconstruct a base tree... <stdin>:1171: new blank line at EOF. + warning: 1 line adds whitespace errors. Falling back to patching base and 3-way merge... Auto-merging C4/Circulation.pm Auto-merging C4/Items.pm Auto-merging circ/circulation.pl CONFLICT (content): Merge conflict in circ/circulation.pl Auto-merging installer/data/mysql/kohastructure.sql Auto-merging installer/data/mysql/sysprefs.sql Auto-merging installer/data/mysql/updatedatabase.pl CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/datatables.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/js/pages/circulation.js Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/circ/circulation.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt Auto-merging koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/prog/en/includes/item-status.inc Failed to merge in the changes. Patch failed at 0001 Bug 10860: In-House Use When you have resolved this problem run git bz apply --continue. If you would prefer to skip this patch, instead run git bz apply --skip. To restore the original branch and stop patching run git bz apply --abort. Bug 10860 - In-House Use 22461 - Bug 10860: In-House Use Apply? [(y)es, (n)o, (i)nteractive] Patch left in /tmp/Bug-10860-In-House-Use-_cegfo.patch . -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #22461|0 |1 is obsolete| | --- Comment #19 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26089 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26089&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26089|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26114&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26114|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26123 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26123&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Koha Team Lyon 3 <koha@univ-lyon3.fr> --- I'm not sure to see the purpose of this patch but I test it anyway. There's 2 problems for the moment: 1. You can renew the "in house-use' for a normal duration checkout 2. There's an error on readingrec.pl Software error: Template process failed: file error - parse error - /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt line 137: unexpected token (ELSE) [% ELSE %] at /home/koha/src/C4/Templates.pm line 132. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26123|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26185 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26185&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26185|0 |1 is obsolete| | --- Comment #24 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26191 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26191&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #25 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 26192 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26192&action=edit Bug 10860: In-House use should not be renewed -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #26 from David Cook <dcook@prosentient.com.au> --- This feature seems a bit bizarre to me. In my experience, library staff periodically gather up materials lying around, and check them in as an "in-house use" before re-shelving. This is useful in that it shows that someone used it (at least once) even if they didn't actually check it out from the library. However, this feature doesn't seem to be that type of "in-house use". If I understand correctly, this would actually be a check-out to a patron? The idea being that they're not allowed to take it out of the library? That it would be due back at the desk before the library closes? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #27 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #26)
If I understand correctly, this would actually be a check-out to a patron? The idea being that they're not allowed to take it out of the library? That it would be due back at the desk before the library closes?
Yes, exactly. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #28 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hm, maybe it's more like a 'reading room' use then? Not sure if that's the right term in English, but I think we have something similar here. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Nick Clemens <nick@quecheelibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@quecheelibrary.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #26191|0 |1 is obsolete| | Attachment #26192|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31388&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #30 from Jonathan Druart <jonathan.druart@biblibre.com> --- Patch rebased, not trivial. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #31 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to Katrin Fischer from comment #28)
Hm, maybe it's more like a 'reading room' use then? Not sure if that's the right term in English, but I think we have something similar here.
I've only taken the most superficial of looks at this, but if the idea is to record loans of items that never physically leave the library, and which are associated with specific patrons (i.e., are not anonymous), yes, I'd agree that "reading room" is closer to the mark in English. (In reply to David Cook from comment #26)
This feature seems a bit bizarre to me.
In my experience, library staff periodically gather up materials lying around, and check them in as an "in-house use" before re-shelving. This is useful in that it shows that someone used it (at least once) even if they didn't actually check it out from the library.
What David describes matches how US librarians would understand "in-house use" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #32 from Galen Charlton <gmcharlt@gmail.com> --- Comment on attachment 31388 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31388 Bug 10860: In-House Use Review of attachment 31388: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10860&attachment=31388) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css @@ -2680,5 @@
-#transport-types { - padding-top: 0.5px; -} - -#i18nMenu .navbar-text .currentlanguage {
I don't see a good reason for this patch to be removing this rule and all of the following rules. Issue during the last rebase? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #33 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #27)
(In reply to David Cook from comment #26)
If I understand correctly, this would actually be a check-out to a patron? The idea being that they're not allowed to take it out of the library? That it would be due back at the desk before the library closes?
Yes, exactly.
Ahh. Yeah, I don't think "in-house use" would be the appropriate term in English. At least in North America. I'm not sure about other parts of the English-speaking world. It's an interesting idea though. "Reading room use" is the closest I can think of for this feature. The downside of "reading room use" is that it implies media that can be read by a person. But it's not an "internal use" either. I'm not sure what the most appropriate term would be. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #34 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #31)
(In reply to Katrin Fischer from comment #28)
Hm, maybe it's more like a 'reading room' use then? Not sure if that's the right term in English, but I think we have something similar here.
I've only taken the most superficial of looks at this, but if the idea is to record loans of items that never physically leave the library, and which are associated with specific patrons (i.e., are not anonymous), yes, I'd agree that "reading room" is closer to the mark in English.
Thanks Galen for your suggestion. During the first meeting, guys told me that 'on-site' was better than 'in-house use'. So what is the best between "reading room" and "on-site"? :) Maybe there is no generic term in English? Should I sent a request on the mailing list? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #35 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Galen Charlton from comment #32)
I don't see a good reason for this patch to be removing this rule and all of the following rules. Issue during the last rebase?
Yes, absolutely! Will fix it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31388|0 |1 is obsolete| | --- Comment #36 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31507 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31507&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - 1 new script misc/cronjobs/bulk_transfers.pl - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #37 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #34)
(In reply to Galen Charlton from comment #31)
(In reply to Katrin Fischer from comment #28)
Hm, maybe it's more like a 'reading room' use then? Not sure if that's the right term in English, but I think we have something similar here.
I've only taken the most superficial of looks at this, but if the idea is to record loans of items that never physically leave the library, and which are associated with specific patrons (i.e., are not anonymous), yes, I'd agree that "reading room" is closer to the mark in English.
Thanks Galen for your suggestion. During the first meeting, guys told me that 'on-site' was better than 'in-house use'. So what is the best between "reading room" and "on-site"? :) Maybe there is no generic term in English? Should I sent a request on the mailing list?
"On-site" actually sounds pretty good to me. I suppose I still wonder about people getting confused with "in-house" though :/. Maybe "On-site loan" or "On-site check out" to be a bit more explicit about what is happening? The mailing list is probably a good idea for this one. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #38 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to David Cook from comment #37)
The mailing list is probably a good idea for this one.
Mail sent on the koha ML. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Indranil Das Gupta <indradg@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg@gmail.com --- Comment #39 from Indranil Das Gupta <indradg@gmail.com> --- (In reply to Jonathan Druart from comment #38)
(In reply to David Cook from comment #37)
The mailing list is probably a good idea for this one.
Mail sent on the koha ML.
how about "in-library" or "intra-library" use? keeps it 'in the library' but doesn't necessary restrict it to a specific area with-in the library? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #40 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, reading through the description - can you explain some more about the use case for the cronjob and how it might be used in the library? Thx! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #41 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #40)
Hi Jonathan, reading through the description - can you explain some more about the use case for the cronjob and how it might be used in the library?
The script was for a specific need: The patrons cannot checkout specific items (rares for instance). But they can checkout them for an "in-house use" (replace this term with the one you prefer :)). These items are stored in a special local (location). At the end of the day, the items which have been checked out "in-house" are marked in transit. But actually someone puts them back in the local, so they are not in transit anymore. To avoid a manual action, this script simulates a checkin. That's why you can specify a location in parameter of the script. I did not remember the script was submitted here. I can remove it if someone notes it's too specific. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #42 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- The script sounds interesting, but maybe split it off to a separate bug? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #43 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #42)
The script sounds interesting, but maybe split it off to a separate bug?
I am not sure it could be useful in another context. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #44 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I'd leave the script out for now and maybe add it later on. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31507|0 |1 is obsolete| | --- Comment #45 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31548 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31548&action=edit Bug 10860: In-House Use -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #46 from Jonathan Druart <jonathan.druart@biblibre.com> --- (In reply to Katrin Fischer from comment #44)
I think I'd leave the script out for now and maybe add it later on.
I removed it, but it is part of the feature, I don't really understand why I have to split it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #47 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Jonathan, without the cronjob the patch is fully testable on a sandbox I think, so putting it on a separate bug depending on this one could speed up things here a bit. :) Also I got a few questions about the script already - I thought it would be nicer to have them on a separate thread, as they are specific to the script (automating check-ins and possible complications) and would probably not be any problem for testing the main part of the feature. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #48 from Jonathan Druart <jonathan.druart@biblibre.com> --- A massive sed should replace "in-house use" with "on-site checkouts". The community agreed on this new term (dev meeting September 16, 2014). Back to "assigned". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31548|0 |1 is obsolete| | --- Comment #49 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31664&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #50 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 31665 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31665&action=edit Bug 10860: wording: "in-house use" => "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|In-House Use |On-site checkouts (was | |In-House Use) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #51 from Chris Cormack <chris@bigballofwax.co.nz> --- I tried to test this, but with the patch, the previous checkouts never load, it just says processing. It may be an error I made fixing the conflicts, could you have a look please Jonathan. Apart from that, all the other functionality seems to work fine -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31664|0 |1 is obsolete| | Attachment #31665|0 |1 is obsolete| | --- Comment #52 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32213 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32213&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #53 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 32214 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32214&action=edit Bug 10860: wording: "in-house use" => "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32213|0 |1 is obsolete| | --- Comment #54 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32216 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32216&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32214|0 |1 is obsolete| | --- Comment #55 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 32223 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32223&action=edit Bug 10860: wording: "in-house use" => "on-site checkout" Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |kyle@bywatersolutions.com --- Comment #56 from Kyle M Hall <kyle@bywatersolutions.com> --- I'm getting failed unit tests: prove -v t/db_dependent/Circulation.t t/db_dependent/Circulation.t .. 1..55 ok 1 - use C4::Circulation; ok 2 - CircControl changed to PickupLibrary ok 3 - _GetCircControlBranch returned item branch (no userenv defined) ok 4 - CircControl changed to PatronLibrary ok 5 - _GetCircControlBranch returned borrower branch ok 6 - CircControl changed to ItemHomeLibrary ok 7 - _GetCircControlBranch returned item branch ok 8 - userenv set ok 9 - CircControl changed to PickupLibrary ok 10 - _GetCircControlBranch returned current branch ok 11 - CircControl changed to PatronLibrary ok 12 - _GetCircControlBranch returned borrower branch ok 13 - CircControl changed to ItemHomeLibrary ok 14 - _GetCircControlBranch returned item branch ok 15 - CircControl reset to its initial value ok 16 - ProcessOfflinePayment makes payment correctly ok 17 - Item 1 checked out, due date: 2014-11-03T23:59:00 ok 18 - Item 2 checked out, due date: 2014-11-03T23:59:00 ok 19 - Item checked out to John Renewal ok 20 - Can renew, no holds for this title or item ok 21 - (Bug 10663) Cannot renew, reserved ok 22 - (Bug 10663) Cannot renew, reserved (returned error is on_reserve) ok 23 - (Bug 10663) Cannot renew, reserved ok 24 - (Bug 10663) Cannot renew, reserved (returned error is on_reserve) ok 25 - hold marked completed when checking out item that fills it ok 26 - (Bug 10663) Cannot renew, item reserved ok 27 - (Bug 10663) Cannot renew, item reserved (returned error is on_reserve) ok 28 - Can renew item 2, item-level hold is on item 1 ok 29 - Can renew, item is marked not for loan, hold does not block Can't use string ("1") as a HASH ref while "strict refs" in use at C4/Circulation.pm line 1187. # Looks like you planned 55 tests but ran 29. # Looks like your test exited with 255 just after 29. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 26/55 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 29 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 55 tests but ran 29. Files=1, Tests=29, 3 wallclock secs ( 0.01 usr 0.01 sys + 1.12 cusr 0.05 csys = 1.19 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32216|0 |1 is obsolete| | Attachment #32223|0 |1 is obsolete| | --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32579 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32579&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #58 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32580 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32580&action=edit Bug 10860 - Change "in-house use" to "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32581 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32581&action=edit Bug 10860 [QA Followup] - Fix misc issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #60 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Working on this next. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #61 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Still working on this, will post comments tonight. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #62 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32954 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32954&action=edit Bug 10860: Follow-up - staff reading record - capitalization fix "Checked out" - display new tabs only when feature is activated - fixes a qa script complaint about POD in Items.pm -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #63 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I really like this feature and would like to see it in Koha, but there are 2 problems I think we need to fix before: - Patches change the OPAC prog templates which will be removed in a few moments and miss any changes to the Bootstrap OPAC - We shoudn't start yet another naming convention for system preferences. Please choose a system preference without spaces (I personally prefer camel case). Some notes: 1) Checkouts - Normal and on-site checkouts work ok, no regressions found - I think some libraries might want to set the date/time individually, but this could be added later as an option 2) Reading history - Filtering and sorting works ok - Provided a follow up to make the table display as before, when On-site checkouts are disabled. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_3_18_candidate -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32579|0 |1 is obsolete| | Attachment #32580|0 |1 is obsolete| | Attachment #32581|0 |1 is obsolete| | Attachment #32954|0 |1 is obsolete| | --- Comment #64 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32979 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32979&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32979|0 |1 is obsolete| | --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32980 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32980&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #66 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32981 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32981&action=edit Bug 10860 - Change "in-house use" to "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #67 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32982&action=edit Bug 10860 [QA Followup] - Fix misc issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #68 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32983 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32983&action=edit Bug 10860: Follow-up - staff reading record - capitalization fix "Checked out" - display new tabs only when feature is activated - fixes a qa script complaint about POD in Items.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 32984 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32984&action=edit Bug 10860 [QA Followup] - Rename system preferences -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32984|0 |1 is obsolete| | --- Comment #70 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32997 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32997&action=edit [PASSED QA] Bug 10860 [QA Followup] - Rename system preferences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #71 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 32998 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32998&action=edit Bug 10860: Follow-up - fix some template variable issues Fixing some simple display issues caused by missing/misnamed variables, probably consequence of the renaming before. Amended test plan: - Make sure that if OnSiteCheckoutsForce is set, you can still perform onsite checkouts and only those. - Check the detail page in staff says *currently in local use by* for an on-site checked out item - Check the detail page in OPAC with OPACShowCheckoutName active for the same. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #32980|0 |1 is obsolete| | Attachment #32981|0 |1 is obsolete| | Attachment #32982|0 |1 is obsolete| | Attachment #32983|0 |1 is obsolete| | Attachment #32997|0 |1 is obsolete| | Attachment #32998|0 |1 is obsolete| | --- Comment #72 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33031 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33031&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #73 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33032&action=edit Bug 10860 - Change "in-house use" to "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #74 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33033&action=edit Bug 10860 [QA Followup] - Fix misc issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #75 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33034 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33034&action=edit Bug 10860: Follow-up - staff reading record - capitalization fix "Checked out" - display new tabs only when feature is activated - fixes a qa script complaint about POD in Items.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #76 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33035 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33035&action=edit Bug 10860 [QA Followup] - Rename system preferences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #77 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33036 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33036&action=edit Bug 10860: Follow-up - fix some template variable issues Fixing some simple display issues caused by missing/misnamed variables, probably consequence of the renaming before. Amended test plan: - Make sure that if OnSiteCheckoutsForce is set, you can still perform onsite checkouts and only those. - Check the detail page in staff says *currently in local use by* for an on-site checked out item - Check the detail page in OPAC with OPACShowCheckoutName active for the same. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #78 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 33037 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33037&action=edit Bug 10860 [QA Followup] - Use Koha.Preference -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13179 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13183 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13184 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13184 Depends on|13184 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33031|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33032|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33034|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33035|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33036|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #33037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #79 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33105 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33105&action=edit Bug 10860: In-House Use This patch implements the In-House Use feature for Koha. It adds: - 2 new sysprefs: 'In-House Use' to enable/disable this feature 'In-House Use Forced' to enable/disable the feature for *all* users. - 2 new columns issues.inhouse_use and old_issues.inhouse_use - Datatable on the circulation history pages (readingrec) at the OPAC and the intranet. A new checkbox in the Circulation tab. If checked, the issue become a in-house use (in the statistics and issues tables). When you check it, the due date changes to the today date. The syspref "In-House Use Force" allows to force the in-house use to permit the checkout even if the borrower is debarred or others problems. In the issue table, a new string (in red) marks the issue as "in-house use". The circulation history contains 3 tabs : "all", "checkout" and "in-house use" (OPAC and intranet). The cronjob script: If AutomaticItemReturn if off, a library would like not to do a transit operation manually. This script (to launch each night) do returns for a specific branches. Test plan: 1/ Execute the updatedatabase entry 2/ Enable the 'In-House Use' pref. 3/ Checkout a biblio for a patron and check the 'in-house use' checkbox. 4/ Check that the due date is the today date (with 23:59) and is not modifiable. 5/ Click on the check out button and check that the new check out appears in the table bellow with the "(In-house use)" string. 6/ Go on the circulation history pages (readingrec and opac-readingrec) and try the 3 tabs. In the last one, your last checkout should appear. 7/ Check in. 8/ Check readingrec pages. 9/ Choose a debarred patron and check that you cannot checkout a biblio for him. 10/ Switch on the 'In-House Use Forced' pref 11/ You are now allowed to checkout a biblio for the debarred patron. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #80 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33106 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33106&action=edit Bug 10860 - Change "in-house use" to "on-site checkout" -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #81 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33107 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33107&action=edit Bug 10860 [QA Followup] - Fix misc issues -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #82 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33108&action=edit Bug 10860: Follow-up - staff reading record - capitalization fix "Checked out" - display new tabs only when feature is activated - fixes a qa script complaint about POD in Items.pm Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #83 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33109 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33109&action=edit Bug 10860 [QA Followup] - Rename system preferences Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #84 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33110 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33110&action=edit Bug 10860: Follow-up - fix some template variable issues Fixing some simple display issues caused by missing/misnamed variables, probably consequence of the renaming before. Amended test plan: - Make sure that if OnSiteCheckoutsForce is set, you can still perform onsite checkouts and only those. - Check the detail page in staff says *currently in local use by* for an on-site checked out item - Check the detail page in OPAC with OPACShowCheckoutName active for the same. Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #85 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 33111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33111&action=edit [PASSED QA] Bug 10860 [QA Followup] - Use Koha.Preference Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13183 Depends on|13183 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #86 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33163 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33163&action=edit Bug 10860: Update DBIx Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 --- Comment #87 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 33165 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33165&action=edit Bug 10860: (RM followup) checkout-related sysprefs belong to the checkouts section Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #88 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patches pushed to master. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13234 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13255 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #89 from Mason James <mtj@kohaaloha.com> --- Skipping patch for 3.16.x series -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14470 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14470 [Bug 14470] Renewals should be disabled in OPAC if are referred to an on-site checkout -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10860 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15569 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15569 [Bug 15569] Automatic renewal should not be displayed if the patron cannot checkout -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org