https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20917 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 89831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89831&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 89833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89833&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 89835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89835&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89831|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 90063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90063&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89833|0 |1 is obsolete| | --- Comment #10 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 90065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90065&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89835|0 |1 is obsolete| | --- Comment #12 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 90067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90067&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org, | |josef.moravec@gmail.com, | |katrin.fischer@bsz-bw.de, | |magnus@libriotech.no, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90063|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 90715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90715&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90065|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 90717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90717&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90067|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 90719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=90719&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23112 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 [Bug 23112] Circulation of ILL items -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #19 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- *** Bug 20917 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90716|0 |1 is obsolete| | --- Comment #21 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 92899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92899&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90718|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 92901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92901&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon@it-tall | |aght.ie --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- *** Bug 23614 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #27 from Tomás Cohen Arazi <tomascohen@gmail.com> --- I'm starting to test this. I would like to say that I see more and more the need to have an ILL configuration section in the staff interface. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23@gmail.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92898|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100234&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92900|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100236&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92902|0 |1 is obsolete| | --- Comment #33 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 100238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100238&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100234|0 |1 is obsolete| | --- Comment #35 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 103268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103268&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100236|0 |1 is obsolete| | --- Comment #37 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 103270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103270&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #100238|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 103272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103272&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Lisette Scheer <lisetteslatah@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah@gmail.com Text to go in the| |This patch adds the ability release notes| |for ILL to send notices, | |both triggered by staff and | |triggered by events. | | | |Staff | |can trigger notices to | |patrons from the "Manage | |ILL request" screen: | |- ILL | |request ready for pickup | |- | |ILL request unavailable | |- | |Place request with partners | | | |The following notices to | |staff are triggered | |automatically: | |- Request | |has been modified by patron | |- Request has been | |cancelled by patron | | | |Branches can now specify an | |"ILL email" address to | |which notices intended to | |inform staff of changes to | |requests by patrons can be | |sent. | | | |The sending of | |notices is controlled by a | |few new sysprefs: | |- | |"ILLDefaultStaffEmail" - | |Fallback email address for | |staff ILL notices | |to be | |sent to in the absence of a | |branch address | |- | |"ILLSendStaffNotices" - To | |specify which staff notices | |should be sent | |automatically when requests | |are manipulated by patrons | | | |Patron notices are also | |controlled by the patron's | |messaging | |preferences. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_11_target | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103268|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 106424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106424&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103270|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 106426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106426&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103272|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 106428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106428&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Sponsored-by: PTFS Europe -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #48 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Andrew Isherwood from comment #47)

Hi Katrin - This is now rebased, so all should be well!

Hi Andrew, I tried to test, but it doesn't apply against master, because of a conflict in branches.tt caused by bug 25288 (pushed on 24 June). It's not a trivial fix, so I'd be happy if you could take a look, before I try. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #50 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am still working on this, but adding some first notes and questions: 1) QA test tools FAIL Koha/MessageAttributes.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) FAIL Koha/MessageAttribute.pm FAIL forbidden patterns forbidden pattern: Incorrect license statement (using postal address), may be a false positive if the file is coming from outside Koha (bug 24545) (line 16) 2) Unit tests While tests pass, they produce some non-good looking output: kohadev-koha@kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Illrequests.t t/db_dependent/Illrequests.t .. 7/12 Use of uninitialized value $staff_to_send in pattern match (m//) at /home/vagrant/kohaclone/Koha/Illrequest.pm line 1522. Koha::Illrequest::send_staff_notice(Koha::Illrequest=HASH(0x55b06c17ba40), "ILL_REQUEST_CANCEL") called at /home/vagrant/kohaclone/Koha/Illrequest.pm line 288 Koha::Illrequest::status(Koha::Illrequest=HASH(0x55b06c17ba40), "CANCREQ") called at t/db_dependent/Illrequests.t line 788 main::__ANON__() called at /usr/share/perl5/Test/Builder.pm line 310 eval {...} called at /usr/share/perl5/Test/Builder.pm line 310 Test::Builder::subtest(Test::Builder=HASH(0x55b06bac3bf8), "Helpers", CODE(0x55b063112be8)) called at /usr/share/perl5/Test/More.pm line 807 Test::More::subtest("Helpers", CODE(0x55b063112be8)) called at t/db_dependent/Illrequests.t line 934 t/db_dependent/Illrequests.t .. ok All tests successful. Files=1, Tests=12, 32 wallclock secs ( 0.09 usr 0.03 sys + 21.40 cusr 6.88 csys = 28.40 CPU) Result: PASS 3) Code Review 3.1) Email addressing I feel like here is a general issue here in that we will have problems with spam protection if the mail server is not in the same domain as the branchillemail given. Is the the new ILL staff email is to be used as the sender or the recipient of the ILL emails to staff? It looks like it's actually used as both? As the pref only reads "to", maybe we could just keep the current from and it would resolve a lot of the possible issues with spam. I think we need to at least make use of $library->inbound_email_address in a couple of cases replacing the branchemail here: + my $from = $branch->branchillemail || $branch->branchemail; get_staff_to_address seems ok in that regard, but send_staff_notice from_adress does not. Reply-to and From are the spam critical ones. Use of Koha::Email is removed? 3.2) Translatability The "N/A" here are problematic. I think it would be better to just create an empty string? With TT libraries can still resolve that to another text. + substitute => { + ill_bib_title => $title ? $title->value : 'N/A', + ill_bib_author => $author ? $author->value : 'N/A', 3.3) Sample letters I need to take a closer look for typos and such, but the sample letters need to also be added to the new sample .yml and to the translated installers. 3.4) Sysprefs.sql New prefs are in the wrong alphabetic spot :) 3.5) Notices & slips The module in the letters summary table is not translatable yet and shows as "ill". ------------- Most of those are not bad ones, only 3.1 Email addressing worries me a fair bit. Clearing up intentions and intended behaviour would be a good firs step here. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106425|0 |1 is obsolete| | --- Comment #52 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106676&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106427|0 |1 is obsolete| | --- Comment #54 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106678&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #56 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106680&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #58 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106691&action=edit Bug 22818: (QA follow-up) Template CASE correction -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #60 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106694&action=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106676|0 |1 is obsolete| | --- Comment #62 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106705&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106678|0 |1 is obsolete| | --- Comment #64 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106707&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106680|0 |1 is obsolete| | --- Comment #66 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106709&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106693|0 |1 is obsolete| | --- Comment #68 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106711&action=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #70 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 106713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=106713&action=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Janet McGowan <janet.mcgowan@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan@ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Daniel Gaghan <daniel.gaghan@pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan@pueblolibrary | |.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106705|0 |1 is obsolete| | --- Comment #74 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110197&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106707|0 |1 is obsolete| | --- Comment #76 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110199&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106709|0 |1 is obsolete| | --- Comment #78 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110202&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106711|0 |1 is obsolete| | --- Comment #80 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110204&action=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #106713|0 |1 is obsolete| | --- Comment #82 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 110206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110206&action=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #84 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- (In reply to Katrin Fischer from comment #72)

I am sorry, but the tests are not passing, can you please have a look?

Test Summary Report ------------------- t/db_dependent/Koha/Libraries.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 10 tests but ran 8. t/db_dependent/Illrequests.t (Wstat: 65280 Tests: 8 Failed: 1) Failed test: 8 Non-zero exit status: 255 Parse errors: Bad plan. You planned 13 tests but ran 8.

Without the patches I still have one failing test - not ok 10 - Checking out

I've rebased the patchset as it didn't apply on master for me. I've also added a final 'Schema Updates' patch to simplify testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #86 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- The failing tests were a sign of missing data at install time.. the final patch should correct that and mean the tests pasts now. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize@ptfs-europe |andrew.isherwood@ptfs-europ |.com |e.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110196|0 |1 is obsolete| | --- Comment #88 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111837&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110198|0 |1 is obsolete| | --- Comment #90 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111839&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110201|0 |1 is obsolete| | --- Comment #92 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111841&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110203|0 |1 is obsolete| | --- Comment #94 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111843&action=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110205|0 |1 is obsolete| | --- Comment #96 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111845&action=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110208|0 |1 is obsolete| | --- Comment #98 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111847&action=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #101 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Updated test plan: - Apply patch - Update database and schema - Create a report using the following SQL in order to verify that notices are being generated: SELECT borrowernumber, subject, content, message_transport_type, to_address, from_address FROM message_queue WHERE letter_code LIKE 'ILL%' ORDER BY message_id DESC - Create one or more "partners". These are patrons that belong to a patron category that has a code that matches the <partner_code> value in your koha-conf.xml (default is ILLLIBS). Patrons in this category must have a primary email defined. Patrons defined in this way are offered as request partners within the ILL interface. - Go to "Koha administration", search for "ILLModule" syspref, ensure it is set to "Enable" - Go to "Koha administration", search for "IllLog" syspref, ensure it is set to "Log" SYSTEM PREFERENCES AND BRANCH CONFIG - In the staff interface, go to Tools > Notices & Slips => TEST: Observe that there are 5 new notices defined for the "Interlibrary loans" module - Go to "Koha administration" > "Libraries" - Choose a library and "Edit" it - Ensure the "Email" field for the library is populated => TEST: Observe there is a new "ILL staff email" field - Enter an email address in the "ILL staff email" field and save the branch - Go to "Koha administration" > search for the "ILLDefaultStaffEmail" syspref => TEST: Observe the new syspref exists - Enter an email address in this syspref and then save it - Go to "Koha administration" > search for the "ILLSendStaffNotices" syspref => TEST: Observe the new syspref exists - Enter the names of the two staff notices in this syspref as "ILL_REQUEST_CANCEL|ILL_REQUEST_MODIFIED" and save the syspref PATRON MESSAGING PREFERENCES - Go to a patron's messaging preferences => TEST: Observe that two new messaging preferences exist, "Interlibrary loan ready" & "Interlibrary loan unavailable" - Select email and/or SMS for each of these notices SENDING PATRON NOTICES FROM ILL REQUEST - In the staff interface, go to "ILL requests" - Create an ILL request using the FreeForm backend (for the user you just modified the messaging preferences for), select the branch that you previously added the "ILL staff email" address to - Go to the "Manage ILL request" screen for the newly created request => TEST: Observe that there is a new "Send notice to patron" dropdown in the button bar which offers two notices to send - Select a notice to be sent => TEST: Observe that a message reporting the successful queueing of the notice is displayed - Click on the "ILL request log" for the request => TEST: Observe that a log entry "Patron notice sent:" was added to the log - Run the report created earlier => TEST: Observe that a notice was created for all sending methods selected in the patron's messaging preferences => TEST: Observe that the borrowernumber column of the notice is populated SENDING REQUEST TO PARTNERS - Go to the "Manage ILL request" screen for a request - Choose "Place request with partners" => TEST: Observe that the text defined in the ILL_PARTNER_REQ notice is displayed and can be modified - Select one or more partners that were defined earlier, then click "Send email" => TEST: Observe that the request's status has changed to "Requested from partners" - Run the report created earlier => TEST: Observe that a notice was created => TEST: Observe that the to_address column matches the primary email addresses for the selected partners => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch PATRON GENERATED NOTICES - As a patron with ILL requests, go to the "your interlibrary loan requests" page in the OPAC - View a request - Add some text to the notes field and save - Run the report created earlier => TEST: Observe that a notice was created for the modification => TEST: Observe that the to_address matches the previously defined "ILL staff email" for the request's branch => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch - As a patron with ILL requests, go to the "your interlibrary loan requests" page in the OPAC - View a request - Choose "Request cancellation" - Run the report created earlier => TEST: Observe that a notice was created for the cancellation => TEST: Observe that the to_address matches the previously defined "ILL staff email" for the request's branch => TEST: Observe that the from_address matches the previously defined "ILL staff email" for the request's branch There is a fallback hierarchy for the address to which staff notices are sent: Branch ILL staff email > ILLDefaultStaffEmail > General branch email > Koha admin email Please test that this hierarchy is adhered to by undefining one or more of these options. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #103 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I think I spotted a rebase issue ( :( ) in Illrequest.pm: In the last iteration pushed by Martin we had: - my $from = $branch->branchillemail || $branch->branchemail; - my $replyto = $branch->branchreplyto || $from; + my $from = $branch->branchemail; + my $replyto = $branch->inbound_ill_address; But now it reads: - my $from = $library->branchemail; - my $reply_to = $library->branchreplyto || $from; + my $from = $branch->branchillemail || $branch->branchemail; + my $replyto = $branch->branchreplyto || $from; I feel the first one is correct as it will work for libraries using a mail server outside their domain and thus allow wider use of the feature. It looks like the very last patch changed it back. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #105 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Sadly the ILLModule check on the system preference doesn't work the intended way. It only removes the labels, the ILL notices still show up as "Unknown". I think a slightly different approach is needed. Not sure I see how to fix that myself right now, so putting it here while I continue testing. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #107 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- 5) Metadata missing from text to partners Not sure if this should be a separate bug: - Enter a new ILL request, using Freeform - Type: Book, Title: something random - Edit request - Place with partner libraries - The title information is not showing up - Edit metadata, add year - same issue. - Add author - now it works and the notice shows the information. Note: the metadata field appear unordered, maybe something for later refinement in the TT notice. 6) Buttons (Bootstrap 4 issue) In the OPAC the "Submit modifications" button has bad contrast being dark grey with black writing. I think this could be a separate bug and is surely an issue with the Bootstrap 4 update as we had some other button bugs already. Everything else looks good! Please provide fixes as follow-ups - that will help to get them tested easier. I think all points found are not too severe and hope we can get that over finish line this time! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #109 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Katrin Fischer from comment #108)

Created attachment 111874 [details] ILL view in OPAC - button

For 6) Checked with Owen: Since it's a submit button I'd change "btn-default" to "btn-primary," but it should be considered a general bug that input:submit.btn-default has black text. So we should change it in this template, but I also filed bug 26706. I'd be open to fix it here, but we can also move it to a separate bug as it's not strictly related. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111838|0 |1 is obsolete| | --- Comment #111 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111881&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111840|0 |1 is obsolete| | --- Comment #113 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111884&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111842|0 |1 is obsolete| | --- Comment #115 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111886&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111844|0 |1 is obsolete| | --- Comment #117 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111888&action=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111846|0 |1 is obsolete| | --- Comment #119 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111890&action=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111848|0 |1 is obsolete| | --- Comment #121 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 111892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111892&action=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #123 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Katrin - Thanks for that. I've now addressed everything you've mentioned apart from the metadata not appearing with just a title, this seemed to work fine for me. There *was* a bug with metadata display, which I've now fixed, but I don't think it would have caused what you were seeing. Try these latest set of patches and see if you still have the problem. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #125 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, 5) is fixed for me now. All others look good too. I am working on some tiny follow-ups. Ready soon. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111880|0 |1 is obsolete| | --- Comment #126 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111897&action=edit Bug 22818: Add notices sysprefs and DB column This patch adds two new sysprefs. 'ILLDefaultEmail', 'ILLSendStaffNotices' and a new column to the branches table called 'branchillemail'. It also adds five ILL related notices. Here we are providing the ability for a branch to have a dedicated email address for it's ILL staff, the idea being that any notices sent by ILL to staff need to go to specific staff, rather than the general branch email address. If no branch specific address is defined, the address specified in the ILLDefaultEmail syspref is used. We're also providing a syspref 'ILLSendStaffNotices' to allow the user to specify which notices should be sent to staff upon certain events. We are also providing patron messaging preferences for the two patron bound notices We are also providing five notices for various ILL related events. Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111883|0 |1 is obsolete| | --- Comment #128 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111900&action=edit Bug 22818: Add generation and sending of notices This patch adds the ability for ILL to send notices, both triggered by staff and triggered by events. Staff can trigger notices to patrons from the "Manage ILL request" screen: - ILL request ready for pickup - ILL request unavailable - Place request with partners The following notices to staff are triggered automatically: - Request has been modified by patron - Request has been cancelled by patron Branches can now specify an "ILL email" address to which notices intended to inform staff of changes to requests by patrons can be sent. The sending of notices is controlled by a few new sysprefs: - "ILLDefaultStaffEmail" - Fallback email address for staff ILL notices to be sent to in the absence of a branch address - "ILLSendStaffNotices" - To specify which staff notices should be sent automatically when requests are manipulated by patrons Patron notices are also controlled by the patron's messaging preferences Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111885|0 |1 is obsolete| | --- Comment #130 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111902&action=edit Bug 22818: Unit tests This patch adds unit tests for the new methods in Illrequest.pm Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111887|0 |1 is obsolete| | --- Comment #132 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111904&action=edit Bug 22818: (QA follow-up) Licence and POD fixes Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111889|0 |1 is obsolete| | --- Comment #134 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111906&action=edit Bug 22818: (QA follow-up) Translation fix + Branch notices This patch removes the hard coded 'N/A' being passed to GetPreparedLetter and passes in the branchcode of the ILLRequest so notices can be branch specific. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111891|0 |1 is obsolete| | --- Comment #136 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111908&action=edit Bug 22818: (QA follow-up) Add mandatory data at install time This patch adds the data from the update script into the mandatory sql files such that it is also populated at install time. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #138 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111910&action=edit Bug 22818: (follow-up) Respond to feedback This commit implements the feedback from Katrin in comment #103 -> comment #108: - Fixed rebase issue mentioned in comment #103 - Fixed ILL notice display mentioned in comment #106 - Fixed bug with metadata display, though not the issue that was mentioned in comment #107 - Fixed buttons display mentioned in comment #107, in addition to some more buttons suffering the same issue Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #140 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111912&action=edit Bug 22818: (QA follow-up) Add some punctuation and terminology fixes to pref descriptions Just branch => library and some ending punctuation. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #142 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Thx for the quick work and great test plan, Andrew. I threw in 3 tiny follow-ups at the end - hope they are agreeable :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #144 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Andrew, I resolved a first conflict on sample_notices_message_transports.sql but I cannot apply the second "Bug 22818: (follow-up) Respond to feedback" patch error: sha1 information is lacking or useless (installer/data/mysql/en/mandatory/sample_notices.yml). -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111899|0 |1 is obsolete| | --- Comment #146 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113399&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111901|0 |1 is obsolete| | --- Comment #148 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113401&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111903|0 |1 is obsolete| | --- Comment #150 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113403&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111905|0 |1 is obsolete| | --- Comment #152 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113405&action=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111907|0 |1 is obsolete| | --- Comment #154 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113407&action=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111909|0 |1 is obsolete| | Attachment #111910|0 |1 is obsolete| | --- Comment #156 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113409&action=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111911|0 |1 is obsolete| | --- Comment #158 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113411&action=edit Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111913|0 |1 is obsolete| | --- Comment #160 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113413&action=edit Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #162 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Only found minor things so far. 1. Those changes are not expected: - my $library = Koha::Libraries->find($params->{current_branchcode}) + my $branch = Koha::Libraries->find($params->{current_branchcode}) 2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it explicit on the interface to not cause confusion? 3. +use Koha::MessageAttributes; +use Koha::MessageAttribute; You only need to include the Koha::Object*s* class. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113399|0 |1 is obsolete| | --- Comment #164 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113464&action=edit Bug 22818: Add support for ILL notices Here we're just adding ILL notices to the existing "letters" infrastructure so notices can be displayed and edited Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113401|0 |1 is obsolete| | --- Comment #166 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113466&action=edit Bug 22818: Add MessageAttribut{e,es}.pm We need to be able to access individual message attributes in tests, so adding accessors for them Sponsored-by: PTFS Europe Signed-off-by: Niamh Walker-Headon <Niamh.Walker-Headon@it-tallaght.ie> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113403|0 |1 is obsolete| | --- Comment #168 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113468&action=edit Bug 22818: (QA follow-up) Email addressing corrections This patch updates the patchset to use recnetly introduced methods for obtaining the correct inbound and reply email addresses for branches. We also move get_staff_to_address into Koha::Library alongside inbound_email_address and rename it to inbound_ill_address. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113405|0 |1 is obsolete| | --- Comment #170 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113470&action=edit Bug 22818: (QA follow-up) Template CASE correction Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113407|0 |1 is obsolete| | --- Comment #172 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113472&action=edit Bug 22818: (QA follow-up) Sample Notices Convert the update notices to TT syntax and add them into the sample_notices file. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113409|0 |1 is obsolete| | Attachment #113410|0 |1 is obsolete| | --- Comment #174 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113474&action=edit Bug 22818: (follow-up) Respond to feedback This commit fixes this bug, it was broken in a number of ways. Fixes include: - Added necessary config block in C4::Letters to enable the TT notice syntax introduced in an earlier commit to work - Changed template variables to refer to singular objects rather than multiple e.g. borrowers -> borrower - Fixed missing / misnamed variables This commit also implements the additional syspref checks suggested by Katrin in comment #87 Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113411|0 |1 is obsolete| | --- Comment #176 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113476&action=edit Bug 22818: (QA follow-up) Add sample ILL notices to it-IT installer Run: prove xt/sample_notices.t de-DE are missing on purpose because of bug 24972. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #113413|0 |1 is obsolete| | --- Comment #178 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113478&action=edit Bug 22818: (QA follow-up) Add hint to new library ILL email setting Copies the hints on the other email fields highlighting the existing global pref. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #180 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- (In reply to Jonathan Druart from comment #162)

Those changes are not expected:

- my $library = Koha::Libraries->find($params->{current_branchcode}) + my $branch = Koha::Libraries->find($params->{current_branchcode})

I'm afraid I don't understand. In this patch https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113409&action=diff I fixed a misnamed variable, from $library -> $branch, which is the change you've highlighted above. Why is this unexpected?

2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it explicit on the interface to not cause confusion?

Sorry, I don't understand, make it explicit where in the interface? It's listed, and can be selected, along with all the other log actions in the "Browse the system logs" page. Is this where you are talking about?

3. +use Koha::MessageAttributes; +use Koha::MessageAttribute;

You only need to include the Koha::Object*s* class.

Good spot, thanks, now fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #182 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #180)

(In reply to Jonathan Druart from comment #162)

...

Those changes are not expected:

- my $library = Koha::Libraries->find($params->{current_branchcode}) + my $branch = Koha::Libraries->find($params->{current_branchcode})

I'm afraid I don't understand. In this patch https://bugs.koha-community.org/bugzilla3/attachment. cgi?id=113409&action=diff I fixed a misnamed variable, from $library -> $branch, which is the change you've highlighted above. Why is this unexpected?

We prefer "library" over "branch" https://wiki.koha-community.org/wiki/Terminology

...

2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it explicit on the interface to not cause confusion?

Sorry, I don't understand, make it explicit where in the interface? It's listed, and can be selected, along with all the other log actions in the "Browse the system logs" page. Is this where you are talking about?

On the log viewer, there is a checkbox "Send a notice to a patron" with a code "PATRON_NOTICE". Which implies you will see all the notices sent. But actually we only support 2 notices, the ones you have created. I think this should cover all notices and be moved to a separate bug report. Or we improve the wording... -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #184 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

We prefer "library" over "branch" https://wiki.koha-community.org/wiki/Terminology

...

...

2. PATRON_NOTICE is (so far) only for ILL notices, should not we make it explicit on the interface to not cause confusion?

Sorry, I don't understand, make it explicit where in the interface? It's listed, and can be selected, along with all the other log actions in the "Browse the system logs" page. Is this where you are talking about?

On the log viewer, there is a checkbox "Send a notice to a patron" with a code "PATRON_NOTICE". Which implies you will see all the notices sent. But actually we only support 2 notices, the ones you have created. I think this should cover all notices and be moved to a separate bug report. Or we improve the wording...

Ah! Suggestions: We change the wording on the log viewer to read: "ILL notice sent to patron" and create a new bug report for widening the support of this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #186 from Katrin Fischer <katrin.fischer@bsz-bw.de> ---

...

Ah! Suggestions: We change the wording on the log viewer to read: "ILL notice sent to patron" and create a new bug report for widening the support of this?

I understood the same. Do we agree the notices codes could refer to ILL more explicitly as well?

No! Sorry, that was my fault. They all include ILL in their codes already nicely. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #187 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #189 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 113522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113522&action=edit Bug 22818: Fix TestBuilder.t t/db_dependent/TestBuilder.t .. 12/13 # Failed test 'build_object() tests' # at t/db_dependent/TestBuilder.t line 429. Can't locate object method "_new_from_dbic" via package "Koha::MessageAttribute" (perhaps you forgot to load "Koha::MessageAttribute"?) at /kohadevbox/koha/Koha/Objects.pm line 98. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #190 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 113549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=113549&action=edit Bug 22818: (QA follow-up) Respond to feedback This commit addresses the requests from Jonathan in comment #188 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 --- Comment #192 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Andrew Isherwood from comment #191)

(In reply to Jonathan Druart from comment #188)

...

3. t/db_dependent/Illrequests.t is passing but, only when run once:

I can't replicate this:

Did you try $prove t/db_dependent/Circulation.t t/db_dependent/Circulation/issue.t t/db_dependent/Illrequests.t -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #194 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Same, I can't recreate anymore, weird! Will see later if it popups. Last patch pushed to master. -- You are receiving this mail because: You are watching all bug changes.