https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=2812 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I did some digging and it looks like there should be no button when the hold is waiting or in transfer already. (see bug 12876) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 67480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67480&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Works as described! :) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just confirming the above by doublechecking the code: Cancel button calls opac-modrequest.pl (once called only in opac-user) opac-modrequest.pl checks with CanReserveBeCanceledFromOpac. This sub returns false for waiting or transit. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67520|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 69077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69077&action=edit Bug 18856 - Cancel Waiting Hold in OPAC does not give useful message If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|16.11 |master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jessie Zairo <jzairo@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294&action=edit Bug 18856 [QA Followup] - Catch missed instance of is_cancelable -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 70398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70398&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69077|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 70419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70419&action=edit [ALTERNATIVE-PATCH] Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #15 from Barton Chittenden <barton@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #14)

Kyle, Katrin and Marcel, could you take a look at this l ast patch? It sounds better to me to keep the method and fix its behaviour instead of testing is_found that can be confusing. Feel free to obsolete it if you disagree and I will pushed Kyle's patches with a follow-up to remove the method and the tests.

The problem with 'is_cancelable' is that staff and opac have different views of whether the item is cancelable or not, whereas is_found is un-ambiguous. is_cancelable *sounds* like it's clearer because it signals its intent, but under the circumstances, I think 'is_found' is better. Just my humble opinion; I'm also probably missing context because I haven't taken the time to read the code, so take my words with a large grain of salt. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #16 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Yes Barton you are right, that's why I added a comment to the POD of the method to tell it only applies for the OPAC. Maybe rename the method to something more verbose (is_cancelable_from_opac) to remove the ambiguity? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Axelle Aix-Marseille Université <axelle.clarisse@univ-amu.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |axelle.clarisse@univ-amu.fr -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70398|0 |1 is obsolete| | Attachment #70399|0 |1 is obsolete| | Attachment #70419|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 70424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70424&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #20 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #17)

is_found is also a bit confusing, because this also includes transit items. found = F in the reserves table is for waiting. So you might not think about the transit items as well immediately. It confused me on testing this.

found=W is waiting found=F is finished (only in deleted reserves) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- You are absolutely right, Marcel. Tired brain. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #24 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looking at bug 4319: We also have C4::Reserves::IsItemOnHoldAndFound that does exactly the same thing. So maybe "is_cancelable" is too specific? What could we do to keep this code simple, understandable and consistent? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Juan Romay Sieira <juan.sieira@xercode.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |juan.sieira@xercode.es --- Comment #25 from Juan Romay Sieira <juan.sieira@xercode.es> --- I think de better option is to add a parameter in is_cancelable, what Marcel explains -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Liz Rea <liz@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz@catalyst.net.nz --- Comment #27 from Liz Rea <liz@catalyst.net.nz> --- I'm with Hugh. What should probably happen here, is that if a user cancels the waiting hold from the OPAC, it should be immediately expired, and put on the "expired holds" ("holds waiting over x days) list in the staff interface. Items on this list are necessarily actioned by librarians, i.e. pulled off the hold shelf and returned to circulation or moved on to the next borrower. If we need a message for the borrower, it should be something like "This hold is waiting for you at the library, canceling this hold will remove you from the list and immediately make the item available to other library users. Cancel this hold anyway? / Do not cancel this hold" We could even do a separate tab for these on that waitingreserves page, if that makes the decision easier. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I agree with Hugh and Liz that we might want to rethink the policy of not allowing patrons to cancel waiting holds, but think the fix might need a bit more thought. Would we like to know that the user cancelled it (for statistics)? My suggestion would be to fix the current behaviour (not allow cancelling but give a good message/not show the button) for the stable releases and do a better fix for the next release that allows to change the behaviour. Given we have a feature in Koha to 'punish' people who don't pick up their waiting items (ExpireReservesMaxPickUpDelayCharge), libraries might have different ideas about this? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #31 from Hugh Rundle <hughr@brimbank.vic.gov.au> --- +1 on a quick fix, current behaviour is baffling to patrons. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #33 from Hugh Rundle <hughr@brimbank.vic.gov.au> --- If I am understanding correctly what the patch does (removes the cancel button from allocated holds), then yes, it qualifies as a quick fix. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70424|0 |1 is obsolete| | Attachment #70425|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 75394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75394&action=edit Bug 18856: Don't show cancel option for waiting holds in OPAC This is the alternative patch of Kyle's """ If a hold is 'waiting' for the patron to collect then the patron should be prevented from cancelling the hold via their account in the opac. If a patron tries to cancel the hold, Koha will give an 'are you sure' alert and when you click Yes the page just refreshes and the hold remains. Staff can cancel the hold from the staff interface but they can then action the waiting hold. I think therefore that it is correct behaviour that a patron cannot cancel a hold when it reaches waiting state via the opac but it would be useful to either have a warning to prevent the cancellation or a useful message when they attempt to do so. The template was using a method that tells Koha if *staff* can cancel a hold, instead of patron. Test Plan: 1) Set up a waiting hold 2) Try to cancel it from the opac 3) Note you cannot 4) Apply this patch 5) Reload the page 6) Note the cancel button has disappeared for found holds """ It sounds better to keep the ->is_cancelable method, for readability Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- This is a quick fix, the other point mentioned in earlier comments should go on a new enhancement. Why not add it to 18.05 still, Joubu ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #38 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- is_waiting_or_transit ? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |fridolin.somers@biblibre.co | |m --- Comment #40 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.08 -- You are receiving this mail because: You are watching all bug changes.