[Bug 36495] New: Add resource_not_found() and resource_deleted() helpers
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Bug ID: 36495 Summary: Add resource_not_found() and resource_deleted() helpers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST API Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com CC: tomascohen@gmail.com In order to get consistent in our response structures I propose to introduce a couple Mojolicious helpers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |36482, 36483 Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 [Bug 36482] Make it possible to embed desks and cash_registers on /libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 [Bug 36483] Calling $object->to_api directly should be avoided -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #1 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164291&action=edit Bug 36495: Add resource_not_found() and resource_deleted() helpers This patch introduces two helpers to be used in controllers. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/responses.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com, | |m.de.rooy@rijksmuseum.nl, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #2 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164297&action=edit Bug 36495: Use resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. I proposed to discuss on the next meeting, how to make this more consistent. For reference: ```shell git grep resource_not_found ``` and see the different use cases in the codebase. Once we settle on the matter, I will provide a follow-up to make them all the same. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #3 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164301&action=edit Bug 36495: Use resource_deleted() helper everywhere This patch makes the API controllers use the resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'd be tempted to "fix" the "Object" cases here too.. currently we're just using the helper as is, but there are a few obvious cases to be where we could upgrade the generic "Object not found" to be more specific and return"Vendor not found" for example. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Or... Did we want to go the other way and make them all consistently "Object" instead.. ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- Yes I agree with Martin, we should adjust "Object". I think we shouldn't use the generic "Object" term. For GET /patrons/{patron_id}/holds/{hold_id} we certainly want to see the difference between "Patron not found" and "Hold not found". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
Yes I agree with Martin, we should adjust "Object". I think we shouldn't use the generic "Object" term. For GET /patrons/{patron_id}/holds/{hold_id} we certainly want to see the difference between "Patron not found" and "Hold not found".
I didn't do it right away so we could discuss it on the dev meeting. I agree we should make them specific. Not sure if it would be an issue that we expose the non existence of a (patron?) id this way. But as we are using ->search_limited, that should be covered (i.e. the consumer wouldn't know what makes is 'not exist'). Side note: I picked 'Resource' instead of object for the fallback case :-P. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164297|0 |1 is obsolete| | Attachment #164301|0 |1 is obsolete| | --- Comment #8 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164377&action=edit Bug 36495: Use resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. I proposed to discuss on the next meeting, how to make this more consistent. For reference: ```shell git grep resource_not_found ``` and see the different use cases in the codebase. Once we settle on the matter, I will provide a follow-up to make them all the same. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164378&action=edit Bug 36495: Use resource_deleted() helper everywhere This patch makes the API controllers use the resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #10 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164380&action=edit Bug 36495: Trivial tests fixes Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #11 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #6)
Yes I agree with Martin, we should adjust "Object". I think we shouldn't use the generic "Object" term. For GET /patrons/{patron_id}/holds/{hold_id} we certainly want to see the difference between "Patron not found" and "Hold not found".
I went ahead and submitted an updated patch, that goes specific on resource descriptions. Please share your thoughts. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #12 from Jonathan Druart <jonathan.druart@gmail.com> --- Sorry for the late idea but wouldn't it make sense to prefix those generic render helper? Like 'render_resource_deleted'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #13 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Sorry for the late idea but wouldn't it make sense to prefix those generic render helper? Like 'render_resource_deleted'.
I would agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164291|0 |1 is obsolete| | Attachment #164377|0 |1 is obsolete| | Attachment #164378|0 |1 is obsolete| | Attachment #164380|0 |1 is obsolete| | --- Comment #14 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164382&action=edit Bug 36495: Add render_resource_not_found() and render_resource_deleted() helpers This patch introduces two helpers to be used in controllers. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/responses.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #15 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164383&action=edit Bug 36495: Use render_resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #16 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 164384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164384&action=edit Bug 36495: Use render_resource_deleted() helper everywhere This patch makes the API controllers use the render_resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m --- Comment #17 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- There a few occurrences not updated by the patch: grep --color=always -B2 -rnw Koha/REST/V1 -e "status" | grep 404 examples: Koha/REST/V1/Illbackends.pm Koha/REST/V1/Preservation/Trains.pm Koha/REST/V1/Holds.pm Koha/REST/V1/Biblios/ItemGroups.pm and others We'd need a qa script update for this also, correct? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #18 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Pedro Amorim from comment #17)
There a few occurrences not updated by the patch:
grep --color=always -B2 -rnw Koha/REST/V1 -e "status" | grep 404
examples: Koha/REST/V1/Illbackends.pm Koha/REST/V1/Preservation/Trains.pm Koha/REST/V1/Holds.pm Koha/REST/V1/Biblios/ItemGroups.pm
and others
We'd need a qa script update for this also, correct?
Maybe. Not all 404 cases need to be handled the same way. Some I left out, like the ItemGroups one is because they were returning more useful information than with this helper. Not sure how relevant it is. Can we please move forward with this? There seems to be a bunch of new endpoint patches submitted and it would be great if they were built on top of this. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #19 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #12)
Sorry for the late idea but wouldn't it make sense to prefix those generic render helper? Like 'render_resource_deleted'.
Done, can we move forward? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36505 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36505 [Bug 36505] Allow updating patron attributes via PUT -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #20 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I'm happy with this now as it stands.. as soon as I can get the dependencies all applying I'll add my signature. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #21 from Jonathan Druart <jonathan.druart@gmail.com> --- What's the pattern to reject? "status\s*=>\s*404" in Koha/REST/V1? We need a QA script check + unit test in Koha for this change. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #22 from Tomás Cohen Arazi <tomascohen@gmail.com> --- (In reply to Jonathan Druart from comment #21)
What's the pattern to reject? "status\s*=>\s*404" in Koha/REST/V1?
We need a QA script check + unit test in Koha for this change.
I had doubts because of this you can read below: (In reply to Tomás Cohen Arazi from comment #18)
Maybe. Not all 404 cases need to be handled the same way. Some I left out, like the ItemGroups one is because they were returning more useful information than with this helper. Not sure how relevant it is.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164382|0 |1 is obsolete| | Attachment #164383|0 |1 is obsolete| | Attachment #164384|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164971&action=edit Bug 36495: Add render_resource_not_found() and render_resource_deleted() helpers This patch introduces two helpers to be used in controllers. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/responses.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164972&action=edit Bug 36495: Use render_resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #25 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 164973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164973&action=edit Bug 36495: Use render_resource_deleted() helper everywhere This patch makes the API controllers use the render_resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #26 from Jonathan Druart <jonathan.druart@gmail.com> --- All good to me, but we need to plan to prevent regressions. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164971|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164983&action=edit Bug 36495: Add render_resource_not_found() and render_resource_deleted() helpers This patch introduces two helpers to be used in controllers. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/responses.t => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164972|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164984&action=edit Bug 36495: Use render_resource_not_found() helper everywhere This patch makes the existing controllers use the new helpers for (most) 404 situations. The remaining ones are subject to discussion. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1/ => SUCCESS: Tests pass! 3. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #164973|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 164985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=164985&action=edit Bug 36495: Use render_resource_deleted() helper everywhere This patch makes the API controllers use the render_resource_deleted() helper. No behavior changes are expected. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ prove t/db_dependent/api/v1 => SUCCESS: Nothing broke 3. Sign off :-D Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #30 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Passing QA, this is a great improvement. We're working on the QA scripts in the background.. discussion already taking place on mattermost. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add resource_not_found() |Add |and resource_deleted() |render_resource_not_found() |helpers |and | |render_resource_deleted() | |helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #32 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Created attachment 165696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=165696&action=edit Bug 36495: Fix erm_counter_files.t Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 --- Comment #33 from Tomás Cohen Arazi <tomascohen@gmail.com> --- @RM: I pushed the last follow-up to fix a follow-up :-D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to main |Needs documenting --- Comment #34 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not backported to 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Bug 36495 depends on bug 36483, which changed state. Bug 36483 Summary: Calling $object->to_api directly should be avoided https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36483 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Needs documenting |RESOLVED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #35 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Architecture change, nothing to add/edit in the Koha manual. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37672 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37672 [Bug 37672] V1/RecordSources.pm should use more helpers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37686 [Bug 37686] render_resource_not_found() and render_resource_deleted() misses -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36495 Bug 36495 depends on bug 36482, which changed state. Bug 36482 Summary: Make it possible to embed desks and cash_registers on /libraries https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36482 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org