I noticed (what I consider) a weird behaviour on OpanHiddenItems. It is effectively described on the commit message introducing it: Bug 10584 - Hide OPAC biblio details if all items are hidden If there are items for a given biblio number, and they are all hidden, then biblio needs to be hidden. If the biblio needs to be hidden, it immediately redirects to a 404.pl page, just as if the biblionumber does not exist. Is this a desired behaviour? Should biblios be hidden if all items they contain are marked to be hidden? I think there might be specific use cases in which this could be useful, but definitely something we should provide a way to opt-in/out I'm looking forwards for your opinions! Thanks! -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
Marcel de Rooy writes:
Is this a desired behaviour? Should biblios be hidden if all items they contain are marked to be hidden?
I would say No. This should not be the general rule, I guess.
But I feel another pref coming soon ;)
+1 I can see this being used either way tbh. Tomas, I imagine you are bringing it up because you currently have a specific use case against this? Else I don't see the reason to 'fix' this until someone actually has a use case that deviates from what currently exists. 2¢, Alex
Hi I have no reason to hide bib record if there is no public items, I prefer to decide to to show it in any case Hugo 2017-07-27 15:09 GMT+02:00 Alex Sassmannshausen < alex.sassmannshausen@gmail.com>:
Marcel de Rooy writes:
Is this a desired behaviour? Should biblios be hidden if all items they contain are marked to be hidden?
I would say No. This should not be the general rule, I guess.
But I feel another pref coming soon ;)
+1
I can see this being used either way tbh. Tomas, I imagine you are bringing it up because you currently have a specific use case against this?
Else I don't see the reason to 'fix' this until someone actually has a use case that deviates from what currently exists.
2¢,
Alex _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
El jue., 27 jul. 2017 a las 13:00, Katrin Fischer (<Katrin.Fischer.83@web.de>) escribió:
Hi Tomas,
we rely heavily on the described behaviour to hide the record if all items are hidden. It seems logical to me - what will a user do with a record, that has no items? They can't place a hold, they don't know where to find it, which library owns copies etc. To me it seems more confusing then helpful.
I think we shouldn't change the behaviour, especially because it has always worked like described and libraries might be unpleasantly surprised by a sudden change. Having the different behaviour as a configuration option would make sense.
Yeap, I filed this bug to deal with this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
I can basically reiterate what Katrin said; we rely on this behavior and I wouldn't want it to change. Of course, implementing an opt-in syspref is a fine alternative. Depending on what's appropriate to your situation, it seems like you could just create a visible placeholder item as a workaround to get the bib to display. Best, ERIC PHETTEPLACE Systems Librarian libraries.cca.edu | vault.cca.edu | 510.594.3660 5212 Broadway, Oakland, CA 94618 1111 8th St., San Francisco, CA 94107 Preferred Pronoun(s): he/him :(){ :|: & };: On Thu, Jul 27, 2017 at 9:03 AM, Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
El jue., 27 jul. 2017 a las 13:00, Katrin Fischer (< Katrin.Fischer.83@web.de>) escribió:
Hi Tomas,
we rely heavily on the described behaviour to hide the record if all items are hidden. It seems logical to me - what will a user do with a record, that has no items? They can't place a hold, they don't know where to find it, which library owns copies etc. To me it seems more confusing then helpful.
I think we shouldn't change the behaviour, especially because it has always worked like described and libraries might be unpleasantly surprised by a sudden change. Having the different behaviour as a configuration option would make sense.
Yeap, I filed this bug to deal with this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
Regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
I completely agree we shouldn't introduce a behaviour change. I would rather propose being able to choose the behaviour, keeping the current as default. As we always do :-D I was just asking because it didn't seem natural to me. And the use cases I'm seeing require the biblio to be displayed, because it contains links to the digital version of the resource. Regards El jue., 27 jul. 2017 a las 13:26, Eric Phetteplace (<ephetteplace@cca.edu>) escribió:
I can basically reiterate what Katrin said; we rely on this behavior and I wouldn't want it to change. Of course, implementing an opt-in syspref is a fine alternative. Depending on what's appropriate to your situation, it seems like you could just create a visible placeholder item as a workaround to get the bib to display.
Best,
ERIC PHETTEPLACE
Systems Librarian
libraries.cca.edu | vault.cca.edu | 510.594.3660 <(510)%20594-3660>
5212 Broadway, Oakland, CA 94618
1111 8th St., San Francisco, CA 94107
Preferred Pronoun(s): he/him
:(){ :|: & };:
On Thu, Jul 27, 2017 at 9:03 AM, Tomas Cohen Arazi <tomascohen@gmail.com> wrote:
El jue., 27 jul. 2017 a las 13:00, Katrin Fischer (< Katrin.Fischer.83@web.de>) escribió:
Hi Tomas,
we rely heavily on the described behaviour to hide the record if all items are hidden. It seems logical to me - what will a user do with a record, that has no items? They can't place a hold, they don't know where to find it, which library owns copies etc. To me it seems more confusing then helpful.
I think we shouldn't change the behaviour, especially because it has always worked like described and libraries might be unpleasantly surprised by a sudden change. Having the different behaviour as a configuration option would make sense.
Yeap, I filed this bug to deal with this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989
Regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 <+54%209%20351%20351-3384> GPG: B2F3C15F
_______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
-- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/>) ✆ +54 9351 3513384 GPG: B2F3C15F
I can’t recall exactly how we use it but I think we count on the default behaviour as well. I remember discussing this with Katrin years ago. But I also see the merit of requiring the biblio to be displayed because it contains links to the digital version of the resource. Many of our libraries create dummy items that contain links, but I prefer using the 856$u myself. David Cook Systems Librarian Prosentient Systems 72/330 Wattle St Ultimo, NSW 2007 Australia Office: 02 9212 0899 Direct: 02 8005 0595 From: koha-devel-bounces@lists.koha-community.org [mailto:koha-devel-bounces@lists.koha-community.org] On Behalf Of Tomas Cohen Arazi Sent: Friday, 28 July 2017 2:54 AM To: Eric Phetteplace <ephetteplace@cca.edu> Cc: koha-devel <koha-devel@lists.koha-community.org> Subject: Re: [Koha-devel] OpacHiddenItems behaviour | Bug 10584 I completely agree we shouldn't introduce a behaviour change. I would rather propose being able to choose the behaviour, keeping the current as default. As we always do :-D I was just asking because it didn't seem natural to me. And the use cases I'm seeing require the biblio to be displayed, because it contains links to the digital version of the resource. Regards El jue., 27 jul. 2017 a las 13:26, Eric Phetteplace (<ephetteplace@cca.edu <mailto:ephetteplace@cca.edu> >) escribió: I can basically reiterate what Katrin said; we rely on this behavior and I wouldn't want it to change. Of course, implementing an opt-in syspref is a fine alternative. Depending on what's appropriate to your situation, it seems like you could just create a visible placeholder item as a workaround to get the bib to display. Best, ERIC PHETTEPLACE Systems Librarian libraries.cca.edu <http://libraries.cca.edu> | vault.cca.edu <http://vault.cca.edu> | 510.594.3660 <tel:(510)%20594-3660> <https://www.cca.edu/sites/default/files/images/2017/02/cca-sig-logo.png> 5212 Broadway, Oakland, CA 94618 1111 8th St., San Francisco, CA 94107 Preferred Pronoun(s): he/him :(){ :|: & };: On Thu, Jul 27, 2017 at 9:03 AM, Tomas Cohen Arazi <tomascohen@gmail.com <mailto:tomascohen@gmail.com> > wrote: El jue., 27 jul. 2017 a las 13:00, Katrin Fischer (<Katrin.Fischer.83@web.de <mailto:Katrin.Fischer.83@web.de> >) escribió: Hi Tomas, we rely heavily on the described behaviour to hide the record if all items are hidden. It seems logical to me - what will a user do with a record, that has no items? They can't place a hold, they don't know where to find it, which library owns copies etc. To me it seems more confusing then helpful. I think we shouldn't change the behaviour, especially because it has always worked like described and libraries might be unpleasantly surprised by a sudden change. Having the different behaviour as a configuration option would make sense. Yeap, I filed this bug to deal with this: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18989 Regards -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 <tel:+54%209%20351%20351-3384> GPG: B2F3C15F _______________________________________________ Koha-devel mailing list Koha-devel@lists.koha-community.org <mailto:Koha-devel@lists.koha-community.org> http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-devel website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/ -- Tomás Cohen Arazi Theke Solutions (https://theke.io <http://theke.io/> ) ✆ +54 9351 3513384 GPG: B2F3C15F
participants (7)
-
Alex Sassmannshausen -
David Cook -
Eric Phetteplace -
Hugo Agud -
Katrin Fischer -
Marcel de Rooy -
Tomas Cohen Arazi