[Bug 41608] New: Ability to select multiple values of a facet in the professional interface
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Bug ID: 41608 Summary: Ability to select multiple values of a facet in the professional interface Initiative type: --- Sponsorship --- status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: mathsabypro@gmail.com QA Contact: testopia@bugs.koha-community.org In the professional interface, we should be able to select several values from a facet in a single operation (e.g., several libraries, several languages, etc.), so that Koha applies the "OR" operator between each value (e.g., return documents present in library A or library B) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Comma delimited| |Kohala Association list of Sponsors| | Sponsorship status|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #1 from Mathieu Saby <mathsabypro@gmail.com> --- Kohala association is sponsoring this enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #2 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 201434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=201434&action=edit Bug 41608: add support for multiple facets Test plan: - start KTD - on staff interface, search for "complete" - you should get around 10 results - there are checkboxes in front of the facets, check "Austen, Jane" and "Beckett, Samuel" - click on "Refine Search" at the bottom of the facets menu - You should get a refined search with "complete" from both Jane Austen and Samuel Beckett. - If you check "Centerville" the CCL query should also show "holdingbranch:CPL". - If you uncheck "Centerville" the CCL should go back to "kw:complete and (au:Austen, Jane or au:Beckett, Samuel)" - repeat for OPAC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Michaela Sieber <michaela.sieber@kit.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clemens.tubach@kit.edu, | |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #3 from David Cook <dcook@prosentient.com.au> --- Hmm this is an interesting one. I can 100% understand using checkboxes instead of clicking the link/the little X. I think most modern facetted search engines update the interface immediately after a checkbox check/uncheck, but they tend to be extremely fast at returning results. That said, I had a case recently where my Internet was poor and it was so frustrating because the search results would take a long time to load on a retail site. It made the UI almost unusable... I think we'd want to system preference this one... but it's an interesting idea for sure. I think Koha might benefit from having to click a button to apply the facet filters rather than doing it immediately. It would improve the speed of getting the desired results for users (better UX) and it would mean fewer operations (less load on the server). I don't know about "Refine Search" as the button label though (also it would need to be "Refine search" with a lowercase S to follow Koha rules). I suppose it says "Refine your search" at the top of the facet section but it doesn't seem very modern. Honestly, I think we could probably change "Refine your search" to "Filters" and then have the button be "Apply" or "Apply filters". (Funny enough Ex Libris Primo has a title of "Refine my results" and has two buttons: "Clear" and "Apply Filters". After applying filters, they have "Active filters" shown at the top.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Failed QA --- Comment #4 from David Cook <dcook@prosentient.com.au> --- But yeah since this is UX-based I think a system preference would be wise. -- Looking at the code... "koha-tmpl/intranet-tmpl/prog/js/facets.js" and "koha-tmpl/opac-tmpl/bootstrap/js/facets.js" are basically copy/pasted... which I suppose is difficult to avoid without a "shared-tmpl" directory. Marking "Failed QA" though because I think you're building the query wrong. If you look at how the facets currently work, you'll notice they're added as arguments to "limit" parameters. Guessing AI might've proposed the rewriting of the search query? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com --- Comment #5 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hi David, The purpose to having to click on the button instead of having the search results computed on the fly is actually what we want. So is it for the resulting search query with AND / OR. The problem with the current implementation is : It is impossible to select multiple authors and have results for both. That's why I want to be able to select multiple authors and only then click on the "Refine search". With the current behavior, once I've selected one author, I cannot select another to have results for both in the same list. Hope this gives you a better understanding of the code. Best, Arthur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #6 from David Cook <dcook@prosentient.com.au> --- (In reply to Arthur Suzuki from comment #5)
Hi David, The purpose to having to click on the button instead of having the search results computed on the fly is actually what we want.
Yep, I understand that.
So is it for the resulting search query with AND / OR. The problem with the current implementation is : It is impossible to select multiple authors and have results for both. That's why I want to be able to select multiple authors and only then click on the "Refine search".
With the current behavior, once I've selected one author, I cannot select another to have results for both in the same list.
Thanks for that explanation. That's an interesting point. I think that should probably be a separate bug report to be honest as that's a separate (yet related) issue. -- It's interesting because... I might want to choose several different "Item types" for my results. Maybe I want both "book" and "ebook". That's something that you'd expect to see on a retail site. But then with "Authors" maybe I'm trying to refine my search to find particular authors that co-wrote resources together, so doing the "AND" rather than the "OR" might make sense... but then if you were trying to do that it would be more appropriate to use the Advanced Search rather than the facets/filters. So yeah I think maybe it's a bug. It probably makes sense to AND different types of facets/filters, but when the type is the same it should probably be ORed. I suspect that people will be upset either way, so it might be necessary to have a system preference for it... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- Consider in KTD the following: /cgi-bin/koha/opac-search.pl?idx=kw&q=e&limit=itype%3ABK&limit=itype%3AVM&sort_by=relevance&count=20 This only shows records that have both "Books" and "Visual Materials" indexed item types. That's probably not what we want most of the time. /cgi-bin/koha/opac-search.pl?advsearch=1&q=e&weight_search_submitted=1&weight_search=1&do=Search&limit=mc-itype%2Cphr%3ABK&limit=mc-itype%2Cphr%3AVM&sort_by=relevance This works more like what we'd expect... is that what the "mc-" prefix is all about? Multiple? Something to look at... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #8 from Mathieu Saby <mathsabypro@gmail.com> --- Here are some remarks: 1/ In a sandbox I tried to search "the*" (229 results) then filter the results with 1 or more values in a facet Oddly it display an error message : No results match your search for 'kw,wrdl: "ccl=(kw:the*) AND (ccode:FIC)" Same issue with "book" and 2 values: No results match your search for 'kw,wrdl: "ccl=(kw:book) AND ((au:Alatriste, Gustavo) OR (au:Brook, Claudio))"'. But the search for "complete" is working well, I don't understand how... 2/ the "Refine" button should be always visible. It is currently at the bottom of the facets, on my little laptop it is not visible, I need to scroll to find it. It should be always visible. Maybe on top of the facets block, and sticky? 3/ The ideal would be to find a user-friendly way for the user to choose whether to combine values using “OR” or “AND”. Is your patch working that way? I am not sure of that, due to the odd results for my queries. In Primo, for example you can - click on the label of 1 value (ex: Library A), get the filtered results, then click on a 2d value of the same facet (ex : Library B), get the filtered-filtered results => in that case the system combine the facets with a "AND" - check the box on the left of 2 values of the same facets, then click on "Refine" button. The system combine the facets with a "OR" -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #9 from Mathieu Saby <mathsabypro@gmail.com> --- The sandbox I used to test : https://staff-bz41608.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/mainpage.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #10 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Maybe check the values of those syspref? QueryAutoTruncate QueryFuzzy QueryStemming(In reply to Mathieu Saby from comment #8)
Here are some remarks:
1/ In a sandbox I tried to search "the*" (229 results) then filter the results with 1 or more values in a facet
Oddly it display an error message : No results match your search for 'kw,wrdl: "ccl=(kw:the*) AND (ccode:FIC)"
Same issue with "book" and 2 values: No results match your search for 'kw,wrdl: "ccl=(kw:book) AND ((au:Alatriste, Gustavo) OR (au:Brook, Claudio))"'.
But the search for "complete" is working well, I don't understand how...
2/ the "Refine" button should be always visible. It is currently at the bottom of the facets, on my little laptop it is not visible, I need to scroll to find it. It should be always visible. Maybe on top of the facets block, and sticky?
3/ The ideal would be to find a user-friendly way for the user to choose whether to combine values using “OR” or “AND”. Is your patch working that way? I am not sure of that, due to the odd results for my queries.
In Primo, for example you can - click on the label of 1 value (ex: Library A), get the filtered results, then click on a 2d value of the same facet (ex : Library B), get the filtered-filtered results => in that case the system combine the facets with a "AND" - check the box on the left of 2 values of the same facets, then click on "Refine" button. The system combine the facets with a "OR"
Check some syspref related to search behaviour, maybe try to disable QueryFuzzy, QueryAutotruncate and QueryStemming? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to David Cook from comment #7)
Consider in KTD the following:
/cgi-bin/koha/opac-search. pl?idx=kw&q=e&limit=itype%3ABK&limit=itype%3AVM&sort_by=relevance&count=20
This only shows records that have both "Books" and "Visual Materials" indexed item types. That's probably not what we want most of the time.
/cgi-bin/koha/opac-search. pl?advsearch=1&q=e&weight_search_submitted=1&weight_search=1&do=Search&limit= mc-itype%2Cphr%3ABK&limit=mc-itype%2Cphr%3AVM&sort_by=relevance
This works more like what we'd expect... is that what the "mc-" prefix is all about? Multiple? Something to look at...
I should try this, thanks for the hint! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #12 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to David Cook from comment #6)
It's interesting because... I might want to choose several different "Item types" for my results. Maybe I want both "book" and "ebook". That's something that you'd expect to see on a retail site.
Yes
But then with "Authors" maybe I'm trying to refine my search to find particular authors that co-wrote resources together, so doing the "AND" rather than the "OR" might make sense... but then if you were trying to do that it would be more appropriate to use the Advanced Search rather than the facets/filters.
You could already do that with the current implementation of the facets by refining search I think! (click on the two authors successively?)
So yeah I think maybe it's a bug. It probably makes sense to AND different types of facets/filters, but when the type is the same it should probably be ORed.
That is what we want to propose with this bug :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #13 from Mathieu Saby <mathsabypro@gmail.com> --- (In reply to Arthur Suzuki from comment #10)
Maybe check the values of those syspref? QueryAutoTruncate QueryFuzzy QueryStemming(In reply to Mathieu Saby from comment #8)
Here are some remarks:
1/ In a sandbox I tried to search "the*" (229 results) then filter the results with 1 or more values in a facet
Oddly it display an error message : No results match your search for 'kw,wrdl: "ccl=(kw:the*) AND (ccode:FIC)"
Same issue with "book" and 2 values: No results match your search for 'kw,wrdl: "ccl=(kw:book) AND ((au:Alatriste, Gustavo) OR (au:Brook, Claudio))"'.
But the search for "complete" is working well, I don't understand how...
The sandbox uses Zebra (it cannot use ES), with MARC21 records The syspref have their default values QueryAutoTruncate : automatically QueryFuzzy : try QueryStemming : try I change them to : QueryAutoTruncate : only if * is added QueryFuzzy : dont try QueryStemming : dont try It changes nothing, the search gives no result after a filtering In the search bar I can read : "ccl=(kw:the*) AND ((holdingbranch:CPL) OR (holdingbranch:FPL))" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #14 from Mathieu Saby <mathsabypro@gmail.com> --- But it is working without the * the query in the search bar is : ccl=(kw:the) AND ((holdingbranch:CPL) OR (holdingbranch:FPL)) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #15 from Mathieu Saby <mathsabypro@gmail.com> --- Oh, my 2d example "book" + 2 author facets is now working. The search fails if QueryAutoTruncate is activated, but gives results otherwise. And it fails if an explicit truncature is added at the end of the searched word. So I suppose you need to fix something with the handling of truncation. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #16 from David Cook <dcook@prosentient.com.au> --- (In reply to Arthur Suzuki from comment #12)
So yeah I think maybe it's a bug. It probably makes sense to AND different types of facets/filters, but when the type is the same it should probably be ORed.
That is what we want to propose with this bug :)
Ok but the way to do that would be in how the "limit" parameter is processed rather than changing the CCL query. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #17 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to David Cook from comment #16)
(In reply to Arthur Suzuki from comment #12)
So yeah I think maybe it's a bug. It probably makes sense to AND different types of facets/filters, but when the type is the same it should probably be ORed.
That is what we want to propose with this bug :)
Ok but the way to do that would be in how the "limit" parameter is processed rather than changing the CCL query.
yep, I just got the implementation working, it is indeed much simpler and the compatibility with the current behaviour of searching is better preserved (QueryFuzzy, Truncate, etc...) I will do some more checks and post a bit later. Thx for the hints! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #18 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202617&action=edit Bug 41608: (QA followup) change the JS to build a request with limit params instead of ccl query Patch from commit 78945fc -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202617|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #19 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202618&action=edit Bug 41608: (QA followup) change the JS to build a request with limit params instead of ccl query Patch from commit 78945fc -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #20 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202619&action=edit Bug 41608: (QA followup) Change labels for facets form title and button Patch from commit 39a3d58 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #21 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202620&action=edit Bug 41608: (QA followup) checkboxes are only show if SearchEngine is Elasticsearch Sponsored-by: Kohala Association -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #22 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Hello, I've made the desired changes, also the checkboxes now only appears if the SearchEngine is ElasticSearch (zebra doesn't allow the mc-* indexes). I didn't add another syspref on top of that yet, wanted to make sure the rest is fine before. @Mathieu, we don't plan on making it possible to make complex queries. I'd say if you want to make more complex things, the way to go would be to either use the advanced search or go with CCL. Best, Arthur -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #23 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202660&action=edit Bug 41608: (QA followup) Add the syspref "MultiChoiceFacets" to enable facets checkboxes in the search results Patch from commit 3e75e1a -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202660|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #24 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202661&action=edit Bug 41608: (QA followup) Add a new syspref MultiChoiceFacets Patch from commit 938ef83 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |laurence.rault@biblibre.com --- Comment #25 from Laurence Rault <laurence.rault@biblibre.com> --- On ktd Patch application failed for attachment 202661 - Bug 41608: (QA followup) Add a new syspref MultiChoiceFacets Error: Apply failed: Git command (git am -3 /tmp/8KsH0sqt4l/0005-202661.patch) failed: error: sha1 information is lacking or useless (installer/data/mysql/atomicupdate/bug41608_multichoicefacets.pl). error: could not build fake ancestor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #202661|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #26 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202662&action=edit Bug 41608: (QA followup) Add the syspref "MultiChoiceFacets" to enable facets checkboxes in the search results Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl Component|Searching |Z39.50 / SRU / OpenSearch | |Servers Status|Patch doesn't apply |Needs Signoff --- Comment #27 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- there was an issue with the last patch, I've re-uploaded it, it should apply now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #28 from Laurence Rault <laurence.rault@biblibre.com> --- Patch applies First comments : 1) when the syspref MultiChoiceFacets is not active, the button Apply is still visible 2) when the syspref is active, the checkboxes are in the page, but not visible, so it is not easy for testing... input[type=checkbox], input[type=radio] { height: unset; margin: 3px 3p If I remove height: unset;, they are visible and usable, and filtering seems to be ok. But I prefer this to be solved before going on with the search tests. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #29 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202663&action=edit Bug 41608: if MultiChoiceFacets is disabled, do not show 'Apply' button Patch from commit a0af240 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #30 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Laurence Rault from comment #28)
Patch applies
First comments :
1) when the syspref MultiChoiceFacets is not active, the button Apply is still visible
Just solved that one in a new patch.
2) when the syspref is active, the checkboxes are in the page, but not visible, so it is not easy for testing...
input[type=checkbox], input[type=radio] { height: unset; margin: 3px 3p
If I remove height: unset;, they are visible and usable, and filtering seems to be ok.
But I prefer this to be solved before going on with the search tests.
Huum, I cannot reproduce this issue... Once you've started ktd can you try to recompile the CSS? with the command "yarn build"? You may have an older version of the CSS loaded. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #31 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 202665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=202665&action=edit Bug 41608: (QA followup) do not check removed facets upon page load Patch from commit 2ed711b -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |arthur.suzuki@biblibre.com |ity.org | Component|Z39.50 / SRU / OpenSearch |Searching - Elasticsearch |Servers | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Laurence Rault <laurence.rault@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #32 from Laurence Rault <laurence.rault@biblibre.com> --- Patch application failed for attachment 201434 - Bug 41608: add support for multiple facets Application tested on ktd and on sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #33 from Mathieu Saby <mathsabypro@gmail.com> --- If you can rebase it, I am available for testing it again this week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #201434|0 |1 is obsolete| | Attachment #202618|0 |1 is obsolete| | Attachment #202619|0 |1 is obsolete| | Attachment #202620|0 |1 is obsolete| | Attachment #202662|0 |1 is obsolete| | Attachment #202663|0 |1 is obsolete| | Attachment #202665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #34 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203724&action=edit Bug 41608: add support for multiple facets Test plan: - start KTD - on staff interface, search for "complete" - you should get around 10 results - there are checkboxes in front of the facets, check "Austen, Jane" and "Beckett, Samuel" - click on "Refine Search" at the bottom of the facets menu - You should get a refined search with "complete" from both Jane Austen and Samuel Beckett. - If you check "Centerville" the CCL query should also show "holdingbranch:CPL". - If you uncheck "Centerville" the CCL should go back to "kw:complete and (au:Austen, Jane or au:Beckett, Samuel)" - repeat for OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #35 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203725&action=edit Bug 41608: (QA followup) change the JS to build a request with limit params instead of ccl query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #36 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203726&action=edit Bug 41608: (QA followup) Change labels for facets form title and button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #37 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203727&action=edit Bug 41608: (QA followup) checkboxes are only show if SearchEngine is Elasticsearch Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #38 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203728&action=edit Bug 41608: (QA followup) Add the syspref "MultiChoiceFacets" to enable facets checkboxes in the search results Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #39 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203729&action=edit Bug 41608: if MultiChoiceFacets is disabled, do not show 'Apply' button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #40 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203730&action=edit Bug 41608: (QA followup) do not check removed facets upon page load -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #41 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #33)
If you can rebase it, I am available for testing it again this week.
Done, can you try on a sandbox? you'll need an ElasticSearch sandbox for that to work, it doesn't work with Zebra -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #42 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 203736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203736&action=edit Bug 41608: (QA followup) make the multifacet feature available for Zebra as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #43 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Arthur Suzuki from comment #41)
(In reply to Mathieu Saby from comment #33)
If you can rebase it, I am available for testing it again this week.
Done, can you try on a sandbox? you'll need an ElasticSearch sandbox for that to work, it doesn't work with Zebra
Now works on both (since last patch uploaded) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Mathieu Saby <mathsabypro@gmail.com> --- I tested with KTD, with ES and Zebra, and noted those issues : 1/ The search behavior is broken with Zebra if you combine "multi-facets" with "classic" facets - search "the" - check both boxes "Fiction" and "Non-Fiction" in Collections facets - Apply => 23 results - click on "Centerville" Library => 0 results It seems the "mc-ccode" is wrongly changed into a simple "ccode". It should not, and this is not the case with Elasticsearch 2/ You should rephrase the syspref (remove the "when using Elasticsearch"), as it applies also if Zebra is used 3/ The Apply button is not very visible, especially on small screens, or if you have a lot of facets. I have seen that in the Bokeh discovery tool this button is show twice, at top and at bottom of the facets. What do you think of this solution? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #45 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 204072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204072&action=edit Bug 41608: (QA followup) properly store multichoices limits in the cgi query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #46 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 204073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204073&action=edit Bug 41608: (QA followup) add the facets submit button at the top of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #47 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 204074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204074&action=edit Bug 41608: (QA followup) fix the JS to properly escape doublequote in authorized value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #48 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 204075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=204075&action=edit Bug 41608: (QA followup) change MultiChoiceFacet syspref description (not limited to ES) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #49 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #44)
I tested with KTD, with ES and Zebra, and noted those issues :
Hello Mathieu, I've uploaded a bunch (4) new patches to address all you comments. for all of them, including the last one, you're perfectly right. please re-apply and test again! Best, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #50 from Mathieu Saby <mathsabypro@gmail.com> --- I believe the "MultiChoiceFacets" should be in "Results display" section (like other syspref related to facets) and not in "Search form". Do you agree? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #51 from Mathieu Saby <mathsabypro@gmail.com> --- Sorry but with Zebra the checkboxes are not visible. In Chrome devtools I can see this CSS: "height: unset" -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #52 from Mathieu Saby <mathsabypro@gmail.com> --- I tried to relaunch my ktd and it seems to solve the CSS issue. But from my perspective, there's something inconsistent about the way to deselect a facet. Could you give me your opinion? In the old system, if a value is selected, it appears followed by an [x], with a tooltip that says "Remove ..." In the new system > if you select multiple values using the checkbox, there is no "[x]" > if you select a single value using the checkbox, there is no "[x]" > if you click on a value without using the checkbox (which, in terms of filtering, is functionally the same as checking the checkbox), it works like in the old system: the value is followed by an "[x]" followed by "Remove" - Then, if you refine the search by clicking on another value in a different facet, that new value will also be followed by "[x]" - Then, if you refine the search by selecting multiple values for another facet, all the "[x]" symbols disappear - if you play around with all of this by adding different layers of facets, you might end up with a pretty weird display. In short, this is inconsistent, and I think that if the preference is enabled, there should be no "[x]" or "Remove" labels at all. These labels make no or little sense in a UI where values are preceded by checkboxes, which allow the user to know which values are actually being used for filtering (unlike the legacy system). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #53 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #50)
I believe the "MultiChoiceFacets" should be in "Results display" section (like other syspref related to facets) and not in "Search form". Do you agree?
Ok, I'll change that -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #54 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #52) > I tried to relaunch my ktd and it seems to solve the CSS issue. > > But from my perspective, there's something inconsistent about the way to > deselect a facet. Could you give me your opinion? > > In the old system, if a value is selected, it appears followed by an [x], > with a tooltip that says "Remove ..." > > In the new system > > if you select multiple values using the checkbox, there is no "[x]" > > if you select a single value using the checkbox, there is no "[x]" > > if you click on a value without using the checkbox (which, in terms of filtering, is functionally the same as checking the checkbox), it works like in the old system: the value is followed by an "[x]" followed by "Remove" > - Then, if you refine the search by clicking on another value in a different > facet, that new value will also be followed by "[x]" > - Then, if you refine the search by selecting multiple values for another > facet, all the "[x]" symbols disappear > - if you play around with all of this by adding different layers of facets, > you might end up with a pretty weird display. > > In short, this is inconsistent, and I think that if the preference is > enabled, there should be no "[x]" or "Remove" labels at all. These labels > make no or little sense in a UI where values are preceded by checkboxes, > which allow the user to know which values are actually being used for > filtering (unlike the legacy system). Actually it is complementary. - select several checkboxes, it will make an "OR" between same types/indexes. - click on several facets, it will make an "AND". - unchecking a checkbox remove the value from the OR. - click on the [x] removes the facet from the "AND". it is not just about UI. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203724|0 |1 is obsolete| | Attachment #203725|0 |1 is obsolete| | Attachment #203726|0 |1 is obsolete| | Attachment #203727|0 |1 is obsolete| | Attachment #203728|0 |1 is obsolete| | Attachment #203729|0 |1 is obsolete| | Attachment #203730|0 |1 is obsolete| | Attachment #203736|0 |1 is obsolete| | Attachment #204072|0 |1 is obsolete| | Attachment #204073|0 |1 is obsolete| | Attachment #204074|0 |1 is obsolete| | Attachment #204075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203736|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204072|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204073|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204074|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #204075|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #203736|0 |1 is obsolete| | Attachment #204072|0 |1 is obsolete| | Attachment #204073|0 |1 is obsolete| | Attachment #204074|0 |1 is obsolete| | Attachment #204075|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #55 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206970&action=edit Bug 41608: add support for multiple facets Test plan: - start KTD - on staff interface, search for "complete" - you should get around 10 results - there are checkboxes in front of the facets, check "Austen, Jane" and "Beckett, Samuel" - click on "Refine Search" at the bottom of the facets menu - You should get a refined search with "complete" from both Jane Austen and Samuel Beckett. - If you check "Centerville" the CCL query should also show "holdingbranch:CPL". - If you uncheck "Centerville" the CCL should go back to "kw:complete and (au:Austen, Jane or au:Beckett, Samuel)" - repeat for OPAC. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #56 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206971&action=edit Bug 41608: (QA followup) change the JS to build a request with limit params instead of ccl query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #57 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206972&action=edit Bug 41608: (QA followup) Change labels for facets form title and button -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #58 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206973&action=edit Bug 41608: (QA followup) checkboxes are only show if SearchEngine is Elasticsearch Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #59 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206974&action=edit Bug 41608: (QA followup) Add the syspref "MultiChoiceFacets" to enable facets checkboxes in the search results Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #60 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206975&action=edit Bug 41608: if MultiChoiceFacets is disabled, do not show 'Apply' button Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #61 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206976&action=edit Bug 41608: (QA followup) do not check removed facets upon page load Sponsored-by: Kohala Association -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #62 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206977&action=edit Bug 41608: (QA followup) make the multifacet feature available for Zebra as well -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #63 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206978&action=edit Bug 41608: (QA followup) properly store multichoices limits in the cgi query -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #64 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206979&action=edit Bug 41608: (QA followup) add the facets submit button at the top of the form -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #65 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206980&action=edit Bug 41608: (QA followup) fix the JS to properly escape doublequote in authorized value -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #66 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 206981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=206981&action=edit Bug 41608: (QA followup) change MultiChoiceFacet syspref description (not limited to ES) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #67 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207353&action=edit Bug 41608: (QA followup) Fix OPAC results JS error and lost facet limits Two issues introduced by the previous patches: 1. opac-results.tt declared "const query_cgi" while opac-bottom.inc already declares "var query_cgi". The redeclaration raises a SyntaxError that kills the whole inline script (opacbookbag, OverDriveEnabled, etc. end up undefined). The constant is not used, remove it. 2. When a checked facet limit filters the result set so that another checked facet no longer appears on the page (e.g. au:Austen, Jane together with holdingbranch:CPL), the facets JS rebuilt the limit list from the facets displayed on the current page only, silently dropping the limit of the hidden facet on the next "Refine search". Keep the existing limits whose facet is not displayed on the current page so that they are not lost when the search is refined again. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #68 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 207354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=207354&action=edit Bug 41608: (QA followup) provide Cypress tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #69 from Mathieu Saby <mathsabypro@gmail.com> --- We (the sponsor) still have some doubts about how Koha should handle and present the combination of OR and AND selections to users. We'll test it again in a few days and leave a comment here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Frédéric Demians <f.demians@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |f.demians@tamil.fr --- Comment #70 from Frédéric Demians <f.demians@tamil.fr> --- First : very nice improvement! Second: 14 patches is a lot. Arthur, when you rework the patches for the QA issues, could you also squash them into a few logical patches? The 14 patches tell the story of the development, not the final result. It's complicated to follow... Everything works as described. With the AND/OR logic, between links and check boxes, mimicking Primo. Some remarks: 1. Apply removes the double quotes from the search terms. "de la" => de la It wasn't the case, and so it changes the result. 2. The display changes even with MultiChoiceFacets disabled: . "Refine your search" => "Filters" . The currentlibrary class (facet of the logged in library) is no longer used in facets.inc. 3. In facets.inc: [% SET title="Remove facet " _ facet.facet_label_value | html %] "Remove facet" is not picked up by the translation tools, and the value is escaped twice (in the SET and in the title attribute). 4. In opac-facets.inc: . The | url filter was removed when building local_url, so facet values with &, # or + give broken links. . The Apply <li> elements are inside the <form>, not inside a <ul>. 5. QA script: FAIL installer/data/mysql/atomicupdate/bug41608_multichoicefacets.pl file_permissions: File must have the exec flag forbidden_patterns: Use INSERT IGNORE INTO on inserting a new syspref (see bug 9071) WARN installer/data/mysql/mandatory/sysprefs.sql sysprefs_order: MultiChoiceFacets is not in alphabetical order About choosing between AND and OR. Nothing tells which operator is used, and two similar actions give opposite results. That is what could make it confusing. Even if the OR between same facet type is a good choice. A AND wouldn't make sense (imho). I would suggest, when MultiChoiceFacets is enabled, to show the active filters in words above the results, each with its own remove link, for example: Active filters: Authors: Austen, Jane OR Beckett, Samuel [x] AND Holding libraries: Centerville [x] [Clear all] The logic is then visible. And there is a bonus: the [x] links are no longer needed in the facet list, where the checked boxes already show the state. ~ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #71 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Frédéric Demians from comment #70)
First : very nice improvement!
Second: 14 patches is a lot. Arthur, when you rework the patches for the QA issues, could you also squash them into a few logical patches? The 14 patches tell the story of the development, not the final result. It's complicated to follow...
Hello Frederic, Merci pour ta revue et tes encouragements! I will try to fix all the point you mentionned and squash the patches into several logical commits asap :) Best, Arthur -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tadeusz@sosnierz.com --- Comment #72 from HKS3 Tadeusz Sośnierz <tadeusz@sosnierz.com> --- Tested locally with Zebra; I really like how it works! But some things stood out: 1. It requires MultiChoiceFacets set, which is not mentioned in the test plan 2. The button says "Apply", while test plan (still?) mentions "Refine search" 3. A confusing thing happened when I clicked around: a) search for "complete" b) select "Centerville" and "Books", apply, get 3 results c) click on "Books", get zero results I assume that logic breaks up because I'm mixing up the or-flow (selecting) and and-flow (clicking). My expectation would be to switch to the and-flow, and the result be the same as if I clicked on "Books" in the first place, never selecting Centerville. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to select multiple |Ability to select multiple |values of a facet in the |values of a facet in the |professional interface |staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #73 from Mathieu Saby <mathsabypro@gmail.com> --- I can confirm the issue raised by Tadeusz. For the example he gave the error message is : No results match your search for 'kw,wrdl: "the*"' with limit(s): 'holdingbranch:""CPL"" mc-mc-itype:BK itype:BK' . But we have the same behavior with other facets: No results match your search for 'kw,wrdl: "the*"' with limit(s): 'holdingbranch:""CPL"" mc-mc-itype:BK holdingbranch:MPL' . No results match your search for 'kw,wrdl: "the*"' with limit(s): 'holdingbranch:""CPL"" mc-mc-itype:BK ccode:FIC' . No results match your search for 'kw,wrdl: "the*"' with limit(s): 'holdingbranch:""CPL"" mc-mc-itype:BK au:Aristotle' . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #74 from Mathieu Saby <mathsabypro@gmail.com> --- This issue affects only Zebra search. I agree with Frédéric's suggestion to display the list of activated facets above the list of facets, with the option to deselect them there, but wouldn't it also be a good idea to do this for the "classic" facets (if MultiChoiceFacets is not activated) ? What would the community think? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #206970|0 |1 is obsolete| | Attachment #206971|0 |1 is obsolete| | Attachment #206972|0 |1 is obsolete| | Attachment #206973|0 |1 is obsolete| | Attachment #206974|0 |1 is obsolete| | Attachment #206975|0 |1 is obsolete| | Attachment #206976|0 |1 is obsolete| | Attachment #206977|0 |1 is obsolete| | Attachment #206978|0 |1 is obsolete| | Attachment #206979|0 |1 is obsolete| | Attachment #206980|0 |1 is obsolete| | Attachment #206981|0 |1 is obsolete| | Attachment #207353|0 |1 is obsolete| | Attachment #207354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #75 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208862&action=edit Bug 41608: Add Cypress tests for multi-choice facets -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #76 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208863&action=edit Bug 41608: Add MultiChoiceFacets system preference Add the MultiChoiceFacets system preference, disabled by default, to enable multi-choice selection for facets on the search results pages, with the corresponding entry on the Search system preferences page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #77 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208864&action=edit Bug 41608: Multi-choice facets and active filters summary in search results When the MultiChoiceFacets system preference is enabled, the facets on the staff and OPAC search results pages are displayed with checkboxes and an "Apply" button: several values of a same facet can be selected and are combined with OR, while different facet types are combined with AND (mimicking Primo). The active filters are summarized in words above the results, making the AND/OR logic visible, each filter with its own remove link, plus a "Clear all" link. When the preference is disabled, the facets display is unchanged. Test plan: - enable MultiChoiceFacets - on the staff interface, search for "complete" (around 10 results) - checkboxes are displayed in front of the facets - check "Austen, Jane" and "Beckett, Samuel", then click "Apply" - the search is refined with "complete" from both authors (2 results) - the active filters are summarized above the results: "Active filters: Authors: Austen, Jane OR Beckett, Samuel [x]" - check "Centerville" and apply: the summary shows the holding library combined with AND: "AND Holding libraries: Centerville [x]" - uncheck "Centerville" and apply: it is removed from the query - each [x] link removes a single filter, "Clear all" removes them all - the quotes of the search terms are preserved when applying facets - disable MultiChoiceFacets: the facets display is back to the previous behaviour - repeat on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #78 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208865&action=edit Bug 41608: (QA follow-up) Fix multi-choice limits round trip and facet links QA reported that mixing the multi-choice flow (checkboxes + "Apply") and the single-limit flow (clicking a facet link) broke the search: after selecting "Centerville" and "Books" and applying, clicking the "Books" facet link returned no result, with limits like 'holdingbranch:""CPL"" mc-mc-itype:BK itype:BK'. The multi-choice limits are now regenerated in the CGI query in a normalized form (the "mc-" prefix is kept exactly once, the quotes of the values are normalized), so they survive the round trip whatever quoting they carry. The facet links now switch to the single-limit (AND) flow when MultiChoiceFacets is enabled: they are built without the multi-choice (OR) limits, so clicking a facet label applies it on its own, as if it was clicked in the first place. The selected facets are also marked as active (checked checkboxes, not hidden by the "Show more" toggle) even when they are carried by multi-choice limits. Test plan: - enable MultiChoiceFacets - search for "complete", check "Centerville" and "Books", click "Apply" (3 results) - click the "Books" facet label: the multi-choice limits are dropped and the result is the same as clicking "Books" in the first place (9 results) - run t/cypress/integration/Search/MultiChoiceFacets_spec.ts with Cypress - repeat on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #79 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Ok, I've reworked my patch set to only 4 patches. Test plan is available as well as cypress tests and QA scripts are happy. Happy testing! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #80 from Mathieu Saby <mathsabypro@gmail.com> --- Thank you for the rebase and the "Active filters" line But with Zebra at least the "Active filters" line can display wrong information if you click on one value, show the results, then click on a second value. Koha is using AND operator, the URL looks like limit=holdingbranch%3ACPL&&limit=holdingbranch:FPL But the Active filters refers to the "OR" operator : "Holding libraries: Centerville [x] OR Fairview [x]" I haven't done any further testing on the other points. We'll need to discuss this again with our French colleagues. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #81 from Mathieu Saby <mathsabypro@gmail.com> --- The combination of "and" and "or" facets is still incoherent. I tested with Zebra on a sandbox. It is likely possible to get the same error with fewer steps: 1. search "the*" 2. click on Centerville in Library facet => Koha filters the result, with limit=holdingbranch%3ACPL 3. select the boxes "Fiction" and "Non-fiction" in Collection facet, and Apply => Koha seems to filter the results as expected, but I note the library limit has become mc-holdingbranch. Why? 4. remove the filters on Fiction and Non-Fiction, using the [x] in the Active filter line => Koha refresh the results, it seems ok, it only keeps the limit on Centerville (still with mc-holdingbranch) 5. finally click on Fiction => KO. Instead of adding a new limit, Koha **removes** the Centerville limit, and only add 1 limit on collection=Fiction, with ccode:FIC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #82 from Mathieu Saby <mathsabypro@gmail.com> --- Other bug, with Elasticsearch I get : https://staff-buges41608.koha-sandboxes.org/cgi-bin/koha/catalogue/search.pl?q=the*&limit=mc-itype%3ABK&limit=mc-itype%3ACR&limit=mc-ccode%3AFIC&limit=mc-ccode%3ANFIC Active filters: Item types: Books [x] OR CR [x] AND Collections: Fiction [x] OR Non-fiction [x] 16 result(s) found for 'the*' with limit(s): 'ccode:(("FIC") OR ("NFIC")) AND itype:(("BK") OR ("CR"))' . Then I unselect "Books" with the active filters [x] => No results found No results match your search for '"the*"' with limit(s): 'ccode:(("FIC") OR ("NFIC")) AND itype:(("CR"))' . -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #83 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- Created attachment 208921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=208921&action=edit Bug 41608: (QA follow-up) Display single limits combined with AND and make the AND/OR facet flows compatible The active filters summary above the search results grouped all the limits of a same facet in a single group, displayed with the OR operator, whatever the operator actually used by the query. When MultiChoiceFacets is enabled, clicking a facet label applies a single limit, combined with AND: clicking "Centerville" then "Fairview" in the "Holding libraries" facet produces limit=holdingbranch:CPL and limit=holdingbranch:FPL, an AND query, but the summary displayed "Holding libraries: Centerville [x] OR Fairview [x]". The summary now mirrors the logic of the query itself: the multi-choice (mc-) limits of a same facet are combined with OR in a single group, while the single limits and the different facets are combined with AND, each single limit in its own group. Mixing the two facet flows also broke the search limits in both directions: - applying multi-choice (OR) facets turned the single limits (AND) of the displayed facets into multi-choice limits: clicking "Centerville" then "Fairview" (limit=holdingbranch:CPL&limit=holdingbranch:FPL, an AND query), then checking two authors and clicking "Apply" produced (au:Becket or au:Dahl) and (holdingbranch:CPL or holdingbranch:FPL) instead of (au:Becket or au:Dahl) and holdingbranch:CPL and holdingbranch:FPL - clicking a facet label dropped every multi-choice (OR) limit: the facet links were built without the mc- limits, so the selected OR's were removed as soon as a label was clicked The "Apply" form submission now keeps the existing limits of the displayed facets whose checkbox is still checked, with their original operator: a single (AND) limit is not turned into a multi-choice (OR) limit, and unchecking a facet still removes its limit. The facet links are now built with the complete list of limits: clicking a facet label applies a single limit (AND) without dropping the multi-choice (OR) limits. The limit_cgi_no_mc template variable is no longer needed and is removed. Test plan: - enable MultiChoiceFacets - search for "complete", click the "Centerville" facet label, then the "Fairview" one: the URL carries limit=holdingbranch:CPL and limit=holdingbranch:FPL (AND), and the active filters summary displays "Holding libraries: Centerville [x] AND Holding libraries: Fairview [x]" - check two values of a same facet (e.g. two authors) and click "Apply": the authors are combined with OR and the holding libraries stay combined with AND: (au:Becket or au:Dahl) and holdingbranch:CPL and holdingbranch:FPL, and the summary displays the authors combined with OR and each holding library in its own group, combined with AND - conversely, check two authors and click "Apply", then click the "Centerville" and "Fairview" facet labels: the multi-choice limits are kept and each holding library is added as a single (AND) limit - unchecking a facet and clicking "Apply" removes its limit only - each active filter can be removed with its own [x] link, the "Clear all" link removes all the filters at once - the multi-choice limits survive a round trip through the regenerated query links, whatever quoting they carry - run t/cypress/integration/Search/MultiChoiceFacets_spec.ts with Cypress - repeat on the OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #84 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #81)
The combination of "and" and "or" facets is still incoherent.
I tested with Zebra on a sandbox. It is likely possible to get the same error with fewer steps:
1. search "the*" 2. click on Centerville in Library facet => Koha filters the result, with limit=holdingbranch%3ACPL 3. select the boxes "Fiction" and "Non-fiction" in Collection facet, and Apply => Koha seems to filter the results as expected, but I note the library limit has become mc-holdingbranch. Why? 4. remove the filters on Fiction and Non-Fiction, using the [x] in the Active filter line => Koha refresh the results, it seems ok, it only keeps the limit on Centerville (still with mc-holdingbranch) 5. finally click on Fiction => KO. Instead of adding a new limit, Koha **removes** the Centerville limit, and only add 1 limit on collection=Fiction, with ccode:FIC
that has been fixed in the last patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #85 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- (In reply to Mathieu Saby from comment #82)
Other bug, with Elasticsearch
I get :
https://staff-buges41608.koha-sandboxes.org/cgi-bin/koha/catalogue/search. pl?q=the*&limit=mc-itype%3ABK&limit=mc-itype%3ACR&limit=mc- ccode%3AFIC&limit=mc-ccode%3ANFIC
Active filters: Item types: Books [x] OR CR [x] AND Collections: Fiction [x] OR Non-fiction [x] 16 result(s) found for 'the*' with limit(s): 'ccode:(("FIC") OR ("NFIC")) AND itype:(("BK") OR ("CR"))' .
Then I unselect "Books" with the active filters [x]
=> No results found No results match your search for '"the*"' with limit(s): 'ccode:(("FIC") OR ("NFIC")) AND itype:(("CR"))' .
Not a bug : From all the results in a search with keyword "the*" filtered with (Books OR CR) AND (Fiction OR Non-fiction), none of them have any items with the itemtype "CR". You could see that by looking at the missing facet "CR" in the facets list. So, if you remove the "Books", that leaves with only keyword "the*" and filter "itemtype:CR AND (ccode:Fiction OR ccode:Non-fiction), which indeed has no results. If you check on plain koha without the patch ("cgi-bin/koha/opac-search.pl?idx=kw&q=the*&sort_by=relevance&count=20&limit=itype:CR") you'll see none of the results are either Fiction or Non-fiction. They are all "Reference". Hence the "0 results" you get. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 --- Comment #86 from Mathieu Saby <mathsabypro@gmail.com> --- Thank you for the fix Unfortunately, I've found another inconsistent behavior :/ There really are a lot of complicated scenarios, and for a use case (combining "and" and "or" facets) whose relevance needs to be confirmed. Before moving forward, I'll check in with my French colleagues sometime in November. The issue : - Click on 1 library, then on a 2d library, Koha - as we want - uses "AND" (https://staff-bugzebra41608.koha-sandboxes.org/cgi-bin/koha/catalogue/search.pl?idx=kw&q=the%2A&limit=holdingbranch%3ACPL&sort_by=relevance&count=20&limit=holdingbranch:FPL ) - select a 3rd library and click Apply, it will uses "AND" for this new library, instead of OR. Active filters: Holding libraries: Centerville [x] AND Holding libraries: Fairview [x] AND Holding libraries: Midway [x] 37 result(s) found for 'kw,wrdl: the*' with limit(s): 'holdingbranch:CPL holdingbranch:FPL holdingbranch:"MPL"' . Yet I see a "mc-" in the URL : https://staff-bugzebra41608.koha-sandboxes.org/cgi-bin/koha/catalogue/search.pl?idx=kw&q=the*&sort_by=relevance&count=20&limit=holdingbranch%3ACPL&limit=holdingbranch%3AFPL&limit=mc-holdingbranch%3AMPL -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41608 Mathieu Saby <mathsabypro@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org