https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions development - |Add ability to retain 9xx |Ordering existing items |fields when adding on order | |item to existing record --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- We would like an Acquisitions development that would streamline the workflow of ordering items that already exist in the system (reorders). The ideal workflow would be something along the lines of: 1. Staged files are added to a basket and a duplicate warning is received. You click "Display them" (This step already exists) 2. From this screen, when you click "add order" on an item, you are able to add that order record to an existing bib record using the information in the 9xx fields. Currently this step discards any 9xx information and creates a blank order record. 3. Click "Save" and move on to the next duplicate. Since the ability to add an order to an existing record is already present, we're just looking to add the 9xx information as well. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #4 from DEVINIM <kohadevinim@devinim.com.tr> --- Created attachment 79867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79867&action=edit Bug 20817 - Add ability to retain 9xx fields when adding on order item to existing record To test: 1) Choose an existing record from "Add order to basket" area either searching a record or clicking "From a staged file" section 2) After you reach "New order" page for existing record you will see new fieldset called "Existing items" which are existing items belong to a record not previously ordered 3) When you choose item(s) from this new tab fields of "Accounting details" tab will be automatically filled 4) When you finished click save button. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 DEVINIM <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79867|0 |1 is obsolete| | --- Comment #5 from DEVINIM <kohadevinim@devinim.com.tr> --- Created attachment 80537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80537&action=edit Bug 20817 - Add ability to retain 9xx fields when adding on order item to existing record Test plan: 1 - Edit the MarcItemFieldsToOrder and MarcFieldsToOrder syspref. For example: MarcItemFieldsToOrder homebranch: 975$a holdingbranch: 975$b itype: 975$c nonpublic_note: 975$d public_note: 975$e loc: 975$f ccode: 975$g price: 975$h replacementprice: 975$i itemcallnumber: 975$j notforloan: 975$m uri: 975$n copyno: 975$o MarcFieldsToOrder price: 975$h 2 - Stage your order file from vendor. (Test file : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57715 ) 3 - Add to basket from staged file 4 - You are notified of duplicates 5 - View duplicates and choose the existing record to order from 6 - The values in the staged file should be used to create the new item(s) (we should not have to set quantity,price, etc) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea@gmail.com --- Comment #6 from Liz Rea <wizzyrea@gmail.com> --- Hi Devinim, Thanks for looking at this feature, it will be really cool. This works well populating item values from a staged record. I don't particularly like the UX of adding the two items (the "add item" button is hard to spot in the long list of fields), but that isn't related to this patch. There are some QA fails here: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL filters missing_filter at line 328 ( <input type="hidden" name="tag" value="[% iteminfo.tag %]" />) missing_filter at line 309 ( <label class="required">[% iteminfo.subfield %] - [% iteminfo.marc_lib %]</label>) missing_filter at line 777 ( [% jsinclude # Parse the page template's JavaScript block if necessary %]) missing_filter at line 329 ( <input type="hidden" name="subfield" value="[% iteminfo.subfield %]" />) missing_filter at line 330 ( <input type="hidden" name="mandatory" value="[% iteminfo.mandatory %]" />) missing_filter at line 311 ( <label>[% iteminfo.subfield %] - [% iteminfo.marc_lib %]</label>) missing_filter at line 307 ( <div class="subfield_line" id="subfield[% iteminfo.serialid %][% iteminfo.countitems %][% iteminfo.subfield %][% iteminfo.random %]">) missing_filter at line 319 ( <option value="[% value %]">[% iteminfo.marc_value.labels.$value %]</option>) missing_filter at line 326 ( <input type="hidden" name="itemid" value="[% itemID %]" />) missing_filter at line 324 ( [% iteminfo.marc_value %]) missing_filter at line 327 ( <input type="hidden" name="kohafield" value="[% iteminfo.kohafield %]" />) missing_filter at line 337 ( <input class="addItemControl" name="buttonPlus" style="cursor:pointer; margin:0 1em;" onclick="addItem(this,'[% UniqueItemFields %]')" value="Add item" type="button">) missing_filter at line 299 ( <div id="itemblock[% itemID %]" >) missing_filter at line 317 ( <option value="[% value %]" selected="selected">[% iteminfo.marc_value.labels.$value %]</option>) missing_filter at line 342 ( <input class="addItemControl" name="buttonAddMulti"" style="cursor:pointer; margin:0 1em;" onclick="checkCount( this ,'[% UniqueItemFields %]')" value="Add" type="button">) missing_filter at line 303 ( <li style="[% iteminfo.hidden %];">) * Commit title does not start with 'Bug XXXXX: ' - 034220c0cc Fix those up and I'll sign off on this for you. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Devinim <kohadevinim@devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80537|0 |1 is obsolete| | --- Comment #7 from Devinim <kohadevinim@devinim.com.tr> --- Created attachment 86711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86711&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea <wizzyrea@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86711|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea@gmail.com> --- Created attachment 86746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86746&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #10 from Devinim <kohadevinim@devinim.com.tr> --- Hi Katrin, We discussed copy & paste issue before sending this patch. Since there is not any other usage of get_infos_syspref_on_item other than the addorderiso2709.pl we decided to leave as is and copy & paste in the new development. We were not reach any rule for coding guidelines for that situation. Do we need to write a new module if a sub will be used in different code? What should be the exact amount of usage to move subs in a module? 2,3,4 Thanks. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Devinim from comment #10)

We were not reach any rule for coding guidelines for that situation. Do we need to write a new module if a sub will be used in different code? What should be the exact amount of usage to move subs in a module? 2,3,4

Hi, you are not supposed to c/p code. If you want to reuse bad code (in .pl and not tested), you will need to move it to a pm, try to provide tests, then reuse it. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #15 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105215&action=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #17 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105217&action=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #19 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 105219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105219&action=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Martha Fuerst <mfuerst@hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst@hmcpl.org --- Comment #21 from Martha Fuerst <mfuerst@hmcpl.org> --- Making noise here - this is something that we very much need fixed, as it is how our vendor gets BISAC information from our orders for the branches in our system using BISAC. Thank you! Marti Fuerst Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #22 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 115343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=115343&action=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #23 from Martha Fuerst <mfuerst@hmcpl.org> --- Thanks, Kyle! We are really looking forward to getting this fixed. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #26 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118372&action=edit Bug 20817: Move subroutines to a new Perl module -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #28 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118374&action=edit Bug 20817: Rename get_infos_syspref_on_item to GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #30 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118376&action=edit Bug 20817: Remove syspref from parameters, it is invariant -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #32 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 118378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=118378&action=edit Bug 20817: Update module to use YAML::XS -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #34 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL acqui/neworderempty.pl FAIL valid Useless use of a variable in void context -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #36 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL forbidden patterns forbidden pattern: Don't use select tag's size attribute where it is 1 (bug 28066) (line 345) -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen@gmail.com |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #39 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Hmm. I am sorry to note but it crashes already at the first stage of testing this. When we still have this kind of typo in the code now, I would recommend adding an updated test plan and setting back to Needs Signoff. It does not help me trust these changes. Undefined subroutine &C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues called at /usr/share/koha/acqui/addorderiso2709.pl line 540 my $alliteminfos = C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues( $marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] ); => Koha::Acquisition::Utils etc -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #41 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- my %itemrecord=( 'homebranch' => _trim( $iteminfos->{homebranch} ), 'holdingbranch' => _trim( $iteminfos->{holdingbranch} ), If you look at _trim, you see that it may return undef or empty list in list context. And that would produce odd elements in hash kind of things as in the above lines. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #42 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 122834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122834&action=edit Bug 20817: _trim should always return a value -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #44 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #39)

Hmm. I am sorry to note but it crashes already at the first stage of testing this. When we still have this kind of typo in the code now, I would recommend adding an updated test plan and setting back to Needs Signoff. It does not help me trust these changes.

Undefined subroutine &C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues called at /usr/share/koha/acqui/addorderiso2709.pl line 540 my $alliteminfos = C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues( $marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] );

=> Koha::Acquisition::Utils etc

This one is more serious -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #46 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Having another look here -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #48 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 122858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122858&action=edit Bug 20817: (QA follow-up) Add missing module Output This resolves a perl -cw warning: Useless use of a variable in void context at acqui/neworderempty.pl line 700. Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #50 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- acqui/neworderempty.pl: my ($marcrecord, $encoding) = MARCfindbreeding($params->{'breedingid'}); acqui/neworderempty.pl:=head2 MARCfindbreeding acqui/neworderempty.pl: $record = MARCfindbreeding($breedingid); acqui/neworderempty.pl:sub MARCfindbreeding { acqui/neworderempty.pl: my ($marcrecord, $encoding) = MARCfindbreeding($breedingid); authorities/authorities.pl:sub MARCfindbreeding_auth { authorities/authorities.pl: ( $record, $encoding ) = MARCfindbreeding_auth( $breedingid ); cataloguing/addbiblio.pl:=head2 MARCfindbreeding cataloguing/addbiblio.pl: $record = MARCfindbreeding($breedingid); cataloguing/addbiblio.pl:sub MARCfindbreeding { cataloguing/addbiblio.pl: ( $record, $encoding ) = MARCfindbreeding( $breedingid ) ; => Can we consolidate this in a module ? Do we need a (small) extra test for the new itemrecord parameter in PrepareItemrecordDisplay ? Another crash: my $alliteminfos = C4::Acquisition::Utils::GetMarcItemFieldsToOrderValues( $marcrecord, [ 'homebranch', 'holdingbranch', 'itype', 'nonpublic_note', 'public_note', 'loc', 'ccode', 'notforloan', 'uri', 'copyno', 'price', 'replacementprice', 'itemcallnumber', 'quantity', 'budget_code' ] ); Test plan The whole workflow is not completely clear to me here. We should have a solid test plan that tells me how I can verify it this development really works as we hope it does. With the changes and time passed, a new signoff from someone with Acquisition experience would be welcome. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #52 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #51)

"Util" sounds wrong, it's a too generic term IMO.

Choose a replacement word and I'll make it happen! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #54 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Hi, get_infos_syspref() should be using C4::Context->yaml_preference instead of manually dealing with YAML. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #118371|0 |1 is obsolete| | Attachment #118372|0 |1 is obsolete| | Attachment #118373|0 |1 is obsolete| | Attachment #118374|0 |1 is obsolete| | Attachment #118375|0 |1 is obsolete| | Attachment #118376|0 |1 is obsolete| | Attachment #118377|0 |1 is obsolete| | Attachment #118378|0 |1 is obsolete| | Attachment #122692|0 |1 is obsolete| | Attachment #122834|0 |1 is obsolete| | Attachment #122841|0 |1 is obsolete| | Attachment #122858|0 |1 is obsolete| | Attachment #122861|0 |1 is obsolete| | --- Comment #55 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128766&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #57 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128768&action=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #59 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128770&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #61 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128772&action=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #63 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128774&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #65 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128776&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #69 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 128783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128783&action=edit Bug 20817: Import C4::Items::PrepareItemrecordDisplay for neworderempty.pl -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128766|0 |1 is obsolete| | --- Comment #70 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128785&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128768|0 |1 is obsolete| | --- Comment #72 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128787&action=edit Bug 20817: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128770|0 |1 is obsolete| | --- Comment #74 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128789&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128772|0 |1 is obsolete| | --- Comment #76 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128791&action=edit Bug 20817: Fix QA script issues Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128774|0 |1 is obsolete| | --- Comment #78 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128793&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128776|0 |1 is obsolete| | --- Comment #80 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128795&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128782|0 |1 is obsolete| | --- Comment #82 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- Created attachment 128797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128797&action=edit Bug 20817: Fix incorrect namespace for subroutine call Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #86 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131733&action=edit Bug 20817: (QA follow-up) Fix POD for GetMarcFieldsToOrderValues and GetMarcItemFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #128785|0 |1 is obsolete| | Attachment #128786|0 |1 is obsolete| | Attachment #128787|0 |1 is obsolete| | Attachment #128788|0 |1 is obsolete| | Attachment #128789|0 |1 is obsolete| | Attachment #128790|0 |1 is obsolete| | Attachment #128791|0 |1 is obsolete| | Attachment #128792|0 |1 is obsolete| | Attachment #128793|0 |1 is obsolete| | Attachment #128794|0 |1 is obsolete| | Attachment #128795|0 |1 is obsolete| | Attachment #128796|0 |1 is obsolete| | Attachment #128797|0 |1 is obsolete| | Attachment #128798|0 |1 is obsolete| | Attachment #131732|0 |1 is obsolete| | Attachment #131733|0 |1 is obsolete| | --- Comment #87 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131734&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record 1) Choose an existing record from "Add order to basket" area either searching a record or clicking "From a staged file" section 2) After you reach "New order" page for existing record you will see new fieldset called "Existing items" which are existing items belong to a record not previously ordered 3) When you choose item(s) from this new tab fields of "Accounting details" tab will be automatically filled 4) When you finished click save button. Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #89 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131736&action=edit Bug 20817: Add unit tests Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #91 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131738&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #93 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131740&action=edit Bug 20817: Fix QA script issues Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #95 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131742&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #97 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131744&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #99 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131746&action=edit Bug 20817: Fix incorrect namespace for subroutine call Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #101 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 131748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=131748&action=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #103 from Kyle M Hall <kyle@bywatersolutions.com> --- (In reply to Katrin Fischer from comment #84)

1) Can you please explain this change in Items.pm?

This would also affect the item form in serials IIRC.

Agreed. I've submitted a followup to return the existing behavior for serials.

2) GetMarcFieldsToOrderValues in Koha/Acquisition/Utils.pm 3) GetMarcItemFieldsToOrderValues in Koha/Acquisition/Utils.pm

It looks like the original author (Devinim) started with one subroutine that handled both, but ended up forking the subroutine without updated the POD. I've submitted a followup to fix the POD for both subroutines.

4) Test plan

Done as well! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #131734|0 |1 is obsolete| | Attachment #131735|0 |1 is obsolete| | Attachment #131736|0 |1 is obsolete| | Attachment #131737|0 |1 is obsolete| | Attachment #131738|0 |1 is obsolete| | Attachment #131739|0 |1 is obsolete| | Attachment #131740|0 |1 is obsolete| | Attachment #131741|0 |1 is obsolete| | Attachment #131742|0 |1 is obsolete| | Attachment #131743|0 |1 is obsolete| | Attachment #131744|0 |1 is obsolete| | Attachment #131745|0 |1 is obsolete| | Attachment #131746|0 |1 is obsolete| | Attachment #131747|0 |1 is obsolete| | Attachment #131748|0 |1 is obsolete| | Attachment #131749|0 |1 is obsolete| | --- Comment #105 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142630&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #107 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142632&action=edit Bug 20817: Add unit tests -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #109 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142634&action=edit Bug 20817: Rename get_infos_syspref to GetMarcFieldsToOrderValues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #111 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142636&action=edit Bug 20817: Fix QA script issues -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #113 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142638&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #115 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142640&action=edit Bug 20817: (QA follow-up) Fix 'undefined subroutine' error -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #117 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142642&action=edit Bug 20817: Fix incorrect namespace for subroutine call -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #119 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142644&action=edit Bug 20817: (QA follow-up) Add new parameter for PrepareItemrecordDisplay -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142630|0 |1 is obsolete| | Attachment #142631|0 |1 is obsolete| | Attachment #142632|0 |1 is obsolete| | Attachment #142633|0 |1 is obsolete| | Attachment #142634|0 |1 is obsolete| | Attachment #142635|0 |1 is obsolete| | Attachment #142636|0 |1 is obsolete| | Attachment #142637|0 |1 is obsolete| | Attachment #142638|0 |1 is obsolete| | Attachment #142639|0 |1 is obsolete| | Attachment #142640|0 |1 is obsolete| | Attachment #142641|0 |1 is obsolete| | Attachment #142642|0 |1 is obsolete| | Attachment #142643|0 |1 is obsolete| | Attachment #142644|0 |1 is obsolete| | Attachment #142645|0 |1 is obsolete| | --- Comment #121 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142646&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #123 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142648&action=edit Bug 20817: (QA follow-up) Remove size=1 attribute Resolves QA warning, with reference to bug 28066. Line 345 of acqui/neworderempty.tt -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142646|0 |1 is obsolete| | Attachment #142647|0 |1 is obsolete| | Attachment #142648|0 |1 is obsolete| | Attachment #142649|0 |1 is obsolete| | --- Comment #125 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142650&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142650|0 |1 is obsolete| | --- Comment #126 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 142651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142651&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record We would like an Acquisitions development that would streamline the workflow of ordering items that already exist in the system (reorders). The ideal workflow would be something along the lines of: 1. Staged files are added to a basket and a duplicate warning is received. You click "Display them" (This step already exists) 2. From this screen, when you click "add order" on an item, you are able to add that order record to an existing bib record using the information in the 9xx fields. Currently this step discards any 9xx information and creates a blank order record. 3. Click "Save" and move on to the next duplicate. Since the ability to add an order to an existing record is already present, we're just looking to add the 9xx information as well. Additional Authors: Devinim <kohadevinim@devinim.com.tr> Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #127 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I know it's hard to keep on top of bugs with many comments, but 2 issues found here: 1) Method names are not snake case (see comment84, comment#104) 2) I still don't know what to do here in order to test this (see comment#104) The test plan assumes you know a lot of things about the process already. Maybe a test record with 9xx could be supplied? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142651|0 |1 is obsolete| | --- Comment #129 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 142829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142829&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record This patchset intends to add the use of MarcItemFieldsToOrder and MarcFieldsToOrder to neworderempty.pl When adding to a basket fomr a staged file the above preferences create orders on addorderiso2709.pl if the records are unique, or if the records have been matched during staging If the records are not matched at staging, but a duplicate is found you must add the orders individually, and the info is not pulled from the incoming record Setup -- Set systempreferences below MarcFieldsToOrder: price: 949$g quantity: 949$k budget_code: 949$l discount: 949$m sort1: 949$n sort2: 949$q MarcItemFieldsToOrder: homebranch: 949$a holdingbranch: 949$b itype: 949$y nonpublic_note: 949$x public_note: 949$z loc: 949$c ccode: 949$8 notforloan: 949$7 uri: 949$u copyno: 949$t price: 949$g replacementprice: 949$v itemcallnumber: 949$o quantity: 949$k budget_code: 949$l To test: 1 - Stage the sample record for bib303 without looking for matching records (if not using Koha testing docker smaple data import this record, then stage again without matching) 2 - From acqusitions, find a vendor and an open basket and 'Add to basket' 'From a staged file' 3 - On the record in question, check the checbox, then click the 'Add order' link 4 - You are taken to page notifying of duplicate - click 'Use existing record' 5 - You are taken to new order empty, and item forms are prepopulated with order info 6 - Save the orders and confirm all added to basket as expected Additional Authors: Devinim <kohadevinim@devinim.com.tr> Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Liz Rea <wizzyrea@gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #130 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Nick, does this still need a follow-up or back to testing? -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Sarah Cornell <sbcornell@cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell@cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 --- Comment #133 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 187064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=187064&action=edit bib-240149.utf8 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #134 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- I'm closing this bug as bug 41029 accomplishes the same end using the existing record overlay rules feature. *** This bug has been marked as a duplicate of bug 41029 *** -- You are receiving this mail because: You are watching all bug changes.