November 2008 - Koha-bugs - lists.koha-community.org

[Bug 2824] check return values from database modification methods in KohatTest.pm
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2824 ------- Comment #3 from Andrew.moore(a)liblime.com 2008-11-26 11:16 ------- Created an attachment (id=544) --> (http://bugs.koha.org/cgi-bin/bugzilla/attachment.cgi?id=544&action=view) [PATCH] bug 2824: improving error messages from test suite errors This patch adds two warning messages to places in the test suite that may fail. I don't think it changes any functionality, but it sure makes it easier to figure out what has gone wrong. --- t/lib/KohaTest.pm | 8 +++++++- 1 files changed, 7 insertions(+), 1 deletions(-) ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2824] check return values from database modification methods in KohatTest.pm
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2824 Andrew.moore(a)liblime.com changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #543 is|0 |1 obsolete| | ------- Comment #2 from Andrew.moore(a)liblime.com 2008-11-26 11:16 ------- (From update of attachment 543) wrong patch ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2824] check return values from database modification methods in KohatTest.pm
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2824 ------- Comment #1 from Andrew.moore(a)liblime.com 2008-11-26 11:15 ------- Created an attachment (id=543) --> (http://bugs.koha.org/cgi-bin/bugzilla/attachment.cgi?id=543&action=view) [PATCH] updatedatase.pl: improving readability of output messages Two recent changes to updatedatabase.pl don't include newlines at the end of their status messages. This patch adds them. This is only useful if you're running this from the command line. Note: there is an opportunity here to extract some of the simlar logic from each of these blocks to a function. --- installer/data/mysql/updatedatabase.pl | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2824] New: check return values from database modification methods in KohatTest.pm
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2824 Summary: check return values from database modification methods in KohatTest.pm Product: Koha Version: unspecified Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Test Suite AssignedTo: Andrew.moore(a)liblime.com ReportedBy: Andrew.moore(a)liblime.com QAContact: koha-bugs(a)lists.koha.org in t/lib/KohaTest.pm there are a few calls to change database structure in the drop_all_foreign_keys method that aren't checked for failure. We should check them and report a failure if they fail. I have a patch ready for this. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2822] Stylesheet showing wrong icon for nonmusical recordings
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2822 nicole.engard(a)liblime.com changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Status|RESOLVED |REOPENED Resolution|INVALID | ------- Comment #6 from nicole.engard(a)liblime.com 2008-11-26 09:15 ------- Okay - can we mark this as an enhancement instead of INVALID? Because while it is 'technically' not a bug - it's a big deal to the people viewing the OPAC who are being mislead and isn't the priority to make things readable for them? We could easily add one more image for discs and then change the XSL to read: "<xsl:when test="$leader6='c' or $leader6='d' or $leader6='j'">MU</xsl:when>" "<xsl:when test="$leader6='i'">CD</xsl:when>" ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2613] Self-checkout - entering card number returns patron to module login page
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2613 ------- Comment #3 from oleonard(a)myacpl.org 2008-11-26 08:42 ------- It looks as if you can only check out to the user you're logged in as. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2613] Self-checkout - entering card number returns patron to module login page
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2613 ------- Comment #2 from emily.funk(a)liblime.com 2008-11-26 08:24 ------- I tested this again. It's still occurring. Several clients are waiting for this ability. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2823] New: Label Generator not generating barcodes
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2823 Summary: Label Generator not generating barcodes Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Label printing AssignedTo: mason.james(a)liblime.com ReportedBy: shiundu(a)gmail.com QAContact: koha-bugs(a)lists.koha.org It does produce the barcode numbers with the guide boxes, but doesn't generate the actual barcodes anymore. >From the logs stack underflow:tags stack is empty, referer: http://<myserver>/cgi-bin/koha/labels/label-manager.pl?op=add_batch&type=labels Then later label-print-pdf.pl: failed to parse label formatstring: io and barcode at /opt/koha/src/C4/Labels.pm line 862., referer: http://<myserver>/cgi-bin/koha/labels/label-manager.pl?op=add&batch_id=1&itemnumber=1&itemnumber=2&itemnumber=3 ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2822] Stylesheet showing wrong icon for nonmusical recordings
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2822 oleonard(a)myacpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution| |INVALID ------- Comment #5 from oleonard(a)myacpl.org 2008-11-26 07:35 ------- This bug shall suffer the same fate as Bug 2626 ("XSLTResultsDisplay - display icons for printed music are incorrect"). While misleading, the display is technically correct: From http://www.loc.gov/marc/bibliographic/bdleader.html, "If Leader/06 = c, d, i, or j: Music." According to that, the XSL stylesheet is correct to contain "<xsl:when test="$leader6='c' or $leader6='d' or $leader6='i' or $leader6='j'">MU</xsl:when>" The display in the staff client is unrelated to the contents of the leader. The CD image represents the item type. The issue in both cases (this and Bug 2626) is that adhering to the standard makes for misleading information from the patron's point of view. Galen says: [10:27] <gmcharlt> ideally you'd want to pull from the Leader, the 008, possibly 006/007, 245$h, and others [10:27] <gmcharlt> to make physical format distinctions that patrons actually care about [10:27] <gmcharlt> i.e., DVD vs. VHS vs. CD, etc. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2749] GMD (245h) display issues
by bugzilla-daemon＠pippin.metavore.com 26 Nov '08

26 Nov '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2749 oleonard(a)myacpl.org changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|oleonard(a)myacpl.org |jmf(a)liblime.com Component|Templates |OPAC ------- Comment #1 from oleonard(a)myacpl.org 2008-11-26 06:13 ------- It does seem that there are a number of subfields that only display if b is present (Line 402): <xsl:if test="marc:subfield[@code='b']"> <xsl:text> : </xsl:text> <xsl:call-template name="chopPunctuation"> <xsl:with-param name="chopString"> <xsl:call-template name="specialSubfieldSelect"> <xsl:with-param name="axis">b</xsl:with-param> <xsl:with-param name="anyCodes">b</xsl:with-param> <xsl:with-param name="afterCodes">afghk</xsl:with-param> </xsl:call-template> </xsl:with-param> </xsl:call-template> </xsl:if> ...but understanding why or how to arrange for one without the other is beyond my expertise. Josh? ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0