December 2008 - Koha-bugs - lists.koha-community.org

[Bug 2882] Delete library silently fails when patrons exist for that library
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2882 ------- Comment #2 from koha(a)brinkerhoff.org 2008-12-23 12:03 ------- diff --git a/admin/branches.pl b/admin/branches.pl index fecc030..c01aa59 100755 --- a/admin/branches.pl +++ b/admin/branches.pl @@ -123,6 +123,11 @@ elsif ( $op eq 'delete' ) { $sth->execute( $branchcode, $branchcode ); my ($total) = $sth->fetchrow_array; $sth->finish; + + my $sth = $dbh->prepare("select count(*) from borrowers where branchcode=?"); + $sth->execute($branchcode); + my ($total) += $sth->fetchrow_array; + $sth->finish; my $message; ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2882] Delete library silently fails when patrons exist for that library
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2882 ------- Comment #1 from koha(a)brinkerhoff.org 2008-12-23 11:53 ------- delete from borrowers where branchcode != "LIBRARYCODEIWANTTOKEEP"; allowed me to delete the other libraries as expected -- however branches.pl should probably check to see if there are any constraints that will be violated on delete -- or atleast requery to see if the library still exists after delete and give the user an error. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2882] New: Delete library silently fails when patrons exist for that library
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2882 Summary: Delete library silently fails when patrons exist for that library Product: Koha Version: rel_3_0 Platform: PC OS/Version: Linux - Other Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing AssignedTo: galen.charlton(a)liblime.com ReportedBy: koha(a)brinkerhoff.org QAContact: koha-bugs(a)lists.koha.org When I try to delete the 'Franklin' library from the sample data included with Koha 3.00.00 the web interface claims the library entry was deleted: Library deleted However the page refreshes and the library is still present. [Tue Dec 23 14:48:31 2008] [error] [client 216.107.221.XXX] [Tue Dec 23 14:48:31 2008] branches.pl: DBD::mysql::st execute failed: Cannot delete or update a parent row: a foreign key constraint fails (`koha/borrowers`, CONSTRAINT `borrowers_ibfk_2` FOREIGN KEY (`branchcode`) REFERENCES `branches` (`branchcode`)) at /usr/share/koha/lib/C4/Branch.pm line 473., referer: http://XXXXXXXXXX:8080/cgi-bin/koha/admin/branches.pl?branchcode=FRL&branch… ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2881] Default sorting in advanced search
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2881 nahuel.angelinetti(a)biblibre.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P3 |PATCH-Sent ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2881] Default sorting in advanced search
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2881 ------- Comment #1 from nahuel.angelinetti(a)biblibre.com 2008-12-23 06:03 ------- Created an attachment (id=569) --> (http://bugs.koha.org/cgi-bin/bugzilla/attachment.cgi?id=569&action=view) bugfix for 3.0.x and HEAD ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2881] New: Default sorting in advanced search
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2881 Summary: Default sorting in advanced search Product: Koha Version: unspecified Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Searching AssignedTo: nahuel.angelinetti(a)biblibre.com ReportedBy: nahuel.angelinetti(a)biblibre.com QAContact: koha-bugs(a)lists.koha.org When you set the two sysprefs (OPAC)defaultSortField and (OPAC)defaultSortOrder, and do an "advanced search" (in opac and intranet), the "Sort By" is not set to the default order. Koha should preselect the value in combobox. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2880] New: Pages pass 'loggedinuser' parameter to templates even if unset
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2880 Summary: Pages pass 'loggedinuser' parameter to templates even if unset Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing AssignedTo: galen.charlton(a)liblime.com ReportedBy: koha(a)brinkerhoff.org QAContact: koha-bugs(a)lists.koha.org Each time a user loads the 'intranet' (http://host/) my logfile logs an error for: [Mon Dec 22 14:51:01 2008] [error] [client 192.168.1.139] EXPR:at pos 25: non-initialized variable loggedinusername, referer: http://192.168.1.125/cgi-bin/koha/opac-tags.pl [Mon Dec 22 14:51:04 2008] [error] [client 192.168.1.139] EXPR:at pos 25: non-initialized variable loggedinusername, referer: http://192.168.1.125/cgi-bin/koha/opac-tags.pl?limit=100&hidemytags=1 [Mon Dec 22 14:51:04 2008] [error] [client 192.168.1.139] EXPR:at pos 25: non-initialized variable loggedinusername, referer: http://192.168.1.125/cgi-bin/koha/opac-tags.pl?limit=100&hidemytags=1 [Mon Dec 22 14:52:01 2008] [error] [client 192.168.1.139] EXPR:at pos 25: non-initialized variable loggedinusername, referer: http://192.168.1.125/cgi-bin/koha/opac-tags.pl?limit=100&hidemytags=1 [Mon Dec 22 14:52:01 2008] [error] [client 192.168.1.139] EXPR:at pos 25: non-initialized variable loggedinusername, referer: http://192.168.1.125/cgi-bin/koha/opac-tags.pl?limit=100&hidemytags=1 Could simply returning an empty template variable remove most of these errors? (I didn't test thoroughly, but it didn't seem to break anything). stan@koha-dev:~/kohaclone/C4$ git diff diff --git a/C4/Auth.pm b/C4/Auth.pm index 871929e..11b8173 100644 --- a/C4/Auth.pm +++ b/C4/Auth.pm @@ -243,7 +243,8 @@ sub get_template_and_user { $template->param( js_widgets => $in->{'js_widgets'} ); $template->param( sessionID => $sessionID ); - + $template->param( loggedinusername => '' ); + my ($total, $pubshelves) = C4::Context->get_shelves_userenv(); # an anonymous user has no 'barshelves'... if (defined(($pubshelves))) { $template->param( pubshelves => scalar (@$pubshelves), ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2858] Website - update translation list address
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2858 koha(a)brinkerhoff.org changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|update list address |Website - update translation | |list address ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2879] New: cloud-kw.pl: can crash with divide by zero error
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2879 Summary: cloud-kw.pl: can crash with divide by zero error Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: normal Priority: P3 Component: Command-line Utilities AssignedTo: frederic(a)tamil.fr ReportedBy: galen.charlton(a)liblime.com QAContact: koha-bugs(a)lists.koha.org Around line 177 cloud-kw.pl calculates $delta which it uses in a division around line 189: my $delta = $max - $min; However, if $max and $min are the same (which can happen in a small test database or if scanning an index of a unique identifier field), $delta is set to 0, and cloud-kw.pl will crash at the division. ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0

[Bug 2878] New: cloud-kw.pl: should use HTML template
by bugzilla-daemon＠pippin.metavore.com 23 Dec '08

23 Dec '08

http://bugs.koha.org/cgi-bin/bugzilla/show_bug.cgi?id=2878 Summary: cloud-kw.pl: should use HTML template Product: Koha Version: HEAD Platform: PC OS/Version: All Status: NEW Severity: enhancement Priority: P3 Component: Command-line Utilities AssignedTo: frederic(a)tamil.fr ReportedBy: galen.charlton(a)liblime.com QAContact: koha-bugs(a)lists.koha.org The HTML and CSS output of cloud-kw.pl is currently hardcoded, limiting flexibility for users wishing to customize its output. Instead, it should be able to use an HTML::Template::Pro template (like misc/cronjobs/rss/rss.pl, for example). ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact.

1 0