October 2010 - Koha-bugs - lists.koha-community.org

[Bug 4305] Amazon book covers do not work with ISBN13
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '10

20 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 --- Comment #11 from Frédéric Demians <frederic(a)tamil.fr> 2010-10-20 07:04:34 UTC --- > This stops the import process from dieing when it gets an invalid ISBN13. This works for me. It's equivalent to my proposal and it's consistent with this function role: when an invalid ISBN13 is submitted, undef must be returned since an invalid IBSN won't be available at Amazon (to get book cover). You should submit your patch... -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4305] Amazon book covers do not work with ISBN13
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '10

20 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 --- Comment #10 from Robin Sheat <robin(a)catalyst.net.nz> 2010-10-20 06:46:38 UTC --- Created attachment 2695 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2695 Prevents exception on certain dodgy input This stops the import process from dieing when it gets an invalid ISBN13. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4305] Amazon book covers do not work with ISBN13
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '10

20 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 --- Comment #9 from Robin Sheat <robin(a)catalyst.net.nz> 2010-10-20 06:44:53 UTC --- (In reply to comment #8) > You're ISBN is an invalid ISBN13. Yep. It's coming from a not completely clean data source. > Could you try adding after: > > return undef unless $isbn; > > this line: > > return undef unless $isbn->is_valid; That's pretty similar (but slightly different) to the fix I'm testing out right now. I'll attach the patch in a moment. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4305] Amazon book covers do not work with ISBN13
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '10

20 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 --- Comment #8 from Frédéric Demians <frederic(a)tamil.fr> 2010-10-20 06:23:40 UTC --- > This patch causes problems doing bulk imports of data. In particular, I'm > trying to load a record that has the ISBN '0621047376274' (which is invalid) > and this causes the error: > > [Wed Oct 20 19:03:36 2010] [error] [client 192.168.56.1] [Wed Oct 20 19:03:36 > 2010] stage-marc-import.pl: Can't call method "as_string" on an undefined value > at /mnt/catalyst/koha/C4/Koha.pm line 1333, <GEN11> chunk 12321., referer: > http://koha:8080/cgi-bin/koha/tools/stage-marc-import.pl > > which breaks the whole import process. Reverting the patch stops this problem. > > Note that invalid ISBN10 entries don't cause this problem. You're ISBN is an invalid ISBN13. Could you try adding after: return undef unless $isbn; this line: return undef unless $isbn->is_valid; -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4305] Amazon book covers do not work with ISBN13
by bugzilla-daemon＠bugs.koha-community.org 20 Oct '10

20 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4305 Robin Sheat <robin(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin(a)catalyst.net.nz --- Comment #7 from Robin Sheat <robin(a)catalyst.net.nz> 2010-10-20 06:09:47 UTC --- This patch causes problems doing bulk imports of data. In particular, I'm trying to load a record that has the ISBN '0621047376274' (which is invalid) and this causes the error: [Wed Oct 20 19:03:36 2010] [error] [client 192.168.56.1] [Wed Oct 20 19:03:36 2010] stage-marc-import.pl: Can't call method "as_string" on an undefined value at /mnt/catalyst/koha/C4/Koha.pm line 1333, <GEN11> chunk 12321., referer: http://koha:8080/cgi-bin/koha/tools/stage-marc-import.pl which breaks the whole import process. Reverting the patch stops this problem. Note that invalid ISBN10 entries don't cause this problem. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4440] Adding feature to print fines/fees receipts
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '10

18 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4440 Koustubha Kale <kmkale(a)anantcorp.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #2108|0 |1 is obsolete| | --- Comment #4 from Koustubha Kale <kmkale(a)anantcorp.com> 2010-10-18 14:59:31 UTC --- Created attachment 2691 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2691 Revised combined patch to print fee receipts and invoices 18-Oct-2010 Changed template and script names to match. Corrected invalid markup in the templates. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 5120] New: Misspelled word: biblographic
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '10

17 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5120 Summary: Misspelled word: biblographic Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: bgkriegel(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 on koha-tmpl/opac-tmpl/prog/en/modules/opac-sendbasket.tmpl koha-tmpl/opac-tmpl/prog/en/modules/opac-sendshelf.tmpl koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/sendshelf.tmpl koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tmpl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 3

[Bug 3164] OPAC-placed holds broken in SingleBranchMode
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '10

17 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3164 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution| |FIXED -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4472] img tags in xslt broken after automatic translation
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '10

17 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4472 Galen Charlton <gmcharlt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_2 |rel_3_4 Severity|blocker |major --- Comment #14 from Galen Charlton <gmcharlt(a)gmail.com> 2010-10-17 17:33:36 UTC --- Changing bug priority and moving to 3.4, now that remaining nbsp fix is in place. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0

[Bug 4472] img tags in xslt broken after automatic translation
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '10

17 Oct '10

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4472 --- Comment #13 from Galen Charlton <gmcharlt(a)gmail.com> 2010-10-17 17:31:49 UTC --- (In reply to comment #12) > This patch fixes this bug in Intranet detail page, for UNIMARC DB: > > http://lists.koha-community.org/pipermail/koha-patches/2010-October/012687.… Patch pushed to HEAD for inclusion in 3.2. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 0