December 2011 - Koha-bugs - lists.koha-community.org

[Bug 3841] Should have Default ACQ Framework
by bugzilla-daemon＠bugs.koha-community.org 15 Dec '11

15 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3841 --- Comment #2 from Ian Walls <ian.walls(a)bywatersolutions.com> 2011-12-15 03:03:46 UTC --- *** Bug 3843 has been marked as a duplicate of this bug. *** -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #33 from Owen Leonard <oleonard(a)myacpl.org> 2011-12-14 17:16:42 UTC --- Created attachment 6791 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6791 Follow-up fix This patch revises the image viewer page to match other biblio detail pages: a toolbar, a sidebar menu, etc. Additional data is now pulled by imageviewer.pl in order to provide information necessary for the proper functioning of the toolbar and menus: item counts, hold availability, biblio view options. Other changes have been made to match the changes in the OPAC interface like styling of the images and no-javascript compatibility -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #32 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:59:00 UTC --- I have revised the patches as requested, and eliminated the Koha:: namespace. Further comments appreciated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6766|0 |1 is obsolete| | --- Comment #31 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:58:05 UTC --- Created attachment 6788 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6788 Bug 1633: Don't show image tab when inappropriate This patch corrects the bug spotted by Owen Leonard where the Images tab was showing up even for records that didn't have local cover images attached to them. The tab is now hidden on the OPAC for records that don't have any images. In the Intranet, an Images tab will show for staff with permission to upload images, suggesting that they do so. For staff without that permission, the tab is not shown. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6765|0 |1 is obsolete| | --- Comment #30 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:57:45 UTC --- Created attachment 6787 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6787 Bug 1633 - Add ability to take book cover images from local img db OPAC Template revisions: - Revised OPAC imageviewer template to match structure of other OPAC pages (with masthead search, footer, etc) - Added link back to detail page (controlled by BiblioDefaultView preference) - Added link style to thumbnails on opac-detail to add a sense of "clickability" to them - Revised OPAC imageviewer template to allow it to function with JavaScript turned off. Now even without JS main image will load, thumbnails will be properly styled, and thumbnail links will work. - Changes to the script are only to pass missing variables to the template TODO: Corresponding changes for the staff client Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6756|0 |1 is obsolete| | --- Comment #29 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:56:43 UTC --- Created attachment 6786 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6786 Bug 1633: Display local cover images This patch adds display of local cover images in the following places: 1. OPAC Results page 2. OPAC Details page 3. Separate image viewer page for the OPAC 4. Intranet Details page 5. Separate image viewer page for the Intranet Display in the Details and (OPAC) Results pages is handled via Javascript rather than via direct embedding, to better handle the situation where most records have local cover images, but a few do not. Local cover images do not currently display in the Intranet Results page How to use/test : Assign user permission to the user Tools > (upload_local_cover_images Upload local cover images). In order to upload local images, login to the staff client. Go to Home > Tools > Upload Cover Images. Here you can upload cover images either singly or in bulk in the form of a zip file. If uploading singly, click on image file, browse the image from your local disk, type in the biblio number of the catalogue entry and press upload. If uploading in bulk as a zip file, the zip file must contain (in addition to cover images) one text file named either datalink.txt OR idlink.txt. This file should have mapping of biblionumber to image file name in the zip one per line with comma or tab as delimiters. For example: 1, scanned_cover_image_of_bib_no_1.jpg 2, scanned_cover_image_of_bib_no_1.jpg Cover images will be resized to a large image of 800x600 and a thumbnail of 200x140. Depending on the setting of AllowMultipleCovers, it is possible to upload multiple images for a single bibliographic record. However, even if multiple covers are permitted, you have the option of replacing the existing covers by checking the "Replace existing covers" option on the upload screen. 1. The patch adds a menu link in Tools from where you can upload local cover images 2. It adds a user permission to enable access control to this menu item under Tools 3. It adds a system preference OPACLocalCoverImages under Enhanced Content. This needs to be turned on to show local cover images in OPAC. Once you have uploaded local images, if you search for the biblio, the local cover should show up in search as well as search detail pages in the OPAC, and the details view in the Intranet. Koustubha Kale is working on another patch which will allow us to set a cover image source priority in system preferences, and which will then gracefully fail over to the next source if image is not available from the first choice source. Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Jared Camins-Esakov <jcamins(a)cpbibliography.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6755|0 |1 is obsolete| | --- Comment #28 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:56:11 UTC --- Created attachment 6785 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6785 Bug 1633: Add support for uploading images to Koha A frequently-requested feature for Koha, especially by special libraries, is the ability to upload local cover images into Koha. This patch adds a bibliocoverimage table, and image handling code in the C4::Images module. Key features of the implementation include: 1. The ability to have multiple cover images for a biblio 2. Handling for "full size" (800x600) and thumbnail-size (200x140) images 3. Uploading images directly from the record view The image display functionality by Koustubha Kale of Anant Corporation will follow in a second patch. Special thanks to Koustubha Kale and Anant Corporation for the initial implementation of local cover images, and to Chris Nighswonger of Foundation Bible College for his prior work on patron images. Signed-off-by: Jared Camins-Esakov <jcamins(a)cpbibliography.com> -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #27 from Chris Nighswonger <cnighswonger(a)foundations.edu> 2011-12-14 15:20:55 UTC --- Upon further clarification, the change to Makefile.PL is adding a new directory implementing a previously proposed Koha:: namespace. While I'm not against this in principle, I don't recall any formal discussion and/or decision on this move. There should probably be some or at least some reference to it on the wiki. If/when we do add this namespace, it should probably be done as a separate commit with an appropriate amount of verbiage explaining the change and referencing said discussion/decision rather than being buried in a large feature change/addition. My $0.02 worth. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 --- Comment #26 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> 2011-12-14 15:17:22 UTC --- (In reply to comment #25) > From an IRC discussion regarding the RetrieveImage sub: > > <magnuse> chris_n: > http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6755 > * chris_n notes that this patch adds a what appears to be unrelated line to > Makefile.PL Without the added line to Makefile.PL, production-mode Koha installations fail dramatically because of the Koha/Images.pm file not being installed. > <chris_n> yeah, that sub needs to be changed to return a null value if there is > a db error > <chris_n> it already logs it > <chris_n> ie. if ($sth->errstr) { log error; return;} > <chris_n> and then let the caller handle it I can make that change. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 1633] Add ability to take book cover images from local img db
by bugzilla-daemon＠bugs.koha-community.org 14 Dec '11

14 Dec '11

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1633 Chris Nighswonger <cnighswonger(a)foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cnighswonger(a)foundations.ed | |u --- Comment #25 from Chris Nighswonger <cnighswonger(a)foundations.edu> 2011-12-14 14:55:55 UTC --- >From an IRC discussion regarding the RetrieveImage sub: <magnuse> chris_n: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6755 * chris_n notes that this patch adds a what appears to be unrelated line to Makefile.PL <chris_n> yeah, that sub needs to be changed to return a null value if there is a db error <chris_n> it already logs it <chris_n> ie. if ($sth->errstr) { log error; return;} <chris_n> and then let the caller handle it -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0