July 2011 - Koha-bugs - lists.koha-community.org

[Bug 6505] New: purchase order not populating all fields
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '15

27 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6505 Bug #: 6505 Summary: purchase order not populating all fields Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org The purchase order PDF is not pulling info from the libraries. There are labels for Phone number Fax Billing address Email But they're not printing that info. Also, the library name is coming from the system preference for libraryname and not from the libraries admin area - all the info on the purchase order should comes from the data you enter in admin > libraries -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 1

[Bug 6579] New: getalert SQL invalid for KOHA_USER
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '15

27 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6579 Bug #: 6579 Summary: getalert SQL invalid for KOHA_USER Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_0 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Notices AssignedTo: henridamien(a)koha-fr.org ReportedBy: ohiocore(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org The code for getalert in C4::Letters fails to account for one important case. While the POD says "all parameters NON mandatory", the result of NO arguments produces invalid SQL. The errors in the log look like: [error] [client 71.64.0.171] [Mon Jul 11 19:54:12 2011] opac-user.pl: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '' at line 1 at /usr/share/koha/lib/C4/Letters.pm line 197, <DATA> line 522., referer: https://my.koha.edu/cgi-bin/koha/opac-user.pl [error] [client 71.64.0.171] [Mon Jul 11 19:54:12 2011] opac-user.pl: DBD::mysql::st fetchall_arrayref failed: fetch() without execute() at /usr/share/koha/lib/C4/Letters.pm line 198, <DATA> line 522., referer: https://my.koha.edu/cgi-bin/koha/opac-user.pl If you look at the logic, you'll agree that "SELECT * FROM alert WHERE" is not a valid SQL query. Code should assemble bind name/value pairs in a hash instead of appending to the query and pushing onto an array. Then build the WHERE clause at the end only when hash is populated. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 2

[Bug 6614] New: CSV Basket Export gives blank lines
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '15

27 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6614 Bug #: 6614 Summary: CSV Basket Export gives blank lines Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: ian.walls(a)bywatersolutions.com QAContact: koha-bugs(a)lists.koha-community.org If an order note contains "\n", that line will not print in the exported CSV basket, because "\n" is an invalid character to Text::CSV->combine(). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 11

[Bug 5617] New: fix-perl-path.pl misses some files
by bugzilla-daemon＠bugs.koha-community.org 27 Mar '15

27 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5617 Summary: fix-perl-path.pl misses some files Change sponsored?: --- Product: Koha Version: rel_3_2 Platform: All OS/Version: Linux Status: NEW Severity: normal Priority: P5 Component: Installation and upgrade (command-line installer) AssignedTo: gmcharlt(a)gmail.com ReportedBy: jsherman(a)usao.edu QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 When upgrading from 3.0.6 to 3.2.01 (on Ubuntu 8.04), I found that I needed to roll my own perl. Upon running the upgrade, I found that fix-per-path.pl left the system perl shebang line on the following files: /usr/share/koha/intranet/cgi-bin/admin/aqbookfund.pl /usr/share/koha/intranet/cgi-bin/admin/aqbudget.pl /usr/share/koha/intranet/cgi-bin/labels/label-profiles.pl /usr/share/koha/intranet/cgi-bin/labels/label-manager.pl /usr/share/koha/intranet/cgi-bin/labels/pcard-member-search.pl /usr/share/koha/intranet/cgi-bin/labels/label-save-template.pl /usr/share/koha/intranet/cgi-bin/labels/label-templates.pl /usr/share/koha/intranet/cgi-bin/labels/label-create-profile.pl /usr/share/koha/intranet/cgi-bin/labels/label-create-layout.pl /usr/share/koha/intranet/cgi-bin/labels/label-print-pdf.pl /usr/share/koha/intranet/cgi-bin/labels/label-print-csv.pl /usr/share/koha/intranet/cgi-bin/labels/label-create-template.pl /usr/share/koha/intranet/cgi-bin/catalogue/recentacquisitions.pl /usr/share/koha/intranet/cgi-bin/serials/subscription-history.pl /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase30.pl /usr/share/koha/intranet/cgi-bin/suggestion/acceptorreject.pl /usr/share/koha/intranet/cgi-bin/reports/itemtypes.plugin /usr/share/koha/intranet/cgi-bin/reports/issues_by_borrower_category.plugin /usr/share/koha/intranet/cgi-bin/svc/bib /usr/share/koha/intranet/cgi-bin/svc/new_bib /usr/share/koha/intranet/cgi-bin/svc/bib_profile /usr/share/koha/intranet/cgi-bin/svc/config/systempreferences /usr/share/koha/intranet/cgi-bin/svc/authentication /usr/share/koha/intranet/cgi-bin/tools/runreport.pl /usr/share/koha/intranet/cgi-bin/tools/scheduler.pl.bak /usr/share/koha/intranet/cgi-bin/acqui/spent.pl /usr/share/koha/intranet/cgi-bin/acqui/bookfund.pl /usr/share/koha/intranet/cgi-bin/acqui/pdfformat/layout2pages.pm /usr/share/koha/intranet/cgi-bin/acqui/pdfformat/layout3pages.pm /usr/share/koha/misc/translator/translate /usr/share/koha/misc/translator/install.pl /usr/share/koha/misc/translator/install-code.pl /usr/share/koha/bin/cronjobs/runreport.pl.bak -w /usr/share/koha/opac/cgi-bin/opac/unapi /usr/share/koha/opac/cgi-bin/opac/opac-logout.pl /usr/share/koha/opac/cgi-bin/opac/sco/abort.pl /usr/share/koha/opac/cgi-bin/opac/sco/sco-circ.pl /usr/share/koha/opac/cgi-bin/opac/sco/printer.pl /usr/share/koha/opac/cgi-bin/opac/opac-recentacquisitions.pl /usr/share/koha/opac/cgi-bin/opac/opac-detailprint.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 9

[Bug 5599] New: koha_perl_deps.pl and PerlDependencies.pm don't compare $VERSION numbers correctly
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '15

26 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5599 Summary: koha_perl_deps.pl and PerlDependencies.pm don't compare $VERSION numbers correctly Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Installation and upgrade (command-line installer) AssignedTo: gmcharlt(a)gmail.com ReportedBy: ohiocore(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 Normal perl $VERSION numbers are not string sortable/comparable. This is because they do not use leading zeroes or static numbers of digits for each part. But our logic in C4/Installer/PerlModules.pm relies on string comparison, so it does not regard 1.3.12 as being greater than 1.3.5, when in reality it is 7 iterations later. Example: $ ./koha_perl_deps.pl -u Module Name Current Version Required Version Module Required -------------------------------------------------------------------------------------------------------------------------- Graphics::Magick 1.3.12 * 1.3.5 No -------------------------------------------------------------------------------------------------------------------------- Total modules reported: 1 * Module is missing or requires an upgrade. Specifically, these comparisons from lines 75 and 89 of C4/Installer/PerlModules.pm are incorrect: $params{'module'}->VERSION lt $PERL_DEPS->{$params{'module'}}->{'min_ver'} ... $pkg->VERSION lt $PERL_DEPS->{$_}->{'min_ver'} I don't like the approach used by PerlModules.pm because the code is overwrought and it tries to reproduce core perl logic. The definitive test would rely on, for example, $pkg->VERSION($min) since VERSION() is a part of UNIVERSAL and it actually understands perl's lax version strings (and always will, even if they change format). We can access that via UNIVERSAL::require($min). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 4

[Bug 4847] New: Python required for Debian package builds
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '15

25 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4847 Summary: Python required for Debian package builds Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 Component: Packaging AssignedTo: lars(a)catalyst.net.nz ReportedBy: lars(a)catalyst.net.nz QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 The Debian package build includes a script (debian/bd-to-depends) written in Python. This requires having Python as a build depdencency. That's the only reason Python is required, so it is an unnecessary dependency. Re-writing the script in Perl would fix that. Then dropping python and python-debian from the build dependencies would be possible. (Note that this only applies to _build_ dependencies, not run-time dependencies of the installed packages.) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 9

[Bug 6079] New: Single parentheses
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '15

25 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6079 Bug #: 6079 Summary: Single parentheses Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: mark.gavillet(a)ptfs-europe.com QAContact: koha-bugs(a)lists.koha-community.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 3

[Bug 6266] New: Ordering from staged file gives perl error when no budget defined
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '15

25 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6266 Bug #: 6266 Summary: Ordering from staged file gives perl error when no budget defined Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All URL: /cgi-bin/koha/acqui/addorderiso2709.pl?booksellerid=1& basketno=1 OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: katrin.fischer(a)bsz-bw.de QAContact: koha-bugs(a)lists.koha-community.org When you try to order from a staged marc file and no budgets and funds are definded you get an ugly perl error: Software error: Can't use an undefined value as a HASH reference at /home/katrin/kohaclone/acqui/addorderiso2709.pl line 260. For help, please send mail to the webmaster (webmaster@wombat), giving this error message and the time and date of the error. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 2

[Bug 6400] New: Counter broken on tags review page
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '15

25 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6400 Bug #: 6400 Summary: Counter broken on tags review page Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All URL: /cgi-bin/koha/tags/review.pl OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Tools AssignedTo: gmcharlt(a)gmail.com ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org The first column in the tags review table is a counter showing the row number. In the new T:T template it looks like this: [% offset + __counter__ %] "__counter__" looks like the hold HTML_Template_Pro way of doing things. I assumed the proper construction for T:T would be: [% offset + tagloo.count %] ...but this doesn't work. Is the count variable not enabled by default or am I missing something? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 1

[Bug 6587] New: tag moderation lost colors
by bugzilla-daemon＠bugs.koha-community.org 25 Mar '15

25 Mar '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6587 Bug #: 6587 Summary: tag moderation lost colors Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Templates AssignedTo: oleonard(a)myacpl.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Created attachment 4628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=4628 rejected tags showing yellow Tag moderation used to have three colors, yellow for pending, red for rejected, green for approved. They are all yellow now making it impossible to tell on a list of 'all tags' which are approved and which are rejected. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 8