February 2012 - Koha-bugs - lists.koha-community.org

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '12

07 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2012-02-07 09:12:37 UTC --- I missed your last comments - I think 'default' could work, when it's documented in the syspref description. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '12

07 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> 2012-02-07 09:11:01 UTC --- I think the problem is, when people are not using xslt views now but want to turn it on later. It will mean they can't just switch it on but have to put in a complicated string - and if they do it wrong, what will happen? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '12

07 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain(a)biblibre.com --- Comment #15 from Paul Poulain <paul.poulain(a)biblibre.com> 2012-02-07 08:22:09 UTC --- (In reply to comment #13) > I think this will confuse your average user, and the software is for them, not > us. > This patch would need two things to get my signoff: > 1. better documentation in the syspref description > 2. no 1/0 on/off usage. This is so confusing for your average user, and > considering that most libraries will use the default xslt (*not* define a > specific stylesheet), unnecessarily so. We had a discussion about your comments with Stéphane. * I don't see clearly the difference between display without and the default xslt. I'm wondering if you're not implying to make the default XSLT being the default display. In this case, an easy change would be to have those sysprefs being for specific XSLT, if they're empty, then use default XSLT * Stéphane is right about XSLT made for specific display. Many/most of our libraries want some tweaks on XSLT. So we use 2 options only: no XSLT or specific XSLT * there is also a problem with XSLT syspref as we've today : on a server with more than 1 Koha (using koha-tools), it's impossible to have a specific XSLT for each setup A simple answer to your proposition would be to change the behaviour and have 3 options: * empty => no XLST * the string "default" or "1" => default XSLT * a full XSL path => the specific XSL you've defined. it could easily be documented on syspref.pl page Would you be OK with this ? Note that what is great with this patch is also that we can have full URLs (http://xslt.koha-community.org/nekls.xsl for example), so we could share XSLT as we're already sharing SQL queries on the server. Add a meaningfull wiki page, pointing all existing XSLT and their look, and you get a nice feature -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 07 Feb '12

07 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 --- Comment #14 from stephane.delaune(a)biblibre.com 2012-02-07 07:59:32 UTC --- the interest of the xslt is especially to be able to customize the display, and thus to define a different xslt than the default, and thus to define a specific stylesheet. Am I wrong ? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7502] New: Error in zebra configuration file records.abs
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7502 Bug #: 7502 Summary: Error in zebra configuration file records.abs Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Platform: All OS/Version: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing AssignedTo: gmcharlt(a)gmail.com ReportedBy: januszop(a)gmail.com QAContact: koha.sekjal(a)gmail.com There is an error in records.abs in marc21/biblios causing a zebra warning: 15:51:13-06/02 zebraidx(3276) [warn] Unknown register type: Subject This is because of a mistake introduced in a line of the patch to Bug 5868: melm 630$n Thematic-number,Subject:Subject:p which should be rather melm 630$n Thematic-number,Subject,Subject:p (coma instead of a colon after 1st Subject). A patch will follow. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 6

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #13 from Liz Rea <wizzyrea(a)gmail.com> 2012-02-06 16:33:27 UTC --- I think this will confuse your average user, and the software is for them, not us. This patch would need two things to get my signoff: 1. better documentation in the syspref description 2. no 1/0 on/off usage. This is so confusing for your average user, and considering that most libraries will use the default xslt (*not* define a specific stylesheet), unnecessarily so. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3215] It would be nice if "Add to Cart" changed to "Remove from Cart"
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3215 Ian Walls <koha.sekjal(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |koha.sekjal(a)gmail.com --- Comment #5 from Ian Walls <koha.sekjal(a)gmail.com> 2012-02-06 16:06:36 UTC --- Given that Perl 5.10 is now the minimum version for Koha, it may prove more efficient to use ~~ than grep. For example: if ( grep {$_ eq $biblionumber} @cart_list) { $this_item->{'incart'} = 1; } Becomes if ( $biblionumber ~~ @cart_list) { $this_item->{'incart'} = 1; } Template level changes look good, and code is clean. Just wanted to bring this up to see if anyone had more information or an opinion on the matter before I push through QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 --- Comment #12 from stephane.delaune(a)biblibre.com 2012-02-06 16:00:17 UTC --- (In reply to comment #10) > What do you put in if you want to use the default xslt stylesheet? e.g. if you are in unimarc, with koha src into /home/koha/src for the syspref XSLTDetailsDisplay : /home/koha/src/koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetDetail.xsl as I said in my previous comment : if syspref was true (value=1), the updatedatabase insert default xslt stylesheet as new value (path built with the same method previously used by C4::XSLT->XSLTParse4Display ) -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 --- Comment #11 from stephane.delaune(a)biblibre.com 2012-02-06 15:52:47 UTC --- (In reply to comment #10) > I feel it is unclear what needs to be done with this preference - it may be a > documentation thing. > > What do you put in if you want to use the default xslt stylesheet? if syspref was true, the updatedatabase insert default xslt stylesheet as new value >If you don't want to use XSLT at all? for not use it, leave a blank value (no value) in the syspref > > Would it be better to have a hybrid approach - a drop down to select XSLT and a > box to put in the path to your custom stylesheet? why use 8 sysprefs while only 4 are sufficient. no value/empty value = no xslt ; a value = the path to xslt file to use I do not find it complicated to understand, I do not think it is appropriate to double the number of sysprefs here -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4032] XSLT systempreference should take a path to file rather than YesNo
by bugzilla-daemon＠bugs.koha-community.org 06 Feb '12

06 Feb '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4032 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |wizzyrea(a)gmail.com --- Comment #10 from Liz Rea <wizzyrea(a)gmail.com> 2012-02-06 15:21:17 UTC --- I feel it is unclear what needs to be done with this preference - it may be a documentation thing. What do you put in if you want to use the default xslt stylesheet? If you don't want to use XSLT at all? Would it be better to have a hybrid approach - a drop down to select XSLT and a box to put in the path to your custom stylesheet? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug. You are watching all bug changes.

1 0