March 2012 - Koha-bugs - lists.koha-community.org

[Bug 7773] New: serials/subscription-add.pl needs to scope $query for plack
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7773 Priority: P5 - low Change sponsored?: --- Bug ID: 7773 Assignee: colin.campbell(a)ptfs-europe.com Summary: serials/subscription-add.pl needs to scope $query for plack QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Serials Product: Koha Created attachment 8394 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8394&action=edit proposed patch -- You are receiving this mail because: You are watching all bug changes.

1 10

[Bug 7801] New: admin/patron-attr-types.pl plack scoping
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7801 Priority: P5 - low Change sponsored?: --- Bug ID: 7801 CC: gmcharlt(a)gmail.com Assignee: paul.poulain(a)biblibre.com Summary: admin/patron-attr-types.pl plack scoping QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: System Administration Product: Koha -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 7800] New: admin/matching-rules.pl plack scoping
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7800 Priority: P5 - low Change sponsored?: --- Bug ID: 7800 CC: gmcharlt(a)gmail.com Assignee: paul.poulain(a)biblibre.com Summary: admin/matching-rules.pl plack scoping QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: System Administration Product: Koha -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 7790] New: tools/manage-marc-import.pl breaks with plack
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7790 Priority: P5 - low Change sponsored?: --- Bug ID: 7790 Assignee: gmcharlt(a)gmail.com Summary: tools/manage-marc-import.pl breaks with plack QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Tools Product: Koha -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 7798] New: admin/item_circulation_alerts.pl plack scoping
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7798 Priority: P5 - low Change sponsored?: --- Bug ID: 7798 CC: gmcharlt(a)gmail.com Assignee: paul.poulain(a)biblibre.com Summary: admin/item_circulation_alerts.pl plack scoping QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: System Administration Product: Koha -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 7795] New: admin/authorised_values.pl: breaks with plack
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7795 Priority: P5 - low Change sponsored?: --- Bug ID: 7795 Assignee: gmcharlt(a)gmail.com Summary: admin/authorised_values.pl: breaks with plack QA Contact: koha.sekjal(a)gmail.com Severity: enhancement Classification: Unclassified OS: All Reporter: dpavlin(a)rot13.org Hardware: All Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 4246] Koha support for Itiva Talking Tech phone notification service
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall <kyle.m.hall(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8637|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle.m.hall(a)gmail.com> --- Created attachment 8638 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8638&action=edit Talking Tech Support - Phase I - Followup - Fix Messaging Preferences There is a flaw in C4::Members::Messaging::GetMessagingPreferences where the system assumes that every transport will use the same letter. This is not necessarily true. Even with the default preferences of just 'email' and 'sms', we should be able to have different letters for each, as one has a maximum character length ( sms ) and one does not. GetMessagingPreferences currently uses the letter code of the last result of its query as the letter code for every transport type. The returned data is a hashref with a key 'transport_types' that is an array of transport_types this borrower has selected for the given alert. This commit modifies GetMessagingPreferences such that the the 'transport_types' array is now a hash where the name of the transport type is now a key to the value of the letter code set for that transport type. It also modifies code calling GetMessagingPreferences where necessary, and as a side benefit will correctly get the letter codes for email and sms correctly, if they are defined differently. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4246] Koha support for Itiva Talking Tech phone notification service
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall <kyle.m.hall(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |kyle.m.hall(a)gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4246] Koha support for Itiva Talking Tech phone notification service
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 --- Comment #7 from Kyle M Hall <kyle.m.hall(a)gmail.com> --- Created attachment 8637 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8637&action=edit Talking Tech Support - Phase I - Followup - Fix Messaging Preferences There is a flaw in C4::Members::Messaging::GetMessagingPreferences where the system assumes that every transport will use the same letter. This is not necessarily true. Even with the default preferences of just 'email' and 'sms', we should be able to have different letters for each, as one has a maximum character length ( sms ) and one does not. GetMessagingPreferences currently uses the letter code of the last result of its query as the letter code for every transport type. The returned data is a hashref with a key 'transport_types' that is an array of transport_types this borrower has selected for the given alert. This commit modifies GetMessagingPreferences such that the the 'transport_types' array is now a hash where the name of the transport type is now a key to the value of the letter code set for that transport type. It also modifies code calling GetMessagingPreferences where necessary, and as a side benefit will correctly get the letter codes for email and sms correctly, if they are defined differently. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4246] Koha support for Itiva Talking Tech phone notification service
by bugzilla-daemon＠bugs.koha-community.org 26 Mar '12

26 Mar '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4246 Kyle M Hall <kyle.m.hall(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8014|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle.m.hall(a)gmail.com> --- Created attachment 8636 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8636&action=edit Talking Tech Support - Phase I Implements support for Talking Tech I-tiva phone notification for OVERDUE, PREDUE and HOLD notifications. Overdues respect triggers as configured for the patron's branch. Predue and Holds notifications respect patron's messaging preference choices. A new column for phone notification is added if the TalkingTechItivaPhoneNotification system preference is turned on Record of phone messages being sent to patrons is added to the patron's Notices tab; notice of success or failure can be retrieved from I-tiva. See the TalkingTech.README for installation and set-up instructions. Aside from the control system preference, and the necessary changes to Messaging Preferences forms to make use of phone notifications, the bulk of the code resides in external cronjobs. TalkingTech_itiva_outbound.pl generates the Spec C file to send to I-tiva. Actual transmission of the file must be handled by the system administrator. TalkingTech_itiva_inbound.pl processes the received Results file from I-tiva. Getting the file from I-tiva to Koha is the job of the system administrator, as well. Both scripts have a --help option with full documentation. The only necessary change to core Koha behavior is in C4::Letters::EnqueueLetter. The return value was changed from 0 or 1 (successful addition of letter to message_queue or not), to the actual insert ID of the letter. This was required by the outbound script to present a unique Transaction ID for the notice added to the patron's record (so a 'sent' or 'failed' status could be updated). Since the dbh and sth are not shared, and the last_insert_id() command is table-specific, this should be thread-safe. No changes are necessary to any parts of Koha, as all usage of EnqueueLetter currently ignores the return value. To Test: 1. Turn on TalkingTechItivaPhoneNotification system preference 2. Verify that 'phone' is now a valid notification option for patrons on both staff and OPAC side 3. Attempt to set a 'phone' preference for PREDUE or HOLD messaging; attempt should succeed 4. Set up the patron for notices to triggers: a. include checked out items due in a range of days, including the value set up in their messaging preferences. b. place several holds, some in position, others waiting for pickup, others in transit. c. set the patron up to have overdues, overdue by a range of days that includes the delay values for the patrons branch and categorycode 5. Run TalkingTech_itiva_outbound.pl --type=RESERVE --type=PREOVERDUE --type=OVERDUE --outfile=/tmp/talkingtechtest.csv The resulting talkingtechtest.csv file should include all the items due on X days (where X is the patrons' preference), and none of the ones due in other increments. Similarly, overdues messages should be added for each item due by a delay value as configured; overdues of other numbers of days should be ignore. Holds that are waiting pick up or in transit should have messages, those still pending should not. Messages should be added to the patron's notices tab for each issue sent. Verify these messages exist, and all Notices tokens are replaced with appropriate information. Repeat, this time with 4c making use of the default branch overdue triggers, instead of branch-specific triggers. To test the inbound script, create a CSV with rows in the format "<<Message_id>>","<<SUCCESS or FAIL>>" Message ID should correspond to the final column of the talkingtechtest.csv file (the transaction id) for the message. Primary Authorship: Ian Walls Additional modifications: Kyle M Hall -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0