April 2012 - Koha-bugs - lists.koha-community.org

[Bug 2865] Acquisitions: GST not calculating correctly.
by bugzilla-daemon＠bugs.koha-community.org 16 Apr '12

16 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2865 Chris Hall <chrish(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #8460|0 |1 is obsolete| | --- Comment #7 from Chris Hall <chrish(a)catalyst.net.nz> --- Created attachment 9212 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9212&action=edit corrects errors in acquisitions calculations Attached patch that meets clients specs, not ready to be up streamed yet. Hey Katrin You understood correctly, it assumes budgeted cost is GST exclusive so this can't be pushed to master yet. Just for documentation purposes, here is what I used the various variables to mean: list price = may or may not include gst depending on vendor settings, if there if a discount then this price hasnt been adjusted to reflect the discounted price. unit price = actual cost, user supplied, not used in calculations rrp = gst exclusive, also doesnt reflect discounted price ecost = budgeted cost = list price minus any discount and excluding gst gstrate = rate of gst as a percentage gst = rrp * gstrate The previous code used gst to refer to both the rate and the actual amount in different places, I have corrected this where I came across it. Work to be done: Setting for whether or not the budgeted cost is gst inclusive/exclusive. This is the previous issue Katrin pointed out still exists, see line 323 or acqui/parcel.pl, I have labeled this with a FIXME as this assumes tototal is gst exclusive and will always add it back in. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4090] subscription ID showing in OPAC - confusing
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4090 --- Comment #3 from Nicole C. Engard <nengard(a)gmail.com> --- Katrin, The branch does show, so it makes sense to the user with that info, but the number is just confusing the patrons who don't know about the IDs or the way the db works. Nicole -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 --- Comment #3 from Marc Véron <veron(a)veron.ch> --- Oh, I see that the primary key is already addressed in Bug 7671 - add a real primary key "accountlinesid" in accountlines. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7756] New: claim mail is not sent for serial claim
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7756 Priority: P5 - low Change sponsored?: --- Bug ID: 7756 Assignee: colin.campbell(a)ptfs-europe.com Summary: claim mail is not sent for serial claim QA Contact: koha.sekjal(a)gmail.com Severity: critical Classification: Unclassified OS: Windows Reporter: jean-manuel.broust(a)univ-lyon2.fr Hardware: PC Status: NEW Version: master Component: Serials Depends on: 5342 Product: Koha appeared while testing patch 5342 on biblibre sandbox 1 : the mail of claim is not sent not in message queue. Logs says vendor has no mail but it does have ! (apache error claims.pl bookseller without email at home/koha/src/c4/letters.pm line 340) -- You are receiving this mail because: You are watching all bug changes.

1 15

[Bug 2696] Fine Payments Should Show What Was Paid For
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 Marc Véron <veron(a)veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron(a)veron.ch --- Comment #2 from Marc Véron <veron(a)veron.ch> --- At the moment the implementation is as follows (Acounts.pm line 65 ff and other places): --Snip---- Amounts owed are paid off oldest first. That is, if the patron has a $1 fine from Feb. 1, another $1 fine from Mar. 1, and makes a payment of $1.50, then the oldest fine will be paid off in full, and $0.50 will be credited to the next one. (...) # FIXME - I'm not at all sure about the above, because I don't # understand what the acct* tables in the Koha database are for. --End Snip ---- I tried to understand what happens in the code, and I came to the conclusion that the most important thing is a missing primary key in the table accountlines. This key could be transported through the chain of forms and involved code files to match payments with the fines the payments are made for. I a primary key in the table accountlines could be the basis to solve other bugs as well: - Bug 7531 - Reversing partial payments is buggy - (?) Bug 6413 - Notes in Fines doing wonky things - (?) Bug 2598 - Pay Fines allows payment against accruing fine. - (?) Bug 7205 - can't reverse manual credits - (?) Bug 7565 - Fee/fines receipt for printing - (?) Bug 6273 - SIP2 Fee Paid and Fee Paid Response support - Bug 3498 - Allow partial fine payments - Bug 2169 - Paying only partial fines (Duplicate of 3498) Maybe already addressed by: Bug 6427 - Rewrite of the accounts system ? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5017] New: can enter multiple funds with the same code
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5017 Summary: can enter multiple funds with the same code Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 Created attachment 2375 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2375 codes Code is not unique when adding funds - you can enter multiples with the same code - so why have a code? -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 4

[Bug 4531] admin/aqbookfund.pl: prevents the creation of funds with the same code
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4531 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED CC| |katrin.fischer(a)bsz-bw.de Resolution|--- |DUPLICATE --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Patch attached is still HTP so needs to be rewritten. Also there is a newer bug report about this. *** This bug has been marked as a duplicate of bug 5017 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5018] New: amount encumbered not showing on budgets
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5018 Summary: amount encumbered not showing on budgets Change sponsored?: --- Product: Koha Version: HEAD Platform: All OS/Version: All Status: NEW Severity: major Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 fund (cgi-bin/koha/admin/aqbudgets.pl?budget_period_id=3) not showing what is encumbered only what was spent - so it’s misleading to what is left in the budget - but it does show it on this page: cgi-bin/koha/acqui/acqui-home.pl -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 2

[Bug 4183] holdCancelLength missing from interface
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4183 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #3 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- >From 3714: Owen Leonard 2011-05-20 20:23:07 UTC holdCancelLength system pref has been removed. I checked and can find no reference for this system preference in current master. Resolving INVALID. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4183] holdCancelLength missing from interface
by bugzilla-daemon＠bugs.koha-community.org 15 Apr '12

15 Apr '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4183 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- 5872 is now resolved WONTFIX. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0