June 2012 - Koha-bugs - lists.koha-community.org

[Bug 8136] New: Changes the expected lenght of 100$a in rebuild_zebra.pl
by bugzilla-daemon＠bugs.koha-community.org 03 Jul '12

03 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8136 Priority: P5 - low Change sponsored?: --- Bug ID: 8136 Assignee: gmcharlt(a)gmail.com Summary: Changes the expected lenght of 100$a in rebuild_zebra.pl Severity: normal Classification: Unclassified OS: All Reporter: christophe.croullebois(a)biblibre.com Hardware: All Status: NEW Version: master Component: MARC Bibliographic data support Product: Koha In rebuild_zebra.pl, if we are in "unimarc" ("marcflavour" syspref), the sub "fix_unimarc_100" is called and checks if 100$a lenght is equal to 35. If it is not the case, the sub inserts the timestamp and more, so we loose the datas in reindexing. The standart lenght is 36. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 8087] New: Calendar not working in dropbox mode
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '12

02 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8087 Priority: P5 - low Change sponsored?: --- Bug ID: 8087 Assignee: henridamien(a)koha-fr.org Summary: Calendar not working in dropbox mode Severity: enhancement Classification: Unclassified OS: All Reporter: tdavis(a)uttyler.edu Hardware: All Status: NEW Version: master Component: Holidays Product: Koha It appears that dropbox mode is not working with the Holiday calendar again. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 8217] New: Focus on search box in Detail page (staff search)
by bugzilla-daemon＠bugs.koha-community.org 02 Jul '12

02 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8217 Priority: P5 - low Change sponsored?: --- Bug ID: 8217 Assignee: adrien.saurat(a)biblibre.com Summary: Focus on search box in Detail page (staff search) Severity: enhancement Classification: Unclassified OS: All Reporter: adrien.saurat(a)biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Searching Product: Koha Koha Team Lyon3 proposal/patch: When accessing a detail page after a search, it would be useful to have the focus on the search box. -- You are receiving this mail because: You are watching all bug changes.

1 29

[Bug 3280] opac/opac-sendbasket.pl security leaky
by bugzilla-daemon＠bugs.koha-community.org 30 Jun '12

30 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 --- Comment #19 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Chris, but this is already the case in 3.6? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4064] Uninitialized variable errors in opac-search.pl
by bugzilla-daemon＠bugs.koha-community.org 30 Jun '12

30 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 M. Tompsett <mtompset(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |mtompset(a)hotmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4064] Uninitialized variable errors in opac-search.pl
by bugzilla-daemon＠bugs.koha-community.org 30 Jun '12

30 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4064 --- Comment #1 from M. Tompsett <mtompset(a)hotmail.com> --- Created attachment 10572 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10572&action=edit Optimized two if statements, but otherwise fixed already in master. I was hunting through opac-search.pl and only found two references to $params->{'offset'} other than the initialization line that oleonard pointed out. 616: if (($params->{'offset'}||'') eq '') { 594: if (($params->{'offset'}||'') eq '') { If the parameter is undefined, the two lines above will be true. If the parameter is an empty string, the two lines above will be true. If the parameter is 0 or "0", the two lines above will be true. If the parameter is a non-zero value or an otherwise non-empty string, the two lines above will be false. It would seem to me that the above code on lines 594 and 616 in master is sufficient. Additionally, oleonard mentioned $borrowernumber. 592: if (!$borrowernumber || $borrowernumber eq '') { This is the only line that resembles what oleonard referred to. It would seem to me that the above code on line 592 in master is sufficient. The initialization of $offset is now on line 400 in master: my $offset = $params->{'offset'} || 0; This implies that the parameter is expected to be numeric, not a string. I think oleonard's observation that there is a $offset variable is useful to note as everywhere else in opac-search.pl uses the $offset variable. Based on the initialization line above: If the parameter is undefined, $offset is 0. If the parameter is an empty string, $offset is 0. If the parameter is 0 or "0", $offset is 0. If the parameter is a non-zero value or an otherwise non-empty string, $offset is that value or string. This means that lines 616 and 594 could be optimized to: 616: if (!$offset) { 594: if (!$offset) { Lines 592 and 594 correspond to the two lines oleonard mentions. This means I believe the bug is fixed already. I am changing the status to Needs Signoff, as this is not NEW. I'm attaching a patch accordingly, but feel free to reject it and just close this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3280] opac/opac-sendbasket.pl security leaky
by bugzilla-daemon＠bugs.koha-community.org 29 Jun '12

29 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3280 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|rel_3_8 |rel_3_10 --- Comment #18 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Because this now makes it impossible to send a cart without being logged in (which is probably a valid change) it is a big behaviour change which I dont want to spring on people mid cycle. Holding for 3.10 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8311] New: Mis-scoped function call in C4::Auth
by bugzilla-daemon＠bugs.koha-community.org 29 Jun '12

29 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8311 Priority: P5 - low Change sponsored?: --- Bug ID: 8311 Assignee: jcamins(a)cpbibliography.com Summary: Mis-scoped function call in C4::Auth Severity: normal Classification: Unclassified OS: All Reporter: jcamins(a)cpbibliography.com Hardware: All Status: NEW Version: master Component: Architecture, internals, and plumbing Product: Koha There is a mis-scoped function call in C4::Auth, on line 154, where GetMembers is called without explicit scoping and before 'require C4::Members;'. This does not actually have any functional ramifications as far as I can tell, but it would be a good idea to fix it. -- You are receiving this mail because: You are watching all bug changes.

1 9

[Bug 7352] New: moremember.pl generates error in Template.pm related to missing $key value
by bugzilla-daemon＠bugs.koha-community.org 29 Jun '12

29 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7352 Bug #: 7352 Summary: moremember.pl generates error in Template.pm related to missing $key value Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_6 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: fred.pierre(a)smfpl.org QAContact: ian.walls(a)bywatersolutions.com CC: gmcharlt(a)gmail.com This is similar to bug 6840, but generating an error from the patron quick search (search field at the top of the patron screen). We received errors related to Template.pm missing a $key value. The patch for bug 6840 partially patches the error, but still generates tons of log messages when circ accesses the patron detail screen, so we altered the moremember.pl around line 474 to omit the "$error => 1," and editing the error parameter as follows: --------------------------------------------------- overdues_exist => $overdues_exist, error => 0, StaffMember => ($category_type eq 'S'), --------------------------------------------------- Then we added this status check for errors to the moremember.pl at new line 485, following the close of the original template value definition: --------------------------------------------------- #addition to test error parameter status if ( $error ) { $template -> param ( $error => 1, error => 1, ); } ----------------------------------------- Here is the original error message: moremember.pl: Use of uninitialized value $key in hash element at /home/koha/kohaclone/C4/Templates.pm line 227., referer: http://koha.smfpl.org/cgi-bin/koha/members/member.pl Here is the error message, after patching 6801: moremember.pl: Problem = a value of 1 has been passed to param without key at /home/koha/kohaclone/C4/Templates.pm line 230., referer: http://koha.smfpl.org/cgi-bin/koha/circ/circulation.pl After our patch, listed above, there are no further error messages being generated from the moremember.pl patron detail screen. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 3

[Bug 6350] New: Bug for tracking updates to the history file
by bugzilla-daemon＠bugs.koha-community.org 29 Jun '12

29 Jun '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6350 Bug #: 6350 Summary: Bug for tracking updates to the history file Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: trivial Priority: P5 Component: Documentation AssignedTo: nengard(a)gmail.com ReportedBy: chris(a)bigballofwax.co.nz QAContact: koha-bugs(a)lists.koha-community.org -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 22