July 2012 - Koha-bugs - lists.koha-community.org

[Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '12

24 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #19 from Paul Poulain <paul.poulain(a)biblibre.com> --- OK, this time, passed QA. I also made many tests to check that, with without the syspref ReturnToShelvingCart set the behaviour is unchanged. I could not find any problem -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4321] C4::Biblio::GetBiblio is badly coded
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '12

24 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff CC| |jonathan.druart(a)biblibre.co | |m Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4321] C4::Biblio::GetBiblio is badly coded
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '12

24 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4321 --- Comment #2 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 11108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11108&action=edit Bug 4321: clean C4::Biblio::GetBiblio and uses -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 8489] New: Revised ubuntu-pkg-check.sh, renamed ubuntu package files, tweaked 12.04 package file.
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '12

24 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8489 Priority: P5 - low Change sponsored?: --- Bug ID: 8489 Assignee: gmcharlt(a)gmail.com Summary: Revised ubuntu-pkg-check.sh, renamed ubuntu package files, tweaked 12.04 package file. Severity: enhancement Classification: Unclassified OS: All Reporter: mtompset(a)hotmail.com Hardware: All Status: NEW Version: rel_3_6 Component: Installation and upgrade (command-line installer) Product: Koha This may overlap with bug 8478. The ubuntu-pkg-chk.sh script hardcoded the use of ubuntu.packages. By using an `lsb_release -r | cut -f2 -d'{tab}'` we can determine the version number of the ubuntu (tested on 10.04 and 12.04). If the user is running on a non-LTS, the script will inform the user and use the latest one, because NOTE: ubuntu.packages SHOULD ALWAYS BE A COPY OF THE LATEST VERSION!!! ubuntu.packages became ubuntu.10.04.packages ubuntu_maverick.packages became ubuntu.10.10.packages ubuntu.precise.packages became ubuntu.12.04.package (was created from 8488) This supersedes bug 8488, by renaming ubuntu.precise.packages to ubuntu.12.04.packages and updating the libmysqlclient16 to mylibsqlclient18 and removing the libmysqlclient16-dev. There were no known dependencies in the perl libraries. Feel free to confirm otherwise. I then copied ubuntu.12.04.packages back to ubuntu.packages after modifications, as the INSTALL.ubuntu install instructions say: $ sudo dpkg --set-selections < install_misc/ubuntu.packages The goal of this script is that: ./ubuntu-pkg-check.sh | grep none should produce no output if all dependencies are installed (optional or otherwise). However, it should be noted that the wiki instructions do not reference the file ubuntu-pkg-check.sh and it is currently only mentioned in the INSTALL.ubuntu.lucid instructions. The figures generated by: # A = $ ./install_misc/ubuntu-pkg-check | wc $ ./koha_perl_deps.pl -a # and B = the total modules reported number should have A>=B. And, if the ubuntu packages were installed with dselect, there should be 0 modules listed for: $ ./koha_perl_deps.pl -m -u To the cleanest 3.6.X version install yet! :) -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 8458] New: $stemmed_operand in C4::Search _build_stemmed_operand is not initialized.
by bugzilla-daemon＠bugs.koha-community.org 24 Jul '12

24 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8458 Priority: P5 - low Change sponsored?: --- Bug ID: 8458 Assignee: gmcharlt(a)gmail.com Summary: $stemmed_operand in C4::Search _build_stemmed_operand is not initialized. Severity: major Classification: Unclassified OS: All Reporter: mtompset(a)hotmail.com Hardware: All Status: NEW Version: unspecified Component: Searching Product: Koha Summary says it all. Found this while reading my git clone's code. -- You are receiving this mail because: You are watching all bug changes.

1 12

[Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '12

23 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #10908|0 |1 is obsolete| | --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 11093 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11093&action=edit BugFix - ReturnToShelvingCart If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit. What seems to be happening is this: * Item is checked in, and flagged as needing to go in transit from A to B. * Item is immediately flagged as shelving cart, though. Current display says both shelving cart and in transit. * After the cart-to-shelf script runs, item comes out of transit and shows as being available at the destination library, although it hasn't arrived yet and no one has manually checked it in. http://bugs.koha-community.org/show_bug.cgi?id=3701 Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '12

23 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to comment #16) > QA comment: > > The code now says > ShelfToCart( $item->{'itemnumber'} ); > => shouldn't we deal with the syspref and say > ShelfToCart( $item->{'itemnumber'} ) if > C4::Context->preference("ReturnToShelvingCart"); > ? You are right, I'll fix that. > 2nd question: when the item reaches it's homebranch, a check-in is done, > right ? > I tried that, and the location stayed to 'CART' instead of being switched > back to items.permanentlocation. Yes, a check-in is done, but that sets the location to 'CART' if it is not already set. Later, the cronjob will change the status from 'CART' back to the item's permanent location. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4048] CSS and JS libs must be outside of translated paths
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '12

23 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #9587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4048] CSS and JS libs must be outside of translated paths
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '12

23 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4048 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #13 from Owen Leonard <oleonard(a)myacpl.org> --- Revised again following major changes to jQuery and YUI assets. The correction in Julian's first patch has been incorporated. Yet another updated branch here: http://gitorious.org/koha-dev/koha-dev/commits/ip-bug-4048-css-js-libs-2012… This patch is an attempt to tackle Bug 4048 in a more incremental way. As suggested by Paul, this patch leaves in place a copy of the CSS and JS files in their original location to allow full implementation to be gradual. 1. Template.pm has been modified to pass an "interface" variable to the templates so that references to [% themelang %] can be replaced with [% interface %]/[% theme %] ("intranet-tmpl/prog") where appropriate. 2. The staff client's css, js, and lib directories have been 'git mv'ed to intanet-tmpl/prog where the img directory is. 'git mv' was used to preserve the git history of the files which are in their correct location. 3. The staff client's css, js, and lib directories have been copied back to their original location in order to provide a fallback as we make corrections to individual templates. These files have lost their git history, but will ultimately be deleted anyway. 4. The staff client's primary document header include files have been updated with the new paths. These are the files that define the paths to all the core CSS and JS files. 5. Relative image paths in the moved CSS files have been corrected to point to the right directory. TO TEST: After applying the patch, look at any page in the staff client. If the CSS paths are correct everything should look normal. View source to confirm that core assets are being pulled from the new location. If you use Firefox and have Firebug enabled it should report no "NetworkError: 404" errors. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3701] If the ReturnToShelvingCart syspref is on, and something needs to go in transit, the shelving cart setting is overriding the transit.
by bugzilla-daemon＠bugs.koha-community.org 23 Jul '12

23 Jul '12

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3701 --- Comment #16 from Paul Poulain <paul.poulain(a)biblibre.com> --- QA comment: The code now says ShelfToCart( $item->{'itemnumber'} ); => shouldn't we deal with the syspref and say ShelfToCart( $item->{'itemnumber'} ) if C4::Context->preference("ReturnToShelvingCart"); ? 2nd question: when the item reaches it's homebranch, a check-in is done, right ? I tried that, and the location stayed to 'CART' instead of being switched back to items.permanentlocation. -- You are receiving this mail because: You are watching all bug changes.

1 0