November 2013 - Koha-bugs - lists.koha-community.org

[Bug 10831] New: QueryParser requires that defaultSortField and defaultSortOrder be set to non-NULL values
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '14

10 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10831 Bug ID: 10831 Summary: QueryParser requires that defaultSortField and defaultSortOrder be set to non-NULL values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: gmcharlt(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org If QueryParser is enabled, the system preferences defaultSortField/defaultSortOrder (and their OPAC kin OPACdefaultSortField/OPACdefaultSortOrder) should not be set to NULL values. Otherwise, for searches where the sort order is not explicitly specified (e.g., searches made from the staff and OPAC global search box), the search can fail. This is due to several slightly questionable coding constructs collaborating in the confusion of both the user and the developer: [1] If a default sort order is not set, catalogue/search.pl and opac/opac-search.pl can end up setting the @sort_by array to (undef). This is because of the construct @sort_by = $cgi->param('sort_by'); If the sort_by CGI parameter is not passed, the result is not an empty array, it's an array containing one element whose value is undef. [2] The following code in C4::Search::parseQuery in turn uses @sort_by to add QP modifiers: if ( scalar(@sort_by) > 0 ) { my $modifier_re = '#(' . join( '|', @{ $QParser->modifiers } ) . ')'; $query =~ s/$modifier_re//g; foreach my $modifier (@sort_by) { $query .= " #$modifier"; } } If the query is "history", the modified version becomes "history #" ... which in turn results in a query that will not make sense to Zebra. One solution is to push through a DB update that extends the fix for bug 8012 to set the system preferences to sensible default values (probably relevance descending) if they're currently NULL. Note, by the way, that this means that the bug manifests itself only in databases old enough to have been created before the patch for bug 8012 was pushed. Another part of the solution, however, ought to be make the code in question a little more robust. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 5502] New: /cgi-bin/koha/patroncards/members-search.pl
by bugzilla-daemon＠bugs.koha-community.org 10 Aug '14

10 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5502 Summary: /cgi-bin/koha/patroncards/members-search.pl Change sponsored?: --- Product: Koha Version: rel_3_4 Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Label printing AssignedTo: cnighswonger(a)foundations.edu ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org Estimated Hours: 0.0 When searching for patrons to add to a batch for creating patron cards, you can search by name or "category code." Category code is a text input field. It would be better for this to be a drop-down menu of existing categories. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 14

[Bug 7541] New: News items won't display for translated dialects
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '14

09 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7541 Bug #: 7541 Summary: News items won't display for translated dialects Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P3 Component: OPAC AssignedTo: oleonard(a)myacpl.org ReportedBy: chris(a)bigballofwax.co.nz QAContact: koha.sekjal(a)gmail.com The news tool sets news for the language only, eg en But the opac looks for en-NZ and can find no matching news items. They should both behave the same -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 3

[Bug 8756] New: Vendor details and price should carry over to item information.
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '14

09 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8756 Priority: P5 - low Change sponsored?: --- Bug ID: 8756 Assignee: koha-bugs(a)lists.koha-community.org Summary: Vendor details and price should carry over to item information. Severity: enhancement Classification: Unclassified OS: All Reporter: vimal0212(a)gmail.com Hardware: All Status: NEW Version: rel_3_10 Component: Acquisitions Product: Koha When receiving a book in Acquisition module, details like price, vendor name, invoice name etc. should carry over to item information as bibliographic details. Otherwise librarian has to enter these information manually when cataloging items. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 10489] New: Add comments to news
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '14

09 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10489 Bug ID: 10489 Summary: Add comments to news Classification: Unclassified Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: viktor.sarge(a)regionhalland.se The news function could benefit from the ability for patrons comment on individual news. This would even make the news a viable replacement for a separate blog for many libraries with the additional benefit of keeping the blog integrated with the opac. A starting point of functions: * The ability for logged in patrons to create a comment. * A system parameter to turn comments on/off. * Displaying comments on the users profile in opac. * Checking "notify me of follow up comments" should communicate additional comments on the patrons profile in opac. * Integration with external spam-filters (at least if we allow anonymous comments). * Perhaps the ability to comment anonymously while not logged in? Might need to be thought through. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 7567] New: News by Library
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '14

09 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7567 Bug #: 7567 Summary: News by Library Classification: Unclassified Change sponsored?: --- Product: Koha Version: rel_3_8 Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools AssignedTo: gmcharlt(a)gmail.com ReportedBy: savitra.sirohi(a)osslabs.biz QAContact: koha.sekjal(a)gmail.com Allow creation of News item by library. On both Staff and OPAC dispaly a library pull down menu so users can filter by library to see News specific to that library. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 126

[Bug 6745] New: having branch specific news
by bugzilla-daemon＠bugs.koha-community.org 09 Aug '14

09 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6745 Bug #: 6745 Summary: having branch specific news Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Tools AssignedTo: gmcharlt(a)gmail.com ReportedBy: nengard(a)gmail.com QAContact: koha-bugs(a)lists.koha-community.org It would be nice if the news tool let you choose a branch so that slip items and even staff interface news only showed to people at a specific branch. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 1

[Bug 7115] New: Suggestion form has wrong label if AdvancedSearchTypes = collection
by bugzilla-daemon＠bugs.koha-community.org 08 Aug '14

08 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7115 Bug #: 7115 Summary: Suggestion form has wrong label if AdvancedSearchTypes = collection Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Acquisitions AssignedTo: henridamien(a)koha-fr.org ReportedBy: katrin.fischer(a)bsz-bw.de QAContact: koha-bugs(a)lists.koha-community.org Created attachment 6111 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6111 screenshot of suggestion form If you have set AdvancedSearchTypes to 'collection code' the suggestion form will offer a pull down with the collection codes, but the label still shows 'Item type' -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 3

[Bug 7002] New: Inaccurate checks for borrower flags == 1
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7002 Bug #: 7002 Summary: Inaccurate checks for borrower flags == 1 Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: normal Priority: P5 Component: Authentication AssignedTo: gmcharlt(a)gmail.com ReportedBy: oleonard(a)myacpl.org QAContact: koha-bugs(a)lists.koha-community.org CC: dpavlin(a)rot13.org There are a few instances in the code which I can find which use this to check whether someone has superlibrarian privileges in the context of IndependandBranches: unless (($userenv->{'flags'} == 1) or ($userenv->{'branch'} eq $item->{'homebranch'})) { This check fails if the logged in user has any other privilege checked in addition to superlibrarian. In other words, the user must *only* have superlibrarian checked in order to qualify to perform these operations. catalogue\moredetail.pl line 136 cataloguing\additem.pl line 548 tools\batchMod.pl line 460 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA Contact for the bug.

1 15

[Bug 10277] New: Add C4::Context->IsSuperLibrarian()
by bugzilla-daemon＠bugs.koha-community.org 07 Aug '14

07 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10277 Bug ID: 10277 Summary: Add C4::Context->IsSuperLibrarian() Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle.m.hall(a)gmail.com The method of checking the logged in user for superlibrarian privileges is obtuse ( $userenv && $userenv->{flags} % 2 != 1 ) to say the least. The codebase is littered with these lines, with no explanation given. It would be much better if we had one subroutine that returned a boolean value to tell us if the logged in user is a superlibrarian or not. -- You are receiving this mail because: You are watching all bug changes.

1 59