March 2013 - Koha-bugs - lists.koha-community.org

[Bug 906] ISBN Check
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 --- Comment #7 from Jared Camins-Esakov <jcamins(a)cpbibliography.com> --- (In reply to comment #6) > QA comment: > * I think I should fail QA the patch as it is written : there is a > plugin/value builder system in Koha, that is used for a lot of things, like > coded fields, but not only. Why didn't you use this system ? It would not > need to check between MARC21/UNIMARC/NORMARC, and no need of a syspref. look > in cataloguing/value_builder/, where plugins are. The addbiblio.pl part > could easily be ported to value_builder_checkisbn.pl, so the change should > not be too hard to do. > > * passes koha-qa.pl > > failing QA, but asking katrin's opinion, as she's the QA manager. I don't think a check like this can be done with a value_builder plugin. If I am wrong, a value_builder plugin would definitely be better, but the plugins aren't -- so far as I understand -- used for validation but rather as helpers for setting fields. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9403] New: Material type icons not showing for XSLT default view in intranet
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9403 Bug ID: 9403 Summary: Material type icons not showing for XSLT default view in intranet Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: katrin.fischer(a)bsz-bw.de In the OPAC result list with XSLT set to default we show a little icon after 'Type' and before the description: Type: <icon> serial We should show the same icons in the intranet XSLT default result list. -- You are receiving this mail because: You are watching all bug changes.

1 13

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15052|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 16669 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16669&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9634] New: Allow for parameters re-use on SQL reports
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9634 Bug ID: 9634 Summary: Allow for parameters re-use on SQL reports Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com If a parameter is used several times on a report, don't ask for him for each occurence. Detect duplicate name and re-use. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 906] ISBN Check
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=906 Paul Poulain <paul.poulain(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer(a)bsz-bw.de, | |paul.poulain(a)biblibre.com QA Contact| |paul.poulain(a)biblibre.com --- Comment #6 from Paul Poulain <paul.poulain(a)biblibre.com> --- QA comment: * I think I should fail QA the patch as it is written : there is a plugin/value builder system in Koha, that is used for a lot of things, like coded fields, but not only. Why didn't you use this system ? It would not need to check between MARC21/UNIMARC/NORMARC, and no need of a syspref. look in cataloguing/value_builder/, where plugins are. The addbiblio.pl part could easily be ported to value_builder_checkisbn.pl, so the change should not be too hard to do. * passes koha-qa.pl failing QA, but asking katrin's opinion, as she's the QA manager. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9893] New: Koha::DateUtils::output_pref should not use $dateonly parameter
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9893 Bug ID: 9893 Summary: Koha::DateUtils::output_pref should not use $dateonly parameter Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: jcamins(a)cpbibliography.com The fourth parameter to Koha::DateUtils::output_pref is $dateonly, which allows the user to specify that the time should not be included in the returned date string. Now that there is a $force_time format (which perhaps might be better called $date_format), it would probably be better to eliminate $dateonly, and use a time format of "none" when the time is not wanted. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4354] Cannot edit existing issuing rules
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #46 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 16658 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16658&action=edit [PASSED QA] Bug 4354: Manage the specific case "Unlimited" value Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> All good :) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4354] Cannot edit existing issuing rules
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #45 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 16657 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16657&action=edit [PASSED QA] Bug 4354: Followup: FIX the hardduedate copy Before this patch, the copy was based on the string (could be translated!). Now is base on the -1, 0, 1 values. The trick is to backup the hardduedatecompare value for each line of the table. Signed-off-by: Cedric Vita <cedric.vita(a)dracenie.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4354] Cannot edit existing issuing rules
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #44 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 16656 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16656&action=edit [PASSED QA] Bug 4354: Followup Add a Cancel button New cancel button on the edit row. Add a prevent message when editing a new row. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4354] Cannot edit existing issuing rules
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '13

21 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4354 --- Comment #43 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 16655 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16655&action=edit [PASSED QA] Bug 4354 - Followup - Add row highlighting Test plan: * Click on a row to edit * Note that the row is highlighted in orange Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> Signed-off-by: Nicole C. Engard <nengard(a)bywatersolutions.com> All tests pass. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> -- You are receiving this mail because: You are watching all bug changes.

1 0