March 2013 - Koha-bugs - lists.koha-community.org

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '13

06 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu <matted-34813(a)mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #15898|0 |1 is obsolete| | --- Comment #7 from wajasu <matted-34813(a)mypacks.net> --- Created attachment 15900 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15900&action=edit 0001-Bug-2499-add-support-for-text-wrapping-using-proportional -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '13

06 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #6 from wajasu <matted-34813(a)mypacks.net> --- Created attachment 15899 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15899&action=edit 0002-Bug-2499-remove-arbitrary-line-limit-for-label-text 0002-Bug-2499-remove-arbitrary-line-limit-for-label-text Removes the restriction for the amount of lines that may be printed in a label. Testing: (we are testing vertical layout calculation here ) We want to see of many lines from wrapping or from many fields will print if the font size lets them, without overlay in barcode or extending beyond the label edge. - print a working label exported to PDF that employs a barcode. - edit the layout to use larger font_sizes and repeat the export to ensure the text won't overlay the barcode - edit the layout/template to add author, author, author in the list to get even more rows. repeat the export to check if overlay. - edit the layout/template to use smaller fonts (10..5) to see the effects. - also test other label types. spine labels/splitting, just in case. - possibly test other export types (xml/csv), though i don't believe they apply. Note: Since I am not getting the character font height metric from the font, I relied on the existing line_spacer calculation, which is just the font_size. 10pt font = 10, 8pt font = 8. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 06 Mar '13

06 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #5 from wajasu <matted-34813(a)mypacks.net> --- Created attachment 15898 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15898&action=edit 0001-Bug-2499 add support for text wrapping using proportional font metrics Currently when labels are printed and the text would render past the bounding label definition, the number of chars that can be written per row is based off of a fixed size for a character in that font. This change performs text wrapping based on each character's character width metric contained in the specified font. Once truncation is detected, it scans back and breaks on a space, and continues with the next words on subsequent lines. It will allow more characters or words from a 'title' to be written per line when possible. 0001-Bug-2499-add-support-for-text-wrapping-using-proportional font metrics is an improvement, and deals with horizontal aspects, cramming more characters per line when wrapping. The original bug comment wants us to calculate the number of lines one can write vertically so we dont arbitrarily cut off after 2, but use what we can without overlaying a barcode or such. To test this patch: -With a working BIBBAR based label, use itemcallnumber,author,title as well. -With a test biblio, create a batch, and export it as a PDF. -Edit that biblio, and make the title longer (add 4 3 letter words) so that it would wrap to another line, but seems to have space to fit the words it wrapped. -APPLY PATCH -Export batch as a PDF. -Confirm that more words fit per line. To fulfill the original bug description: - perform calculations to determin the number of lines we can write without overlaying the barcode or running past the bottom of the label. - maintain this rows_to_write counter and stop writing lines accordingly, I got this patch in because it should not break anyones existing labels. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '13

05 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 --- Comment #4 from Chris Nighswonger <cnighswonger(a)foundations.edu> --- I'm not sure what approach you've taken, but here is the problem code: http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Labels/Label.p… 433 eval{$Text::Wrap::columns = $self->{'text_wrap_cols'};}; 434 my @line = split(/\n/ ,wrap('', '', $field_data)); 435 # If this is a title field, limit to two lines; all others limit to one... FIXME: this is rather arbitrary 436 if ($field->{'code'} eq 'title' && scalar(@line) >= 2) { 437 while (scalar(@line) > 2) { 438 pop @line; 439 } 440 } else { 441 while (scalar(@line) > 1) { 442 pop @line; 443 } 444 } 445 push(@label_lines, @line); 446 } As it is it is, well, rather arbitrary. A little while later we do something much more intelligent to figure line width in the justification routine: 450 my $string_width = C4::Creators::PDF->StrWidth($line, $font, $self->{'font_size'}); Something similar could be done to replace the arbitrary method back at lines 433-446. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2499] Improvement on text wrapping algorithm needed
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '13

05 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2499 wajasu <matted-34813(a)mypacks.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |matted-34813(a)mypacks.net --- Comment #3 from wajasu <matted-34813(a)mypacks.net> --- I did write a sub-routine in C4/Labels/Labels.pm that used StrWidth for each individual character of the specified font/fontsize, such that if it was going to get truncated, it would scan back to the prior space and wrap to the next line. Typically, the title being the culprit. I did get a word or two extra in the first line. I did not add behavior to throw way the second line, if there are more lines to be written. I suppose this would also need to content with varying line height based on the fontsize, because folks might be dropping to a smaller fontsize (10 is about 4 lines, 6 might get you more). But my labels are usually: itemcallnumber, author, title (possible2 lines) in a BIBBAR printstyle. font Times Roman, fontsize 10. A title like: Salty librarians, and savvy cataloguers, dusty books : became: Salty librarians, and savvy cataloguers,dusty books : with my proportional wrap. Let me know and I'll work on sending a patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 2780] Capitalize strings consistently
by bugzilla-daemon＠bugs.koha-community.org 05 Mar '13

05 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2780 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #161 from Owen Leonard <oleonard(a)myacpl.org> --- I'm sure there are minor instances of this remaining to be fixed, but they can be handled individually as we find them. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4164] Way to Clone Keyword Mapping to other Frameworks
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '13

04 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4164 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook(a)prosentient.com.au --- Comment #1 from David Cook <dcook(a)prosentient.com.au> --- (In reply to comment #0) > > > ---- Reported by nengard(a)gmail.com 2010-02-11 15:27:06 ---- > > Right now you have to enter a keyword mapping for each framework, I would > like to say apply this to 'all' frameworks or have a way to clone it to > specific other frameworks so that I don't have to enter the same thing over > and over again. > > > > --- Bug imported by chris(a)bigballofwax.co.nz 2010-05-21 01:23 UTC --- > > This bug was previously known as _bug_ 4164 at > http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=4164 > > Actual time not defined. Setting to 0.0 This could certainly be useful. I know that I find it rather annoying to either have to enter the same thing over and over again or resort to doing a change straight to the database. I'm actually working on making the keyword mapping more useful, so maybe this is something I'll keep in mind down the road... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 9074] New: DB dependent tests for is_holiday
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '13

04 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9074 Priority: P5 - low Change sponsored?: --- Bug ID: 9074 Assignee: koha-bugs(a)lists.koha-community.org Summary: DB dependent tests for is_holiday Severity: enhancement Classification: Unclassified OS: All Reporter: tomascohen(a)gmail.com Hardware: All Status: NEW Version: master Component: Holidays Product: Koha We need several de-dependent tests for is_holiday. We currently only have sample data and tests for repeteable holidays. Missing: - special holidays - exception holidays -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 22

[Bug 3645] Specify Duedate as part of item type
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '13

04 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3645 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer(a)bsz-bw.de Version|master |3.6 Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- You can now set due dates as part of the circ matrix for all combinations of patron category, itemtype and library. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5434] New: More granular hold rules
by bugzilla-daemon＠bugs.koha-community.org 04 Mar '13

04 Mar '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5434 Summary: More granular hold rules Change sponsored?: Sponsored Product: Koha Version: rel_3_4 Platform: All URL: http://wiki.koha-community.org/wiki/AllowOnShelfHolds OS/Version: All Status: NEW Severity: enhancement Priority: P5 Component: Circulation AssignedTo: kyle.m.hall(a)gmail.com ReportedBy: paul.poulain(a)biblibre.com QAContact: koha-bugs(a)lists.koha-community.org CC: gmcharlt(a)gmail.com Estimated Hours: 0.0 AllowOnShelfHolds syspref is currently global: one should be able to toggle the syspref by branch: branch A: AllowOnShelfHolds == Y branch B: AllowOnShelfHolds == N etc This will be a part of circ improvement, see also http://wiki.koha-community.org/wiki/Holds_managed_in_smart-rules -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug.

1 1