July 2013 - Koha-bugs - lists.koha-community.org

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19418|0 |1 is obsolete| | --- Comment #27 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 19419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19419&action=edit [SIGNED-OFF] Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19414|0 |1 is obsolete| | --- Comment #26 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 19418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19418&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19401|0 |1 is obsolete| | --- Comment #25 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 19414 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19414&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 10536] New: Error when editing an order note when receiving
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10536 Bug ID: 10536 Summary: Error when editing an order note when receiving Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: fridolyn.somers(a)biblibre.com When receiving ordrers "acqui/parcel.pl?invoiceid=1", you can add or modify an order note directly from table. After setting note "acqui/modordernotes.pl", you get an error : Can't use an undefined value as an ARRAY reference at /acqui/parcel.pl line 156. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 9

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 --- Comment #24 from Kyle M Hall <kyle(a)bywatersolutions.com> --- (In reply to Owen Leonard from comment #15) > - There is a typo in updatedatabase, a reversed end parenthesis. Fixed! > - There is at least once instance of "debar" being used instead of > "restrict" Fixed! > - I think the "X" icon isn't appropriate here. It would be simpler and more > clear to use text ("Remove"). Fixed! > - The table of restrictions doesn't look correct if there are no > restrictions--probably because there is nothing in <tbody>? Anyway > I think it would be more consistent to separate the entry from from > the table. Wrapping <form> around <tfoot> is invalid. > - onclick="return confirm(_('Remove debarment?'))" at line 24 of > borrower_debarments.inc is not translatable. The action should be moved > to a function. Fixed! > - borrower_debarments.inc has a couple of unescaped ampersands in line 24. Fixed! > I don't think the "Restrictions" tab should be present on circulation.pl at > all times. Being able to add a restriction to an account is certainly not > something which happens so frequently that it needs to be only one click > away. That is correct, it's there for removing restrictions primarily. However, I see no strong reason *not* to allow the ability to restrict a patron from here. > It's useful to be able to see information about all restrictions, but the > full information could just as easily be displayed in the main block of > "Cannot check out!" messages at the top. There's no reason to conserve space > there if the patron is restricted anyway. If we mimicked the current method > for displaying restrictions we could simply make it possible to display more > than one line of restrictions, each with the same "lift restriction" button > or link. As you write, it's useful, and this area appears to be more a matter of aesthetic preference. If you really dislike it, please submit a followup! > If we did this then we could move the form for adding a manual restriction > either back into the patron edit form (where people still expect to find it) > or onto its own page (not as good an option IMO). This latest edition of the patch adds the restrictions back to the patron editor to address this. > One idea for an improvement: Perhaps the overdue notices job could set a > restricted comment with the datetime of the job? "Restriction added by > overdues process 2013-03-05 00:20:00" Done! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18213|0 |1 is obsolete| | --- Comment #23 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 19401 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19401&action=edit Bug 2720 - Overdues which debar automatically should undebar automatically when returned This patch adds a more extensible and flexible debarments system to Koha. The fields borrowers.debarred and borrowers.debarredcomment are retained for compatibility and speed. This system supports having debarments for multiple reasons. There are currently three types of debarments: OVERDUES - Generated by overdue_notices.pl if the notice should debar a patron SUSPENSION - A punative debarment generated on checkin via an issuing rule MANUAL - A debarment created manually by a librarian OVERDUE debarments are cleared automatically when all overdue items have been returned, if the new system preference AutoRemoveOverduesRestrictions is enabled. It is disabled by default to retain current default functionality. Whenever a borrowers debarments are modified, the system updates the borrowers debarment fields with the highest expiration from all the borrowers debarments, and concatenates the comments from the debarments together. Test plan: 1) Apply patch 2) Run updatedatabase.pl 3) Verify the borrower_debarments table has been created and populated with the pre-existing debarments 4) Run t/db_dependent/Borrower_Debarments.t 5) Manually debar a patron, with an expiration date 6) Verify the patron cannot be issued to 7) Add another manual debarment with a different expiration date 8) Verify the 'restricted' message lists the date farthest into the future 9) Add another manual debarment with no expiration date 10) Verify the borrower is now debarred indefinitely 11) Delete the indefinite debarment 12) Verify the debarment message lists an expiration date dagain 13) Enable the new system preference AutoRemoveOverduesRestrictions 14) Set an overdue notice to debar after 1 day of being overdue 15) Check out an item to a patron and backdate the due date to yesterday 16) Run overdue_notices.pl 17) Verify the OVERDUES debarment was created 18) Return the item 19) Verify the OVERDUES debarment was removed 20) Disable AutoRemoveOverduesRestrictions 21) Repeat steps 15 though 18, verify the OVERDUES debarment was *not* removed 22) Add issuing rules so that an overdue item causes a temporary debarment 23) Check out an item to a patron and backdate the due date by a year 24) Return the item 25) Verify the SUSPENSION debarment was added to the patron -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3134] Ability to selelct multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 05 Jul '13

05 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Liz Rea <wizzyrea(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea(a)gmail.com --- Comment #5 from Liz Rea <wizzyrea(a)gmail.com> --- I actually think the number serves a purpose - rather than the name, which is not unique, the number gives librarians a way to identify a specific report - I often find myself asking "which number report are you running? There are three labeled "Circ stats - TEST"" or somesuch. Showing the number saves a lot of back and forth on that. Librarians often refer to the reports by number as well, just naturally. So please don't remove them. :) Liz -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 7409] New: Missing dependencies for Debian package
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '13

04 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7409 Bug #: 7409 Summary: Missing dependencies for Debian package Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Platform: All OS/Version: All Status: NEW Severity: enhancement Priority: P5 - low Component: Packaging AssignedTo: robin(a)catalyst.net.nz ReportedBy: jcamins(a)cpbibliography.com QAContact: ian.walls(a)bywatersolutions.com In order for all the functionality in Koha to work properly, unzip is required (for patron images), and perl-doc is required (for --help switches on the command line scripts). -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are watching all bug changes.

1 25

[Bug 10540] New: Saving interesting code (unit tests) from the deleted KohaTest suite
by bugzilla-daemon＠bugs.koha-community.org 04 Jul '13

04 Jul '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10540 Bug ID: 10540 Summary: Saving interesting code (unit tests) from the deleted KohaTest suite Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: m.de.rooy(a)rijksmuseum.nl Reporter: m.de.rooy(a)rijksmuseum.nl See bug 10539. -- You are receiving this mail because: You are watching all bug changes.

1 2