August 2013 - Koha-bugs - lists.koha-community.org

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #24 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 20528 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20528&action=edit Bug 3134: Reindent delete_report The first patch add a bad indentation for this routine. This patch fixes that. The $sth->finish statement is useless and should be removed. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #23 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 20527 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20527&action=edit Bug 3134: ID and Report name columns are not well sorted. The sort for ID is alpha instead of numerical, same for the report names. To test: create id=1, name=Report 1 create id=2, name=Report 2 create id=10, name=Report 10 create id=11, name=Report 11 Sorting by id: without this patch 1, 10, 11, 2 with this patch: 1, 2, 10, 11 Sorting by name: without this patch: Report 1, Report 10, Report 11, Report 2 with this patch: Report 1, Report 2, Report 10, Report 11 Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #22 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 20526 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20526&action=edit Bug 3134: Add the warn class on tr elements This patch adds the same behavior when deleting 1 or more reports. When checkboxes are checked and the "delete selected" button is pressed, checked lines are hightlighted in red. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #21 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 20525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20525&action=edit Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> This works really nicely, passes all tests and the QA script. There is one little thing to note: If you delete a single report using the option from the menu, the line you want to delete is highlighted in red. It would be nice to do that also for deleting multiple reports. Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20516|0 |1 is obsolete| | Attachment #20517|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 20524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20524&action=edit Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 21 Aug '13

21 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|koha-bugs(a)lists.koha-commun |jonathan.druart(a)biblibre.co |ity.org |m --- Comment #19 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- QA comment: These patches add the ability to delete multiple reports. The second one fixes the ergonomic issue (described in comment 14). I will provide 3 followups: 1/ Fix the following issue: (In reply to Katrin Fischer from comment #18) > There is one little thing to note: If you delete a single report > using the option from the menu, the line you want to delete > is highlighted in red. It would be nice to do that also for > deleting multiple reports. 2/ Fix the sort on id and report name 3/ Reindent the delete_report routine (shouldn't it be delete_reports?) and remove the $sth->finish statement. Note for RM: feel free to push only the 2 first patches and to ask for a new report for the 3 followups. Marked as Passed QA. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '13

20 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 --- Comment #18 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 20517 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20517&action=edit [SIGNED OFF] Bug 3134 [Follow-up] Ability to select multiple reports to delete at once This follow-up moves the checkboxes into a separate column from the report ID in order to prevent visual inconsistencies. To test, repeat the test plan from the original patch: You must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> This works really nicely, passes all tests and the QA script. There is one little thing to note: If you delete a single report using the option from the menu, the line you want to delete is highlighted in red. It would be nice to do that also for deleting multiple reports. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '13

20 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #20461|0 |1 is obsolete| | Attachment #20465|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 20516 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=20516&action=edit [SIGNED-OFF] Bug 3134 - Ability to selelct multiple reports to delete at once This patch adds the option to select multiple saved reports for deletion. To test you must have two or more saved reports to delete. Deletion should work properly when: - Selecting one report for deletion by checking the box. - Selecting more than one report for deletion by checking boxes. - Clicking the old "Delete" link Clicking the delete button should prompt you to confirm. Clicking cancel should cancel. Clicking the delete button when no boxes are checked should trigger an alert asking you to select reports for deletion. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Functional tests pass, template tests pass. Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3134] Ability to select multiple reports to delete at once
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '13

20 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3134 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3426] change itemcallnumber system preference to allow multiple tags
by bugzilla-daemon＠bugs.koha-community.org 20 Aug '13

20 Aug '13

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3426 Galen Charlton <gmcharlt(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.4 |master -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0