November 2014 - Koha-bugs - lists.koha-community.org

[Bug 13096] Send account notice with login details in more situations
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #12 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 33162 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33162&action=edit Bug 13096: Adjusting description of pref AutoEmailOPACUser. Test plan: Check the pref rewording in Systempreferences. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13096] Send account notice with login details in more situations
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #11 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 33161 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33161&action=edit Bug 13096: Send account notice when changing password with member-password Send an alert with account details if AutoEmailOpacUser is enabled and the checkbox was not unchecked. Added license statement and modern perl line to the code. Fixed some other minor issues too: When changing password, the ajax call used userid instead of borrowernumber. Current master does not allow you to change userid only. Test on newpassword in the template was dead. Removed dead destination parameter. Test plan: Disable AutoEmailOpacUser. Goto a patron. Click the Change Password button. No checkbox, no mail. Enable AutoEmailOpacUser. Click Change Password again. Do you receive a mail when saving? Uncheck the checkbox: no mail? Test changing the userid only. Test saving without any changes. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13096] Send account notice with login details in more situations
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #10 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 33160 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33160&action=edit Bug 13096: Send account notice when user completes self-registration If you have enabled AutoEmailOPACUser, a notice is sent to a patron at creation time. This patch will make Koha send a notice when someone self-registers and submits or follows the verification link. The usercode and password are prefilled on the form, but many patrons will find it helpful to have them in a mail. Instead of creating a new pref for this specific case, I have chosen to extend pref AutoEmailOpacUser. These situations are very similar. The pref text is adjusted in a follow-up. Note: If the user does not enter an email address, he will not receive any notice. (No verification link either.) Test plan: [1] Enable the prefs AutoEmailOPACUser and PatronSelfRegistration. [2] Enable PatronSelfRegistrationVerifyByEmail. [3] Self-register an account. Verify the account with the link in the mail. Check that you receive another mail with account details now. [4] Disable PatronSelfRegistrationVerifyByEmail. [5] Self-register again. Check if you receive a mail when submitting. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13096] Send account notice with login details in more situations
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #9 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 33159 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33159&action=edit Bug 13096: Send account notice at patron modification time Instead of sending an account notice only at creation time, this patch makes it possible to generate the same notice when changing account details of the patron. In memberentry.pl, the code for selecting an email address and sending the alert is replaced by calling SendAutoEmail in Members.pm. An additional call is made for the op=save situation; if in that case param mailacctdetails is true (checkbox), a mail will be sent. Note that the script refers to op=duplicate several times. Inspecting the template shows that the duplicate operation also goes via op=insert however. If the password is '!' (disabled), the form now shows the password as blank. If no password is entered, AddMember will insert the ! again. This makes staff more aware of a missing password than showing *****. Test plan: [1] Disable AutoEmailOpacUser. Add, duplicate, modify patron. No mails? [2] Enable AutoEmailOpacUser. Add, duplicate patron. Check mail. [3] Modify patron. Check the email checkbox. Did you receive it? [4] Modify patron. Uncheck the email checkbox. No mail? [5] Create a new patron without userid and password. No mail. [6] Edit this patron: a userid has been generated, but the password should be blank. Enter a password. Check mail. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13096] Send account notice with login details in more situations
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13096 --- Comment #8 from M. de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 33158 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33158&action=edit Bug 13096: Template changes for memberentry in staff. If AutoEmailOpacUser is enabled, Koha will send an email with account details to the patron at creation time. This report makes it possible to also send this mail when updating patron details, perhaps finishing the registration process at a later stage. This patch makes the needed template changes. It adds a checkbox when a patron is modified (not created/duplicated). It adds javascript to check this checkbox on a username or password change. The staff user can uncheck it again if needed. Test plan: Disable AutoEmailOpacUser. Test adding, duplicating and modifying a patron. You should not see the checkbox. Enable AutoEmailOpacUser. Test adding or duplicating. You should not see the checkbox. Test modifying a patron. If you edit username or password, the checkbox should automatically be checked. You can uncheck it again. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11948] New: last name browse on patron card creator searching anywhere
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11948 Bug ID: 11948 Summary: last name browse on patron card creator searching anywhere Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All URL: /cgi-bin/koha/patroncards/members-search.pl OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When you do a search for patrons in the patron card creator you're offered the option to browse by first letter of last name. I clicked D and got names like ADLES etc. It's searching anywhere in the name, not just the first letter of the last name like on the patron search page (which is right). -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 33144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33144&action=edit Bug 1861 [QA Followup] - Fix Check_Userid and unit tests Check_Userid assumes that a borrowernumber will always be passed in and thus fails to to return 0 for an already used userid when creating a new patron. Unit tests must now also me modified to no longer assume it is possible to create multiple patrons with the same userid. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30828|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 33143 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33143&action=edit Bug 1861 - Unique patrons logins not (totally) enforced The Koha 3.0 patron admin page will prevent you from creating a user who has an identical OPAC login as someone else (though I would change the error message from "Login/password already exists." to "Login already exists.", since it's not the password that's the problem). However, there's nothing enforced in the MySQL database to prevent patrons from being imported or manually inserted with duplicate logins. Would it be better to change the MySQL spec from this: KEY `userid` (`userid`) to this: UNIQUE KEY `userid` (`userid`) Test plan: 1) Enter mysql console 2) Attempt to create two borrowers with identical user id's 3) Note you are able to do so 4) Delete these bororwers 5) Apply this patch 6) Run updatedatabase.pl 7) Repeat step 2 8) Note you are now unable to do so Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Work as described, no koha-qa errors Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> Leaves deletedborrowers as it is, deleting patrons still works ok. Works according to test plan. Database update will only be successful, when no duplicate entries exist in the database. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1861] Unique patrons logins not (totally) enforced
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1861 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13187] New: Access keys should be localizable/translatable
by bugzilla-daemon＠bugs.koha-community.org 03 Nov '14

03 Nov '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13187 Bug ID: 13187 Summary: Access keys should be localizable/translatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr For example: cancelorder.tt: <input type="submit" class="approve" value="Yes, cancel" accesskey="y" /> cancelorder.tt: <input type="submit" class="deny" value="No, don't cancel" accesskey="n" onclick="window.location='[% referrer %]';return false;" /> After translating the buttons, the access keys do not reflect the button texts. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0