March 2014 - Koha-bugs - lists.koha-community.org

[Bug 10788] New: Add a Linked Data/RDF browser to the OPAC
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '14

21 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10788 Bug ID: 10788 Summary: Add a Linked Data/RDF browser to the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: magnus(a)enger.priv.no Reporter: magnus(a)enger.priv.no QA Contact: testopia(a)bugs.koha-community.org Blocks: 10787 This bug aims to add a browsing interface to the OPAC, that will make it possible to browse bibliographic records that have been converted from MARC to RDF and stored in a triplestore external to Koha. It will also be possible to browse data from external sources that has been entered into the triplestore, as well as any relations and other data that has been created in the triplestore. The browsing will be highly configurable, with SPARQL queries and related templates stored in the triplestore. One goal is to hard code as little as possible of the functionality, at least in the beginning. Future bugs will address the need for an interface to add and edit queries and templates in the triplestore, import of data from other source, manual enhancement of the data in the triplestore etc. The present bug is a functional proof of concept that aims to demonstrate the usefulness and potential that comes from utilizing Linked Data in an ILS. Conversion from MARC to RDF is outside the scope of this bug, but is being worked on by Chris Cormack. Until that work is submitted, it will be possible to do the conversion with tools external to koha, such as: - https://github.com/digibib/marc2rdf - https://github.com/edchamberlain/COMET/tree/master/conversion The features added by this bug will of course be governed by a syspref that defaults to "off". -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '14

21 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart(a)biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 3050] Add an option to upload scanned invoices.
by bugzilla-daemon＠bugs.koha-community.org 21 Mar '14

21 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3050 --- Comment #5 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Comment on attachment 25306 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25306 [SIGNED-OFF] Bug 3050 - Add an option to upload scanned invoices Review of attachment 25306: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3050…) ----------------------------------------------------------------- QA comments: 1/ A couple of errors are raised by the qa script: FAIL Koha/Misc/Files.pm FAIL pod *** WARNING: Verbatim paragraph in NAME section in file Koha/Misc/Files.pm *** ERROR: =item without previous =over in file Koha/Misc/Files.pm FAIL acqui/invoice-files.pl FAIL forbidden patterns forbidden pattern: trailing space char (line 130) 2/ The new module needs unit tests. 3/ And the following: ::: C4/Auth.pm @@ +358,4 @@ > EnableBorrowerFiles => C4::Context->preference('EnableBorrowerFiles'), > UseKohaPlugins => C4::Context->preference('UseKohaPlugins'), > UseCourseReserves => C4::Context->preference("UseCourseReserves"), > + AcqEnableFiles => C4::Context->preference('AcqEnableFiles'), You should check the syspref value in the templates using Koha.Preference('AcqEnableFiles') ::: Koha/Misc/Files.pm @@ +19,5 @@ > +# You should have received a copy of the GNU General Public License > +# along with Koha; if not, see <http://www.gnu.org/licenses>. > + > +use Modern::Perl; > +use strict; ## not needed if Modern::Perl, but perlcritic complains.. No complain from perlcritic if you define [TestingAndDebugging::RequireUseStrict] equivalent_modules = Modern::Perl in your .perlcriticrc Take a look at the perlcriticrc file in the qa-tools. @@ +70,5 @@ > + date_uploaded > + FROM misc_files > + WHERE table_tag = ? AND record_id = ? > + ORDER BY file_name, date_uploaded > + "; Replace quotes with simple quotes around sql queries. ::: acqui/invoice-files.pl @@ +28,5 @@ > +=cut > + > +use strict; > +use warnings; > + use Modern::Perl; @@ +40,5 @@ > + > +my $input = new CGI; > +my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user( > + { > + template_name => 'acqui/invoice-files.tmpl', s/tmpl/tt @@ +61,5 @@ > + my $file = $mf->GetFile( id => $file_id ); > + > + my $fname = $file->{'file_name'}; > + my $ftype = $file->{'file_type'}; > + if ($input->param('view') && ($ftype =~ /^image\//i || $fname =~ /\.pdf/i)) { Maybe m|^image/|i is more readable. @@ +103,5 @@ > + else { > + my $file_content; > + while (<$uploaded_file>) { > + $file_content .= $_; > + } I think my $file_content = <$uploaded_file>; does the same thing. ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice-files.tt @@ +27,5 @@ > + </div> > + [% END %] > + > + [% IF ( files ) %] > + <table> Please use Datatable for this table. @@ +64,5 @@ > + <legend>Upload New File</legend> > + <ol> > + <li><input type="hidden" name="op" value="upload" /> > + <input type="hidden" name="invoiceid" value="[% invoiceid %]" /> > + <input type="hidden" name="MAX_FILE_SIZE" value="9000000" /> This variable is not retrieve in the pl file. Is it useless? ::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/invoice.tt @@ +172,5 @@ > [% END %] > + [% IF ( AcqEnableFiles && files ) %] > + <br> > + <h2>Files attached to invoice</h2> > + <table> Please use Datatable for this table. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11980] New: way to choose the primary image when uploading covers
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11980 Bug ID: 11980 Summary: way to choose the primary image when uploading covers Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: gmcharlt(a)gmail.com Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org When you want to upload multiple images onto a bib record, they will display left to right (then top to bottom, depending on screen real estate) in order of uploading, and the one on the left (the first one uploaded) will be the one used as a thumbnail cover in search results, etc. It would be nice to be able to label one of the images as the 'primary' to be shown on search results and detail pages. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11972] New: Untranslatable "Reversed"
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11972 Bug ID: 11972 Summary: Untranslatable "Reversed" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr ReversePayment() in C4/Accounts.pm adds untranslatable "Reversed - " -text to accountlines. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11971] New: Untranslatable "Reserve Charge"
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11971 Bug ID: 11971 Summary: Untranslatable "Reserve Charge" Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs(a)lists.koha-community.org Reporter: pasi.kallinen(a)pttk.fi QA Contact: testopia(a)bugs.koha-community.org CC: frederic(a)tamil.fr AddReserve() in C4/Reserves.pm inserts hard-coded string "Reserve Charge - " into accountlines db table. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 2720] Overdues which debar automatically should undebar automatically when returned
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2720 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de Version|master |3.14 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 4397] display problems (umlauts, ß) with scan index in advanced search
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart(a)biblibre.co | |m -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4397] display problems (umlauts, ß) with scan index in advanced search
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4397 --- Comment #9 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Created attachment 26470 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26470&action=edit Bug 4397: Scan index search results broken for non-latin characters The Zoom specification defines that a ScanSet should provide a way to retrieve terms suitable for displaying and another one for using on further searches [1]. The Net::Z3950::ZOOM implementation actually provides both [2] but we where using the wrong one. Using $scanset->display_term(...) instead of $scanset->term(...) fixes the problem. To test: - Do a index scan search (advanced search > more options > check 'index scan') - Notice non-latin characters are replaced by one or more '@' symbols. - Apply the patch - Re-do the search, everything shows as it should. - Try to follow any of the terms (clicking on them) and notice that it actually gives you relevant results (i.e. is not searching for @!!!!). - Sign off :-D Regards To+ [1] http://zoom.z3950.org/api/zoom-1.4.html#3.6.3 [2] http://search.cpan.org/~mirk/Net-Z3950-ZOOM/lib/ZOOM.pod#term()_/_display_t… Sponsored-by: Universidad Nacional de Cordoba Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart(a)biblibre.com> I reproduced the issue and I confirm this patch fixes it. I put "Fuß" in a title, reindex the record. Launch a search on Title checking the "scan index" checkbox. And the non-latin characters are well displayed. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11424] New: Itemtype administration form is broken when noItemTypeImages is activated
by bugzilla-daemon＠bugs.koha-community.org 20 Mar '14

20 Mar '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11424 Bug ID: 11424 Summary: Itemtype administration form is broken when noItemTypeImages is activated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org To test: - Set noItemTypeImages to "Don't show" - Try adding a new itemtype in administration - the form is broken - Switch pref to "Show" - Confirm the form now looks correct -- You are receiving this mail because: You are watching all bug changes.

1 1