July 2014 - Koha-bugs - lists.koha-community.org

[Bug 12443] New: Initial re-factoring of buildQuery
by bugzilla-daemon＠bugs.koha-community.org 01 Aug '14

01 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12443 Bug ID: 12443 Summary: Initial re-factoring of buildQuery Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: gmcharlt(a)gmail.com Reporter: dcook(a)prosentient.com.au QA Contact: testopia(a)bugs.koha-community.org Before I start trying to fix bad/broken behaviour in buildQuery, I want to refactor it to preserve the current behaviour but in a form that will be easier to fix later. The goal of this bug will be to normalize how the parsed query parameters are formed into the actual Zebra query. Actually a lot more straightforward than it sounds... -- You are receiving this mail because: You are watching all bug changes.

1 27

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12687 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30406|0 |1 is obsolete| | --- Comment #79 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 30432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30432&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30405|0 |1 is obsolete| | --- Comment #78 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 30430 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30430&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrollinglist from authorised_values.pl This patch removes the only instance in this file. Also fixes array sorting, removes some tabs, removes an unneeded $dbh handler (there is a global one). Makes use of C4::Koha::GetAuthorisedValueCategories. To test: 1. Apply the patch 2. Go to Administration > Authorised values 3. Replaced pulldown next to 'Show category' must show all (present & system) categories correctly ordered. 4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO no changes must be observed Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30404|0 |1 is obsolete| | --- Comment #77 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 30428 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30428&action=edit [SIGNED-OFF] Bug 766: Remove CGI::scrolling_list from aqplan.pl This patch removes 3 occurences on aqplan.pl To test: 1. You need a budget and a found 2. Apply the patch 3. Go to Aquisitions, click on your found 4. Select one of the options on pulldown Planning e.g. "Plan by months" 5. Now to the left there are two boxes, Filter and Export a) Filter: (1) pulldown below 'Select planning type' check that works selecting other values and submit This pulldown showed originally code types, untranslatable BTW. Added a TT block to allow translation and shows legends that match Planning pulldown, but not the order. b) Export: pulldowns for filetype (2) and delimiter (3) Those have originally one value each, and for me Export does not work, before or after patch, but check that pulldown exist. Notes: A) 5.a) I can change de order of main Planning pulldown, is harcoded. The values for Filter pulldown are sorted on aqplan.pl. Is one or the other. If desired, TT block can be moved to includes/budgets-admin-toolbar.inc (where hardcoded Planning lives) B) 5.b) Moved 'Export' legend inside it's box, like Filter. C) Finally: there is something strange, before or after patch. There is an empty option 'Planning by " if you select planning using main pulldown, it disappears if you select planning using Filter (not a mistery, using Planning fills $auth_cats_loop, using Filter submit button does not) Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12684] New: Linking authorities to 65X field adds "7" as second indicator.
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12684 Bug ID: 12684 Summary: Linking authorities to 65X field adds "7" as second indicator. Change sponsored?: --- Product: Koha Version: 3.16 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: verolencinas(a)yahoo.com.ar QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl Linking an authority to a subject field (65X mostly) copies the value "7" as second indicator. According to the MARC 21 Format for Bibliographic Data (http://www.loc.gov/marc/bibliographic/bd650.html) second indicator = 7 means that the source of the subject heading is recorded in subfield $2 (in coded form). That means that every time a cataloger links an authority record he or she has to change this indicator or to add the applicable code in subfield $2. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #76 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- (In reply to Owen Leonard from comment #72) > That means that instead of <option value="foo" selected> > We need to write <option value="foo" selected="selected"> > > And values should be quoted: <option value="foo"> > And not <option value=foo> Thanks Owen, fixed now. I'll add a followup to some others that have been pushed, and fix also others awaiting sings. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29877|0 |1 is obsolete| | --- Comment #75 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 30406 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30406&action=edit Bug 766: Remove CGI::scrollinglist from marctagstructure.pl This patch removes the only instance in this file. Don't know if the feature is of some utility, seems that does not work (no use of auth values as indicators on MARC editor) To test: 1. Apply the patch 2. Go to Administration > MARC frameworks 3. Clic on MARC structure of any fw 4. Clic Edit on any tag 5. On tag editor check the pulldown 'Authorised value', that was replaced 6. Check for regressions: select a value, save, verify the value, change again, etc. Note: removed a SELECT, using now C4::Koha::GetAuthorisedValueCategories Do not we need an AuthorisedValues.pm? (on C4 or Koha) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 766] Omnibus: Use of CGI::scrolling_list prevents customization in template
by bugzilla-daemon＠bugs.koha-community.org 31 Jul '14

31 Jul '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=766 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29872|0 |1 is obsolete| | --- Comment #74 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 30405 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30405&action=edit Bug 766: Remove CGI::scrollinglist from authorised_values.pl This patch removes the only instance in this file. Also fixes array sorting, removes some tabs, removes an unneeded $dbh handler (there is a global one). Makes use of C4::Koha::GetAuthorisedValueCategories. To test: 1. Apply the patch 2. Go to Administration > Authorised values 3. Replaced pulldown next to 'Show category' must show all (present & system) categories correctly ordered. 4. Select some and check for regressions, e.g. CCODE, Bsort2, YES_NO no changes must be observed -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0