August 2014 - Koha-bugs - lists.koha-community.org

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '14

18 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 --- Comment #12 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- If you want to provide a follow-up here or on a separate bug I can test again. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '14

18 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 --- Comment #11 from M. Tompsett <mtompset(a)hotmail.com> --- (In reply to Katrin Fischer from comment #10) > Another thing for another day: > Empty lines are counted for the potential barcodes. Oops... That's because the $lines_read++; (line 173) is before the next unless $barcode; (line 175)! DOH! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 8776] New: note on why a fine was waived
by bugzilla-daemon＠bugs.koha-community.org 18 Aug '14

18 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8776 Priority: P5 - low Change sponsored?: --- Bug ID: 8776 CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Assignee: koha-bugs(a)lists.koha-community.org Summary: note on why a fine was waived Severity: major Classification: Unclassified OS: All Reporter: nengard(a)gmail.com Hardware: All Status: NEW Version: master Component: Circulation Product: Koha There used to be a way to add notes to payments and waived fines, but that's not possible anymore. We need a way to record why we're waiving fines for auditors and accounting reasons. This may be related to bug 6413, but I don't know how so I'm not putting it in depends or blocks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 2

[Bug 2131] Enhanced Content - Multiple Choices
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2131 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer(a)bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 7187 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4264] categories for authorized values
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4264 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer(a)bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Hi Nicole, is this still valid? Where you thinking of something like the groups and sub groups we have for reports, but for authorized values? -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8021] New: Newly Added items in the MARC catalog are not listing while Search after rebuild Zebra
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8021 Priority: P5 - low Change sponsored?: --- Bug ID: 8021 Assignee: gmcharlt(a)gmail.com Summary: Newly Added items in the MARC catalog are not listing while Search after rebuild Zebra Severity: enhancement Classification: Unclassified OS: Linux Reporter: mapinnovatives(a)yahoo.com Hardware: Other Status: NEW Version: rel_3_8 Component: Cataloging Product: Koha Earlier I have a proble that, the items are showing not available in the OPAC catalog. Then we have rebuild the Zebra after that the newly added item are not listing while searching. Only the old entries before rebuild zebra showing in the search list. what would be the reason for it... -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30880|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Created attachment 30891 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30891&action=edit [PASSED QA] Bug 4162 The inventory tool lacks validation for barcodes The inventory tool had no form of validating on what was assumed to be a valid barcode number. To solve this, an extra loop to read before processing was added. This allows to validate length and content. By using a check of \p{Print}, this includes Unicode characters such as umlauts, but excludes unusual control characters. The template was modified to accomodate validation messages related to the length and content errors. Additionally, it says how many "barcodes" were read. Barcodes are supposed to be on separate lines. TEST PLAN --------- 1) Attempt to select a file which does not contain barcodes and is not a text file. -- a horrible lack of validation and spamminess ensues. 2) Apply patch 3) Create three files. a) One containing valid barcodes on each line -- this file should trigger no errors. Attempt a valid barcode with an umlaut. b) A copy of the first with an extra line of >20 characters (e.g. The Quick Red Fox Jumped Over The Brown Fence^A^B^C) -- this file should trigger the singular error message case. ^A^B^C are actually CTRL-A,CTRL-B,CTRL-C, and it is left as an exercise to the reader to add them to the line. c) A copy of the second with the last line duplicated -- this file should trigger the plural error message case. 4) Attempt each of the three files. 5) Run koha-qa tools. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> I have a feeling that the column size could be better fetched from Koha::Database. But it is an improvement in functionality signing off Signed-off-by: Katrin Fischer <Katrin.Fischer.83(a)web.de> Works as described, no problems found. Passes tests and QA script. Another thing for another day: Empty lines are counted for the potential barcodes. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30841|0 |1 is obsolete| | --- Comment #9 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 30880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30880&action=edit Bug 4162 The inventory tool lacks validation for barcodes The inventory tool had no form of validating on what was assumed to be a valid barcode number. To solve this, an extra loop to read before processing was added. This allows to validate length and content. By using a check of \p{Print}, this includes Unicode characters such as umlauts, but excludes unusual control characters. The template was modified to accomodate validation messages related to the length and content errors. Additionally, it says how many "barcodes" were read. Barcodes are supposed to be on separate lines. TEST PLAN --------- 1) Attempt to select a file which does not contain barcodes and is not a text file. -- a horrible lack of validation and spamminess ensues. 2) Apply patch 3) Create three files. a) One containing valid barcodes on each line -- this file should trigger no errors. Attempt a valid barcode with an umlaut. b) A copy of the first with an extra line of >20 characters (e.g. The Quick Red Fox Jumped Over The Brown Fence^A^B^C) -- this file should trigger the singular error message case. ^A^B^C are actually CTRL-A,CTRL-B,CTRL-C, and it is left as an exercise to the reader to add them to the line. c) A copy of the second with the last line duplicated -- this file should trigger the plural error message case. 4) Attempt each of the three files. 5) Run koha-qa tools. Signed-off-by: Chris Cormack <chris(a)bigballofwax.co.nz> I have a feeling that the column size could be better fetched from Koha::Database. But it is an improvement in functionality signing off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4162] Inventory Tool Fails Silently
by bugzilla-daemon＠bugs.koha-community.org 17 Aug '14

17 Aug '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4162 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0