September 2014 - Koha-bugs - lists.koha-community.org

[Bug 2969] Report Name should be mandatory for saved reports
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 --- Comment #10 from Owen Leonard <oleonard(a)myacpl.org> --- This was "in discussion" for a long time without much discussion. I have rebased the patch against current master and resubmitted it in it's signed-off state. I think that while this patch is an incomplete solution it is nevertheless an improvement. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2969] Report Name should be mandatory for saved reports
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|PATCH-Sent (DO NOT USE) |P5 - low -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2969] Report Name should be mandatory for saved reports
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19821|0 |1 is obsolete| | --- Comment #9 from Owen Leonard <oleonard(a)myacpl.org> --- Created attachment 31675 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31675&action=edit [SIGNED-OFF] Bug 2969 - Report Name should be mandatory for saved reports This patch re-implements the database changes from the original patch and adds an update for existing reports. It also reimplements the client-side validation using the new built-in validation plugin and adds coverage for SQL reports. I have also added the "required" attribute to the SQL report textarea since saving a report with no SQL triggers an error. To test: - Create a new guided report. Confirm that you cannot save your guided report without a report name. - Create or edit a saved SQL report. Confirm that you cannot save your report without a name or without SQL. - Confirm that the saved_sql table structure has been updated. Signed-off-by: Liz Rea <wizzyrea(a)gmail.com> Functional tests pass, database tables look correct to me. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Even with JS disabled, the form can not be submitted without the report name filled in. However we are not checking this server side .. if this was the public interface that would be a fail. I will leave this up to the RM to decided if client side checks are ok for this. Bearing in mind we weren't handling any sql errors properly server side before this. Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 2969] Report Name should be mandatory for saved reports
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2969 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 12936] New: Road type value doesn't appear in OPAC borrower account
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12936 Bug ID: 12936 Summary: Road type value doesn't appear in OPAC borrower account Change sponsored?: --- Product: Koha Version: 3.14 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: corinne.hayet(a)progilone.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com You can create a user using road type value but when you look borrower account in OPAC, this information doesn't appear -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 12935] New: Allow different from_address in the message_queue
by bugzilla-daemon＠bugs.koha-community.org 17 Sep '14

17 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12935 Bug ID: 12935 Summary: Allow different from_address in the message_queue Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs(a)lists.koha-community.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org Every branch could have their own type of notices, and have their own person to handle those notices. It doesn't make sense to have all the notices default to the koha administrator email address. Add "Message Sent By:" email address to the notice building screen, default to the koha administrator if it is left blank. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 8903] New: Can't receive any orders
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '14

16 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8903 Priority: P5 - low Change sponsored?: --- Bug ID: 8903 Assignee: julian.maurice(a)biblibre.com Summary: Can't receive any orders Severity: major Classification: Unclassified OS: All Reporter: julian.maurice(a)biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Acquisitions Product: Koha When trying to receive an order (partially or not), I got this message in log finishreceive.pl: DBD::mysql::st execute failed: Cannot add or update a child row: a foreign key constraint fails (`koha_community_master`.`aqorders`, CONSTRAINT `aqorders_ibfk_3` FOREIGN KEY (`invoiceid`) REFERENCES `aqinvoices` (`invoiceid`) ON DELETE SET NULL ON UPDATE CASCADE) at /home/julian/koha/versions/community-master/C4/Acquisition.pm line 1344 and order is not received. This is because invoicenumber is passed to ModReceiveOrder instead of invoiceid. Bug is introduced by Bug 5335 (unhappy rebase) I'll submit a patch in a couple of minutes. -- You are receiving this mail because: You are watching all bug changes.

1 11

[Bug 12932] New: Web installer's Perl version check will not raise errors if all modules are installed
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '14

16 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12932 Bug ID: 12932 Summary: Web installer's Perl version check will not raise errors if all modules are installed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com During the web installer process an error variable is set if the Perl version is too old (installer/install.pl starting at line 60): $template->param( 'checkmodule' => 1 ); # we start with the assumption that there are no problems and set this to 0 if there are unless ( $] >= 5.010000 ) { # Bug 7375 $template->param( problems => 1, perlversion => 1, checkmodule => 0 ); } However, the "checkmodule" error flag gets reset in the following section where required modules are checked. If all required modules are installed the checkmodule variable gets set back to 1 and no error will be raised in the template about the old Perl version. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11875] New: URL is poorly formed when searching on authid for author
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '14

16 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11875 Bug ID: 11875 Summary: URL is poorly formed when searching on authid for author Change sponsored?: --- Product: Koha Version: 3.12 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: joy(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org In OPAC when viewing the details screen, click on the magnifying glass by the author name. The URL (at bottom of screen) shows as <beginning urlhere>/cgi-bin/koha/opac-authoritiesdetail.pl?authid="22858" This results in a 404 error. -- You are receiving this mail because: You are watching all bug changes.

1 3

[Bug 12931] New: Gracefully handle database problems when starting web install
by bugzilla-daemon＠bugs.koha-community.org 16 Sep '14

16 Sep '14

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12931 Bug ID: 12931 Summary: Gracefully handle database problems when starting web install Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com If you start the web installer but the correct database has not been created you get an ugly Perl error: Unknown database 'koha' at C4/Context.pm line 802. Judging from the template, the web installer appears to be designed to handle checks of the database in "Step 2:" <p class="error">No database named <code>[% dbname %]</code> detected.</p> For the purposes of a the web installer can and should the DB check in Context.pm be skipped? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0