October 2015 - Koha-bugs - lists.koha-community.org

[Bug 11250] New: "too many holds" message appears inappropriately
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '15

22 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11250 Bug ID: 11250 Summary: "too many holds" message appears inappropriately Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: koha(a)univ-lyon3.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com In the staff interface, when placing a hold from the holds tab of a detailed record, the message "Cannot place hold Too Many Holds: Johnny SuchOne has too many holds" appears even if the unique reason is that there 's no holds allowed for the borrower. seems because of this line (request.pl line 193) : unless ( $canbookbereserved ) { $maxreserves = 1; } -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 32

[Bug 13881] New: Add desk management
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '15

22 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Bug ID: 13881 Summary: Add desk management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs(a)lists.koha-community.org Reporter: nicolas.legrand(a)bulac.fr QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com A Library may have multiple desks inside its public space. If desks are defined in Koha, a librarion in public space should set her desk when opening her session as she should set her library. When items are checked-in and trigger a hold, the hold may be attachable to a desk and the patron may be advertised where she can retreive her hold. This may also be usefull when items come from closed stacked. Some may be kept as hold behind the everyday items issue desk, some may be behind the rare books section desks. Such a module was developped by Progilone for the BULAC Koha 3.2, check: <https://github.com/BULAC/koha/blob/bulac-dead_end-3.02.04/C4/Stack/Desk.pm>. The BULAC is going to port it to current master, with a more Kohaish style and comments. The circulation logic will be a bit different from those sources, as the BULAC plans to use Holds for books coming from closed stacked and dumps its overkill stack request module. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 32

[Bug 12120] New: Add --tempdir arg to rebuild_zebra.pl
by bugzilla-daemon＠bugs.koha-community.org 22 Oct '15

22 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12120 Bug ID: 12120 Summary: Add --tempdir arg to rebuild_zebra.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt(a)gmail.com Reporter: mtj(a)kohaaloha.com QA Contact: testopia(a)bugs.koha-community.org Sometimes zebra indexing will fail when the filesystem of the /tmp dir is too small for the indexing temp file ie: a 20 gig temp file is needed, and /tmp is only 1 gig :( ...in this situation, it is necessary to tell rebuild_zebra.pl to use a different filesystem with the required space. this patch aims to provide this functionality -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 15045] New: URLs should be built using PATH_INFO and SCRIPT_NAME
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15045 Bug ID: 15045 Summary: URLs should be built using PATH_INFO and SCRIPT_NAME Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Currently, Koha has different ways of building the URI path when rendering links. Some of them are hardcoded, some rely on $cgi->url. We need to calculate them correctly to support arbitrary places to put Koha's intefaces in. -- You are receiving this mail because: You are watching all bug changes.

1 2

[Bug 14486] New: C4/Accountlines.pm needs better documentation and removal of stale code
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14486 Bug ID: 14486 Summary: C4/Accountlines.pm needs better documentation and removal of stale code Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: barton(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The documentation in C4/Accountlines.pm is confusing. There is no clear statement of what the module is for, and some poor programmer has sprinkled the code with 'FIXME' comments to the effect of "I don't understand what this function does." The intent and proper use of these functions should be documented, and the FIXME comments should be removed. fixaccounts() is entirely commented out. This should be removed. The following functions are not documented: chargelostitem() getcharges() ModNote() getcredits() getrefunds() ReversePayment() makepartialpayment() These should have at least minimal documentation saying "It does what you think it does", and any functions which modify the accountlines need a complete explanation of what they're changing in the database and why. The weakness of the accountlines table is that there is no link between fines and issues/old_issues which is a perennial source of bugs. This needs to be explicitly documented as a gotcha. Obviously work on documentation will be obsoleted by Bug 6427 - Rewrite of the accounts system, but in some sense, because the re-write is supposed to work with legacy code, I feel that the lack of clear documentation in the old code is an impediment to the testing of the new. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 1

[Bug 14900] New: Add ability to pay all fees at once from circulation screen
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14900 Bug ID: 14900 Summary: Add ability to pay all fees at once from circulation screen Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com It could be fine to have link for collectiong whole amount of all charges at once in information about fees and charges on circulation screen. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 9

[Bug 15005] New: (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15005 Bug ID: 15005 Summary: (Plack) Use of SCRIPT_NAME makes Koha generate wrong URIs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: tomascohen(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org The current plack-on-packages schema points the apache vhost (for example for the intranet) like this: /cgi-bin/koha/ => /intranet/ So the code that uses ENV{SCRIPT_NAME} "sees" it is being called for example like /intranet/mainpage.pl. This gets problematic in some scenarios, because it is used to then redirect the browser, or to create links to things. Steps to reproduce: - Check out an old DBRev in the koha repo (1 step older is ok) - Pick the ansible branch from the kohadevbox [1] - Launch it, on jessie: $ vagrant up jessie - Log into it $ vagrant ssh jessie - Enable Plack for the automatically created instance $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev $ sudo service apache2 restart - Get the DB password to be able to login $ koha-pass - Point your browser to the staff interface: http://localhost:8081 - Login with koha_kohadev and the retrieved password => FAIL: You cannot login - Disable Plack for the instance $ sudo koha-plack --disable kohadev $ sudo koha-plack --stop kohadev $ sudo service apache2 restart - Point your browser to the staff interface: http://localhost:8081 - Login with koha_kohadev and the retrieved password => SUCCESS: You can login - Proceed to install with the default data (you can try enabling plack and you will notice it works) - Once you are in, enable plack $ sudo koha-plack --enable kohadev $ sudo koha-plack --start kohadev $ sudo service apache2 restart - Checkout the latest master (so it triggers an update) - Go somewhere inside (about?) - You are required to login (which is expected) => FAIL: the links back are pointing to /intranet/ so they are shortcircuited to the installer cyclically (see screenshot) [1] https://github.com/digibib/kohadevbox/tree/ansible -- You are receiving this mail because: You are watching all bug changes.

1 35

[Bug 15018] New: Plack testing -- Adding Items Display - Home Library/Current Location columns missing
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15018 Bug ID: 15018 Summary: Plack testing -- Adding Items Display - Home Library/Current Location columns missing Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt(a)gmail.com Reporter: hbraum(a)nekls.org QA Contact: testopia(a)bugs.koha-community.org CC: m.de.rooy(a)rijksmuseum.nl This may be outside the Plack testing and an entirely separate issue, but I noticed when adding items, that the home library and current location columns are missing from http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/cataloguing/addit… and are not in the option list for show/hide columns. That's a huge problem for a multibranch system..... To recreate: 1. Add a record and then an item or add an item to an existing record. 2. After the item is added, note that the items table on http://test-intra.plack.bywatersolutions.com/cgi-bin/koha/cataloguing/addit… (which is that a Plack url? or the old one?) does not show the home library or current location columns and that they are not available as options in the show/hide columns display. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 13589] New: add --mark-returned as a longoverdue sys pref
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13589 Bug ID: 13589 Summary: add --mark-returned as a longoverdue sys pref Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 8337 It makes sense to add --mark-returned as a system preference like the other longoverdue settings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 15043] New: Bottom table header row for circulation rules missing a column
by bugzilla-daemon＠bugs.koha-community.org 21 Oct '15

21 Oct '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15043 Bug ID: 15043 Summary: Bottom table header row for circulation rules missing a column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle.m.hall(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com The bottom table header cell for "Current on-site checkouts allowed" column is missing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 4