October 2015 - Koha-bugs - lists.koha-community.org

[Bug 14540] New: Move member-flags.pl to PermissionsManager to better manage permissions for testing.
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '15

28 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Bug ID: 14540 Summary: Move member-flags.pl to PermissionsManager to better manage permissions for testing. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org Currently there is no nice way to grant/revoke permissions for Borrowers in Koha. This is a big problem when doing integration testing and when working with permissions using the future REST API. Currently we have one web-script, member-flags.pl, which deals with all permission-related things. Basically it always DELETEs all your permissions and then adds them again with some modifications. There is no internal API for creating permissions and this makes automated testing significantly harder. To create permissions for a test borrower, we must decrypt the arcane way of creating koha.borrowers.flags and add user_permissions with brittle SQL-queries. This makes for very messy test scripts, and quite frankly this is hardly ever done in Koha. Also the koha.borrowers.flags-column is pretty horrible. It is 19-bit binary array where each bit tells of the borrower has all permissions for the respective permission module. This is very difficult to calculate and the mechanism is hard to understand. This feature is also unnecessary, since we are always interested in having the specific permissions. We don't need to know if one Borrower has all the permissions for one module. Also what happens if more subpermissions are added to the module? Existing all-permission-holders lose their all-permissions-status? Instead we could have a nice internal API to work with permissions. My patch introduces a new database structure for permissions (not necessarily better), Koha::Object implementation of the DB structure, and most importantly, a Koha::Auth::PermissionManager which is a gateway to all permissions-related actions. This feature is well tested with unit tests and PageObject integration tests. See the tests for usage examples. Especially the t/db_dependent/Members/member-flags.t I hope you like it :) VOCABULARY: Module (permission_modules) => a module which consists of specific Permissions. Typically covers one Module in Koha. Permission (permission) => a specific Permission of a Module. Granting a Borrower the permission to do something. Borrower permission (borrower_permissions) => A specific Permission a specific Borrower has, eg. the permission to edit bibliographic records. TEST PLAN: -2. Note the permissions a bunch of borrowers has. -1. run updatedatabase.pl 0. Observe that those borrowers still have the same permissions. For modules which didn't have any subpermissions, a generic subpermission is added and the borrowers should have it if they had the existing module permission. Basic login: 1. Go to Koha staff client 2. Make a password login. 3. Browse to any other staff client pages to confirm that the session is active and login persists on other pages. Modify permissions: 1. Go to member-flags.pl (Home › Patrons › Set permissions) 2. Change your permissions. Save. 3. Go back to member-flags.pl 4. Observe that you see the same permissions you just set. Modify superlibrarian permission: 1. Go to member-flags.pl (Home › Patrons › Set permissions) 2. Give the superlibrarian-permission. Observe all other permissions vanishing. Save. 3. Go back to member-flags.pl 4. Observe that you see only the superlibrarian-permission active. 5. Observe that the superlibrarian permission is the only top-level permission which doesn't have any subpermissions. -- You are receiving this mail because: You are watching all bug changes.

1 31

[Bug 14719] New: Regression tests for members/statistics.pl
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '15

28 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14719 Bug ID: 14719 Summary: Regression tests for members/statistics.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: gmcharlt(a)gmail.com Reporter: olli-antti.kivilahti(a)jns.fi QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 6

[Bug 14543] New: Order lines updated that have a tax rate not in gist will have tax rate set to 0!
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '15

28 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543 Bug ID: 14543 Summary: Order lines updated that have a tax rate not in gist will have tax rate set to 0! Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org If the tax rate for a given order line has been removed from the system preference gist, that tax rate will show in the pulldown as 0. If a librarian then saves the order line the original tax rate will be overwritten with 0%! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 6

[Bug 12421] New: no way to get back to search results from overdrive results
by bugzilla-daemon＠bugs.koha-community.org 28 Dec '15

28 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12421 Bug ID: 12421 Summary: no way to get back to search results from overdrive results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org Created attachment 28840 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28840&action=edit link to overdrive results When on your search results you can click the link to overdrive results, but then you can't get back to your catalog search results, the line that links to the results should be there on both pages. -- You are receiving this mail because: You are watching all bug changes.

1 8

[Bug 8064] New: Merge several biblio records
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '15

27 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8064 Priority: P5 - low Change sponsored?: --- Bug ID: 8064 Assignee: julian.maurice(a)biblibre.com Summary: Merge several biblio records Severity: enhancement Classification: Unclassified OS: All Reporter: julian.maurice(a)biblibre.com Hardware: All Status: ASSIGNED Version: master Component: Cataloging Product: Koha Add the possibility to merge more than 2 biblio record. Patch coming. -- You are receiving this mail because: You are watching all bug changes.

1 113

[Bug 10958] New: no need for home link on home page
by bugzilla-daemon＠bugs.koha-community.org 27 Dec '15

27 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10958 Bug ID: 10958 Summary: no need for home link on home page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard(a)myacpl.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org On the OPAC there is a Home link on the top left it makes no sense and a lot of libraries are asking to have it removed, but if I remove it with JS I lose the breadcrumbs on every page. Can we get rid of the home link on the home page? -- You are receiving this mail because: You are watching all bug changes.

1 7

[Bug 12178] New: Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed
by bugzilla-daemon＠bugs.koha-community.org 26 Dec '15

26 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12178 Bug ID: 12178 Summary: Serial claims: exporting late issues with the CSV profile doesn't set the issue claimed Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs(a)lists.koha-community.org Reporter: katrin.fischer(a)bsz-bw.de QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When using the CSV export option for late serial issues, the claim date is set, but the claimed status for the issue isn't. The issue remains as late. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 12

[Bug 13930] New: Add supporting service svc/ncip for xnciptoolkit driver
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '15

24 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13930 Bug ID: 13930 Summary: Add supporting service svc/ncip for xnciptoolkit driver Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs(a)lists.koha-community.org Reporter: josef.moravec(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org We need ncip service for Koha, because it will the main communication protocol for libraries portal here in Czech Republic. The work is almost done and is sponsored by Municipal Library Ceska Trebova and by grant from Ministry of Culture of Czech Republic. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 36

[Bug 10382] New: collection not returning to null when removed from course reserves
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '15

24 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10382 Bug ID: 10382 Summary: collection not returning to null when removed from course reserves Classification: Unclassified Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Circulation Assignee: kyle(a)bywatersolutions.com Reporter: nengard(a)gmail.com CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com Depends on: 8215 If an item that is on reserves did not have a collection code and one was added a the time of adding the reserve then when you remove the item from reserves the collection is not returned to NULL instead it stays as what it was set in reserves. -- You are receiving this mail because: You are watching all bug changes.

1 18

[Bug 10589] New: Override OpacHiddenItems based on Patron Category
by bugzilla-daemon＠bugs.koha-community.org 24 Dec '15

24 Dec '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Bug ID: 10589 Summary: Override OpacHiddenItems based on Patron Category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard(a)myacpl.org Reporter: mtompset(a)hotmail.com QA Contact: testopia(a)bugs.koha-community.org This patch will: 1) Add two system preferences: PatronSingleBranch and PatronEveryBranch. 2) Items which would normally be hidden by OpacHiddenItems will be visible if: a) The patron's category code matches the PatronSingleBranch patron category code AND the home branch of the item is the same as the home branch of the patron. OR b) The patron's category code matches the PatronEveryBranch patron category code. The two system preferences default to PTSB and PTEB which are not added to the list of possible patron categories. This means OpacHiddenItems will continue to function as is normally. Having them as system preferences means the patron category code is not hard coded and can be changed. -- You are receiving this mail because: You are watching all bug changes.

1 55