May 2015 - Koha-bugs - lists.koha-community.org

[Bug 14035] New: Shibboleth SingleSignOut
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14035 Bug ID: 14035 Summary: Shibboleth SingleSignOut Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: chris(a)bigballofwax.co.nz, corinne.flacher-david(a)biblibre.com, dpavlin(a)rot13.org, fridolyn.somers(a)biblibre.com, jonathan.druart(a)biblibre.com, koha(a)univ-lyon3.fr, luce.barbey(a)cirad.fr, matthias.meusburger(a)biblibre.com, misilot(a)fit.edu, tomascohen(a)gmail.com Depends on: 12887, 14034 +++ This bug was initially created as a clone of Bug #14034 +++ The shibboleth authentication only support partial single sign out at the moment... i.e. it supports it in one direction. We can submit a signout request to the IdP at koha logout time, but we are not yet listening to logouts on the shibboleth service. I'm not even sure how well documented this feature is in the level above us, but I thought it worth noting here whilst I find time to work on it. -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 12681] New: Shibboleth attributes may contain lists
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12681 Bug ID: 12681 Summary: Shibboleth attributes may contain lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Authentication Assignee: gmcharlt(a)gmail.com Reporter: martin.renvoize(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: dpavlin(a)rot13.org In koha, a shibboleth attribute is always assumed to be a singular value; however an attribute may actually contain a semi-colon separated list of values in a string. We should handle this in koha somehow. -- You are receiving this mail because: You are watching all bug changes.

1 5

[Bug 4502] Perl error in acq budget planning
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39082|0 |1 is obsolete| | --- Comment #18 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39084 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39084&action=edit [SIGNED-OFF] Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4502] Perl error in acq budget planning
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37534|0 |1 is obsolete| | --- Comment #17 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39083 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39083&action=edit [SIGNED-OFF] Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4502] Perl error in acq budget planning
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39081|0 |1 is obsolete| | --- Comment #16 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39082 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39082&action=edit [SIGNED-OFF] Bug 4502: An attempt to make things more sensible. The reason the budget_period_id was not defined was because in two cases it was not passed! This patch adds those missing parameters. And as a result, cuts out the attempt to default the authcat to '' unless the budget_period_id is defined. Additionally, the start and end months don't seem to be passed, so rather than have it blow up, checking them forces the else case logic. budget_period_id is the budget id. If you have two budgets, you can craft a URL to work with budget_period_id matching those two ids. Anything else should trigger the new error which was modified to reflect more of what the problem is. Follow the test plan in comment #6. Feel free to also to attempt crafting URLs and triggering errors. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Well, works and does not explode any more No errors To trigger the new message simply put /cgi-bin/koha/admin/aqplan.pl on your staff page, an intriguing 'Planning for by Asort1' appears :) -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4502] Perl error in acq budget planning
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4502] Perl error in acq budget planning
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4502 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37354|0 |1 is obsolete| | --- Comment #15 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39081 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39081&action=edit [SIGNED-OFF] Bug 4502: Catch software error if no active budget defined TEST PLAN --------- 0) Back up your database. 1) In mysql client: > DROP DATABASE {your koha database name}; > CREATE DATABASE {your koha database name}; > QUIT; 2) Go to the staff client, and install all the default and optional things -- except patrons. :) 3) Log into staff client. 4) Create a patron -> New Patron -> Staff 5) Enter data and Save 6) More -> Set Permissions 7) Make superlibrarian 8) Log out 9) Log in as new superlibrarian 10) Acquisitions -> Budgets -> New Budget 11) Enter a non-active budget with some funds. -- Once saved, it should list in the inactive budgets. 12) Click on the name. 13) Click on one of the Planning submenu options. 14) Click the 'Submit' button in the Filter area. -- This should trigger the blow up. 15) Apply the patch 16) Repeat steps 12-15 -- The kaboom is avoided and a nice message given. NOTE: This does not solve all the problems in this ugly, ugly module area. It does solve the one thing it is meant to: that nasty kaboom. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 4137] OPACViewOthersSuggestions does not work
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37207|0 |1 is obsolete| | --- Comment #12 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39068 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39068&action=edit [SIGNED-OFF] Bug 4137: Fix the OPACViewOthersSuggestions behavior This pref does not work at all, the interface let the user choose to list all suggestions, but whatever he chooses the suggestion list is the same. This patch cleans a bit the suggestedby management. There are a lot of cases to test, because linked to 2 prefs: AnonSuggestions and OPACViewOthersSuggestions. 1/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 0 - A non logged in user is not able to purchase a suggestion. - A logged in user is not able to see suggestions made by someone else. 2/ AnonSuggestions = 0 and OPACViewOthersSuggestions = 1 - A non logged in user is not able to purchase a suggestion. - A logged in user is able to see suggestions made by someone else. 3/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 0 - A non logged in user is able to purchase a suggestion. The suggestedby field will be filled with the AnonymousPatron pref value. He is not able to see suggestions, even the ones made by AnonymousPatron. - A logged in user is not able to see suggestions made by someone else. 4/ AnonSuggestions = 1 and OPACViewOthersSuggestions = 1 - A non logged in user is able to purchase a suggestion. He is able to see all suggestions. - A logged in user is able to see suggestions made by someone else. In all cases a logged in user should be able to search for suggestions (except if he is not able to see them). Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> All use cases tested, work as expected No errors Only comment is perhaps (in the future) a gracefull failure when AnonymousPatron is not set, or has '0' value Message is DBIx::Class::ResultSet::create(): Column 'suggestedby' cannot be null at ... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 4137] OPACViewOthersSuggestions does not work
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4137 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 1985] Email notification of new OPAC comments
by bugzilla-daemon＠bugs.koha-community.org 12 May '15

12 May '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1985 Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #38910|0 |1 is obsolete| | --- Comment #43 from Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> --- Created attachment 39062 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39062&action=edit [SIGNED-OFF] Bug 1985: Follow up - Add sample letter to other languages As per comment #36, the letter COMMENT_CREATED has been added to the other languages. TEST PLAN --------- 0) Back up your letters table 1) In your mysql client after selected your Koha database, Run this: SET foreign_key_checks = 0; truncate letter; source installer/data/mysql/de-DE/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/es-ES/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/it-IT/necessari/notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/nb-NO/1-Obligatorisk/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/pl-PL/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/ru-RU/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/uk-UA/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; truncate letter; source installer/data/mysql/en/mandatory/sample_notices.sql SELECT COUNT(*) FROM letter where code='COMMENT_CREATED'; -- there should be 9 counts of 1. 2) Restore your letters table. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel(a)gmail.com> Sample letter in all languages No errors -- You are receiving this mail because: You are watching all bug changes.

1 0