June 2015 - Koha-bugs - lists.koha-community.org

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #13 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Should not we update the misc/migration_tools/build_oai_sets.pl script to take into account the deletedbiblio table? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Jonathan Druart <jonathan.druart(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |--- CC| |jonathan.druart(a)biblibre.co | |m Assignee|gmcharlt(a)gmail.com |matthias.meusburger@biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 --- Comment #12 from Jonathan Druart <jonathan.druart(a)biblibre.com> --- Comment on attachment 39797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39797 Bug 3206: OAI repository deleted records support. Review of attachment 39797: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=3206…) ----------------------------------------------------------------- ::: installer/data/mysql/sysprefs.sql @@ +479,5 @@ > ('XSLTDetailsDisplay','default','','Enable XSL stylesheet control over details page display on intranet','Free'), > ('XSLTResultsDisplay','default','','Enable XSL stylesheet control over results page display on intranet','Free'), > ('z3950AuthorAuthFields','701,702,700',NULL,'Define the MARC biblio fields for Personal Name Authorities to fill biblio.author','free'), > +('z3950NormalizeAuthor','0','','If ON, Personal Name Authorities will replace authors in biblio.author','YesNo'), > +('OAI-PMH:DeletedRecord','persistent','Koha\'s deletedbiblio table will never be deleted (persistent) or might be deleted (transient)','transient|persistent','Choice') Insert the pref at the right place, this file must be kept ordered. ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/web_services.pref @@ +31,5 @@ > + - Koha's deletedbiblio table > + - pref: "OAI-PMH:DeletedRecord" > + choices: > + persistent: will never be emptied or truncated (persistent) > + transient: might be emptied or truncated at some point (transient) Does it make sense to have the "no" option? ::: opac/oai.pl @@ +242,5 @@ > > +package C4::OAI::DeletedRecord; > + > +use strict; > +use warnings; Prefer Modern::Perl; @@ +303,5 @@ > + FROM deletedbiblio > + WHERE biblionumber=? " ); > + $sth->execute( $biblionumber ); > + > + unless ( ($marcxml, $timestamp) = $sth->fetchrow ) { Prefer $dbh->selectrow_* @@ +358,4 @@ > } > my $max = $repository->{koha_max_count}; > my $sql = " > + (SELECT biblioitems.biblionumber, timestamp Why do you remove the table name? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14301] New: “No renewal before” does not accept 0 as parameter.
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14301 Bug ID: 14301 Summary: “No renewal before” does not accept 0 as parameter. Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: costalc(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com CIRCULATION AND FINE RULES: “No renewal before” does not accept 0 as parameter. Setting this parameter to 0 could enable issue due date as the only date to renew issues Explanation attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 7

[Bug 14214] New: Automatic renewal to renew at end of due date
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14214 Bug ID: 14214 Summary: Automatic renewal to renew at end of due date Change sponsored?: --- Product: Koha Version: 3.18 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs(a)lists.koha-community.org Reporter: fiona.borthwick(a)ptfs-europe.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com If an item is set to automatically renew, then there should be a straightforward way to set the value so that it will renew at the end of the due date. I have done substantial testing on this but cannot get it to do what I need. Setting the 'no renewals before' to 1 means that it will renew one day prior to due date. Setting it to -1 means that it will renew one day past due date - i.e. item is overdue. Setting the value to 0 in the Circulation Policies translates to null when saved and the 0 is removed. We established that we could get 0 into the database by entering 0.001. However this seems to be ignored as the automatic renewal is happening every day in the same way that it would if there was no value set in 'no renewal before'. We can change the timing of the automatic_renewal.pl script to run at a more convenient time (e.g. before the overdue processing) but we need the item to be able to be renewed at the end of its due date - not before and not after. This is especially important for items that have rental fees associated with them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 5

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39795|0 |1 is obsolete| | --- Comment #11 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 39797 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39797&action=edit Bug 3206: OAI repository deleted records support. This patch allows Koha OAI repository to support deleted records. The OAI-PMH:DeletedRecord syspref is introduced and can be set to: - persistent (in case Koha's deletedbiblio table will never be emptied or truncated) - transient (in case Koha's deletedbiblio table might be emptied or truncated at some point) Test plan: - After applying the patch, test that: - Deleted records appear in ListRecords and ListIdentifiers requests. - Filter parameters (from, until, set and resumptionToken) still work and are applied to ListRecords and ListIdentifiers requests. - Identify request shows if the repository is considered persistent or transient, according to the OAI-PMH:DeletedRecord syspref. - Deleted records that used to belong to a set are still displayed in those sets and marked as deleted. - GetRecord requests work on deleted records, which are marked as deleted. Requests examples: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&from=2015-02-20T11:08:33Z /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&set=new_specSet1 /cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:2&metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=Identify Signed-off-by: Frederic Demians <f.demians(a)tamil.fr> It works in all situations described in the test plan. Great addition. Thanks. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11578] New: Improvement of the funds list view
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Bug ID: 11578 Summary: Improvement of the funds list view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: jonathan.druart(a)biblibre.com QA Contact: testopia(a)bugs.koha-community.org The funds list is not ergonomic and should be improved. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 66

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #39794|0 |1 is obsolete| | --- Comment #10 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 39795 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39795&action=edit Bug 3206: OAI repository deleted records support. This patch allows Koha OAI repository to support deleted records. The OAI-PMH:DeletedRecord syspref is introduced and can be set to: - persistent (in case Koha's deletedbiblio table will never be emptied or truncated) - transient (in case Koha's deletedbiblio table might be emptied or truncated at some point) Test plan: - After applying the patch, test that: - Deleted records appear in ListRecords and ListIdentifiers requests. - Filter parameters (from, until, set and resumptionToken) still work and are applied to ListRecords and ListIdentifiers requests. - Identify request shows if the repository is considered persistent or transient, according to the OAI-PMH:DeletedRecord syspref. - Deleted records that used to belong to a set are still displayed in those sets and marked as deleted. - GetRecord requests work on deleted records, which are marked as deleted. Requests examples: /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&from=2015-02-20T11:08:33Z /cgi-bin/koha/oai.pl?verb=ListRecords&metadataPrefix=oai_dc&set=new_specSet1 /cgi-bin/koha/oai.pl?verb=GetRecord&identifier=KOHA-OAI-TEST:2&metadataPrefix=oai_dc /cgi-bin/koha/oai.pl?verb=Identify Signed-off-by: Frederic Demians <f.demians(a)tamil.fr> It works in all situations described in the test plan. Great addition. Thanks. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 3206] OAI repositry deleted record support
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3206 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11929] New: patron modification error shows borrowernumber
by bugzilla-daemon＠bugs.koha-community.org 03 Jun '15

03 Jun '15

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11929 Bug ID: 11929 Summary: patron modification error shows borrowernumber Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs(a)lists.koha-community.org Reporter: nengard(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: gmcharlt(a)gmail.com, kyle.m.hall(a)gmail.com The patron modification tools wants you to provide a file of (or a list of scanned) patron barcodes, but when it has errors updating it presents you with the borrowernumber instead. Not many people know the borrowernumber that matches the barcode they scanned off the top of their head. The error should show the barcode number since that's what entered (or both the barcode number and the borrowernumber if need be). Example error: Can not update patron with borrowernumber 70552 Can not update patron with borrowernumber 74777 Can not update patron with borrowernumber 77472 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 13