January 2016 - Koha-bugs - lists.koha-community.org

[Bug 15516] RFC: Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Heather Braum <hbraum(a)nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hbraum(a)nekls.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #65 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 47396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47396&action=ed… Bug 10612 - Change _skip_borrowers_with_fines to _skip_borrowers_with_fines_or_issues Restore code that was moved to bug 15642 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47259|0 |1 is obsolete| | --- Comment #64 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 47395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47395&action=ed… Bug 10612 [QA Followup] - fix issues 1 - Use Koha::List::Patron 2 - Return only non-empty lists for deletion selection 3 - Fix _skip_bo... to accept patro_list_patrons3 - Fix _skip_borrowers_with_fines_or_issues to accept patro_list_patrons3 4 - Fix missed closing quote in cleanborrowers.tt -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47225|0 |1 is obsolete| | --- Comment #63 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 47394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47394&action=ed… Bug 10612 - [QA followup] Use font awesome icons in patron lists lists.tt Signed-off-by: Natasha <tasham_8(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47224|0 |1 is obsolete| | --- Comment #62 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 47393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47393&action=ed… Bug 10612 - Add ability to delete patrons with batch patron deletion tool This patch adds the ability to select a patron list for deletetion when using the Batch patron deletion/anonymization tool. It also adds buttons to the the patron lists table to access both the batch deletion and batch modification directly from the lists view. This is a squash of previous patches with a check added for issues before deleting borrowers. Test Plan: 1) Apply this patch 2) Create a list of patrons with the new Patron Lists feature 3) Try using the batch edit link form the lists table 4) Try using the batch delete link from the lists table Signed-off-by: Jesse Weaver <jweaver(a)bywatersolutions.com> ByWater internal signoff, still needs signoff from community. Patch seems kosher, passes QA tools. Needs followup to fix one small issue: squished patch undoes switch to FontAwesome icons in lists.tt. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15642] Batch patron deletion should not delete patrons with issues
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|10612 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 [Bug 10612] Add ability to delete patrons with batch patron deletion tool -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|15642 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15642 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 [Bug 15642] Batch patron deletion should not delete patrons with issues -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15642] Batch patron deletion should not delete patrons with issues
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Nick Clemens <nick(a)bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) > In misc/cronjobs/delete_patrons.pl it's done with: > 68 my $flags = C4::Members::patronflags( $member ); > 69 if ( my $charges = $flags->{CHARGES}{amount} ) { > 70 say "Failed to delete patron $borrowernumber: patron has > $charges in fines"; > 71 next; > 72 } > Should not we simply move this check to the GetBorrowersToExpunge subroutine? FWIW I think I would rather see the checks done as above - so that the warning is visible that not all patrons in the category/list/etc were deleted. If the checks were moved into GetBorrowersToExpunge it would be nice to make it return patrons who wont be deleted because of issues/fines This is probably a separate enhancement though and I think this report can be closed. Agreed? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15642] Batch patron deletion should not delete patrons with issues
by bugzilla-daemon＠bugs.koha-community.org 28 Jan '16

28 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15642 --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- > Nick, tools/cleanborrowers.pl already call GetBorrowersToExpunge, so I am > not sure this change is needed. Agreed, not needed here, but needed on bug 10612, will move back over there -- You are receiving this mail because: You are watching all bug changes.

1 0