January 2016 - Koha-bugs - lists.koha-community.org

[Bug 14855] Resend notices in Notices tab with AJAX + REST
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14855 Viktor Sarge <viktor.sarge(a)regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #27 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- QA Comment: Your change generally looks good to me. But I will be very precise here :) Note that you use TO_DAYS in the query. So you select the current date with all hours too. Formerly, records of today were compared with date_to_run (including time) eliminating the records in hours still to come. As long as $mindays is not zero (from overduerules), these records will be discarded later on (L 544-555) since mindays may not be zero in the code of this script (line 490). Another point is the -date parameter. I am not sure what it actually should do btw, since it is documented rather poorly. Looking through code, it seems to mimic running on a different date (e.g. say -date <yesterday> or -date <tomorrow> e.g.). The same argument as above could be repeated for the records of the specific date given via this parameter. This actually brings me to the conclusion that you made a large first step, but the second step would be moving the checks for mindays and maxdays into the SQL statement too. Note that it may run three times with different values for the three triggers. Another report? Related: While testing PREDUE and ODUE, I found that using -n on the command line will generate the error that the print notice for PREDUE and ODUE are not found. Copying them from email, revealed that PREDUE should use a block <item>...</item> in order to have the title displayed, or should use <items.content>. In a new installation this should be corrected. If you confirm that, we could address it on a new report too? I used the opportunity to add a few minor adjustments in a follow-up. Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #26 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 47354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47354&action=ed… Bug 15240: [QA Follow-up] Minor adjustments This patch does: [1] It removes some unused modules. [2] It adds some options not listed in the synopsis. [3] It removes an unused sql expression from one query. Note: In fines related code the third parameter of CalcFine sometimes is named as days_overdue too. [4] Corrects a few typos in comments or pod. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47335|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 47353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47353&action=ed… Bug 15240: Do not process issues with a date due later than today There is no need to do this job in Perl, MySQL could do it instead. The idea is to only retrieve the issues info which could be overdued. To test: 1/ Run the script 2/ Apply the patch 3/ Run the script again, notice the exact same results but execution time is faster Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #24 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #19) > I hope to get around to it soon - but the more testing the better. Overdues > are a bit of a complicated matter. We only actively use it with the overdue > and notice triggers - if someone else could verify it works the same as > before without -t that would be helpful. No reasons to worry. Actually, the code part where the triggered condition is executed (if passed), was not touched. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11556] Send any notice to any patron (or all patrons) on demand
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 --- Comment #2 from Viktor Sarge <viktor.sarge(a)regionhalland.se> --- +1 for resend. That could also be useful for retrying things like SMS that didn't go through (if there's no smarter way that I'm currently missing) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14717] Prevent 0000-00-00 dates in patron data
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14717 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15155 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15155] Can't call method "truncate" on an undefined value at /usr/share/koha/lib/C4/Circulation.pm line 1966
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15155 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14717 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- See bug 14717, which has been pushed to 3.20.4 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 11556] Send any notice to any patron (or all patrons) on demand
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11556 Viktor Sarge <viktor.sarge(a)regionhalland.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |viktor.sarge@regionhalland. | |se -- You are receiving this mail because: You are watching all bug changes.

1 0