January 2016 - Koha-bugs - lists.koha-community.org

[Bug 15260] Option for extended loan with useDaysMode
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Janet McGowan <janet.mcgowan(a)ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan(a)ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #31 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47345&action=ed… Bug 14828 [QA Followup] - Hide in OPAC checkbox not checked in editor even if enabled Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #30 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47344&action=ed… Bug 14828: use Koha::ItemType[s] in admin/itemtypes Test plan: Add/edit/remove item types from the administration module (admin/itemtypes.pl). You should get message feedback after each action. Don't forget to play with the image and try to remove an item type linked to records (you should not be able to remove it). Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #29 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47343&action=ed… Bug 14828: Remove old package and tests C4::ItemType can be now removed safely, there is no use of this module. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 --- Comment #28 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47342&action=ed… Bug 14828: Use Koha::ItemType[s] everywhere C4::ItemType was used This patch mainly replaces C4::ItemType->all with Koha::ItemTypes->search. Test plan: At the places where the C4::ItemType module was used, confirm there is no regression: - acqui/neworderempty.pl - catalogue/itemsearch.pl - admin/item_circulation_alerts.pl and the 2 cataloguing plugins: - marc21_linking_section.pl - unimarc_field_4XX.pl QA step: prove t/db_dependent/HoldsQueue.t should return green Note that the tests were buggy. Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14828] Move the item types related code to Koha::ItemTypes
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14828 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46731|0 |1 is obsolete| | Attachment #46732|0 |1 is obsolete| | Attachment #46733|0 |1 is obsolete| | Attachment #46734|0 |1 is obsolete| | Attachment #46735|0 |1 is obsolete| | --- Comment #27 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47341&action=ed… Bug 14828: Add Koha::ItemType[s] classes Signed-off-by: Marc Véron <veron(a)veron.ch> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15353] patron image disappears when on fines tab
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle(a)bywatersolutions.com Attachment #46366|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15353] patron image disappears when on fines tab
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15353 --- Comment #4 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47340&action=ed… Bug 15353: Display the patron image where needed Patched needed rebasing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #68 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47339&action=ed… Bug 9021: Flag issues Check in and check out were failing for me. Specificly, the $borrower->{flags}->{...} was not accessible as a hash, so I put a hash ref check around the code that would fail. TEST PLAN --------- 1) Attempt a checkout -- blows up with "1" not being allowed as a hash ref. 2) Apply patch 3) Attempt same checkout again -- success 4) prove -v t/db_dependent/Circulation_dateexpiry.t -- this triggers CanBookBeIssued -- this should succeed 5) prove -v t/db_dependent/rollingloans.t -- mine skipped the tests, but if configured, it should also trigger and succeed. 6) run koha qa test tools Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47134|0 |1 is obsolete| | Attachment #47135|0 |1 is obsolete| | --- Comment #67 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47338&action=ed… Bug 9021: Schema update This ensures that the DBIx structure matches the SQL structure changes. See comment #48 as to how this was generated. Also, I had to modify misc/devel/update_dbix_class_files.pl to have an "overwrite_modifications => 1" option to get it to generate. This should correct issues raised in comment #45. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0