January 2016 - Koha-bugs - lists.koha-community.org

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #8 from Mike <black23(a)gmail.com> --- Hello. I vote for solutions 1 or 4. Thanks for response. Mike -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15652] Allow current date in datepicker on opac-reserve
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15652 --- Comment #4 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > Does it make sense to have 'Hold not needed after' set to today? Only a little little bit. See my commit message btw (" I only want this book today or not" ). For the most, it keeps the code cleaner, more consistent perhaps? In the end, it does not harm at all.. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11573] change description of rental charges in account fines
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 --- Comment #31 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 47289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47289 [SIGNED-OFF] Bug 11573 - Make fine display more consistent for rentals Review of attachment 47289: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=115…) ----------------------------------------------------------------- I am not sure I have understood what is expected. I get: Without the patch: Rental, Rental (my_title_99) Rent 0 0 1.00 1.00 Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99) Rent 0 0 1.00 1.00 With the patch: Rental, my_title_99 my_barcode_992 (my_title_99) Rent 0 0 1.00 1.00 Rental, Renewal of Rental Item my_title_99 my_barcode_992 (my_title_99) I still get the title displayed twice. ::: C4/Circulation.pm @@ +3189,4 @@ > my $dbh = C4::Context->dbh; > my $nextaccntno = getnextacctno( $borrowernumber ); > my $manager_id = 0; > + my $item = GetBiblioFromItemNumber($itemnumber); GetBiblioFromItemNumber returns a biblio, not an item. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15067] Add additional languages to advanced search language search
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- I'd say this patch is not complete. Looking at the other part of the files, we have, for instance: INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'fi', 'language', 'fi', 'Suomi'); INSERT INTO language_descriptions(subtag, type, lang, description) VALUES ( 'fi', 'language', 'en', 'Finnish'); We need the language name to be translated in its own language Moreover it seems that we need to add the country with the "region" type too. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #7 from Josef Moravec <josef.moravec(a)gmail.com> --- or 4. just unify the authtypecode/frameworkcode and name it the same -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #6 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Looking at your example - I think what happened is: The item was checked out on the 26th with due date 26th, but after the auto_renewal job was run for that day. On the 27th in the morning the job was run again, but the item was overdue by then - so renewal was blocked. That makes sense to me to be honest. I am not sure how to avoid that. > I think if the "No renewal before" is empty, we could agree that it should > try on the due date - but witht he parameter set the behaviour should be > changed. NOT be changed... :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Josef Moravec <josef.moravec(a)gmail.com> --- First of all, thank you Aleisha! But this doesn't work, because functions _export_table_* take data from database filtered by column "frameworkcode" which in auth_subfield_structure is not always populated and in auth_tag_structure is not present at all. I'm not sure how to deal with it, just some ideas for now: 1. we could add new parameter to export routines, which can say the column should be used to filter data (authtypecode if we are working with authorities) 2. add and populate column frameworkcode to tables auth_tag_structure and auth_subfield_structure, which should have the same value as authtypecode. But I don't really like this solution as it's more work ending with dumb duplicate column 3. something else -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #5 from Mike <black23(a)gmail.com> --- Hello Aleisha, I tested patch but outputs are non correct. Examples: empty export of unification names http://pastebin.com/qnCassBC Personal names, just some mess: http://pastebin.com/1X6NXgeN Expected is same type of output like export from biblio frameworks. Lets find bug :-) Export from default biblio framework don't work - empty file Thank You. Mike -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12051] add renew tab to top on staff client
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12051 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 27 Jan '16

27 Jan '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #4 from Mike <black23(a)gmail.com> --- Hello Aleisha, I tested patch but output are non correct. Examples: empty export of unification names http://pastebin.com/qnCassBC Personal names, just some mess: http://pastebin.com/1X6NXgeN Expected is same type of output like export from biblio frameworks. Lets find bug :-) Thank You. Mike -- You are receiving this mail because: You are watching all bug changes.

1 0