October 2016 - Koha-bugs - lists.koha-community.org

[Bug 12310] Accept different monetary formats as input
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17462 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #5 from Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> --- I have put a limit on the query as you suggested: http://paste.koha-community.org/135 It's not in production yet, but testing in staging so far seems good. The result is probably not accurate, as you said, but I think it's only potentially wrong if you have a very wide search (i.e few numbers which matches lots of borrowernumbers). If the result list is long, say tens of thousands, it does not matter that its not accurate. If you search for full fields (in our case its social security number as extended patron attribute), the returned result is always correct In my mind, it's quite dangerous that Koha allows to generate SQL-queries which are several MB of text, which generated huge loads on our server, so I'd prefer safety to accuracy here. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 --- Comment #10 from Magnus Enger <magnus(a)libriotech.no> --- The new scripts need to be documented in man pages, similar to the existing scripts. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12805] Proposed changes to Koha plugins system (.KPZ) structure
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12805 Magnus Enger <magnus(a)libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #9 from Magnus Enger <magnus(a)libriotech.no> --- Looks like this has a patch that needs signoff. Changing the status accordingly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Petter Goksøyr Åsen from comment #3) > This is still a problem. I'd say the member search is dangerous and > generates some horrible queries which takes many minutes to run if you have > a large dataset. > > We have over 300,000 patrons. > > If someone search for something stupid like %29% - this is (part of) the > generated query: > https://gist.githubusercontent.com/boutros/db14414591ea77638b2a3a183a18ec00/ > raw/d59f7ef33890b7a034f24a0d350b5af3b6257e4e/bigquery.sql How d(In reply to Petter Goksøyr Åsen from comment #3) > This is still a problem. I'd say the member search is dangerous and > generates some horrible queries which takes many minutes to run if you have > a large dataset. > > We have over 300,000 patrons. > > If someone search for something stupid like %29% - this is (part of) the > generated query: > https://gist.githubusercontent.com/boutros/db14414591ea77638b2a3a183a18ec00/ > raw/d59f7ef33890b7a034f24a0d350b5af3b6257e4e/bigquery.sql For the records: http://irc.koha-community.org/koha/2016-10-13#i_1866950 Petter, how did you finally fix it? I have several ways to fix it but I don't figure out which one is the best. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8010] Search history can be added to the wrong patron
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8010 --- Comment #5 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- What you describe is the expected behavior. We could imagine a pref to disable the search history for non-logged in user. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10337] Add a script to insert all sample data automatically
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56607|0 |1 is obsolete| | --- Comment #10 from Chris Cormack <chris(a)bigballofwax.co.nz> --- Created attachment 56614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56614&action=ed… Bug 10337: Add a script to populate devs' DBs with sample data Executing the installer process and inserting all the sample data take a lot of clics and time. The idea of this script is to provide a quick way to insert all the sample data easily to get a working Koha install asap. Test plan: - Set your database config to a non-existent DB - Execute perl misc/devel/populate_db.pl You will get an error - Create an empty DB - Execute perl misc/devel/populate_db.pl It will insert all the MARC21 sample data - Execute perl misc/devel/populate_db.pl You will get an error because the DB is not empty (systempreferences and borrowers tables) Signed-off-by: Chris Cormack <chrisc(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10337] Add a script to insert all sample data automatically
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10337 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10858] Browse selected biblios
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10858 --- Comment #99 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #98) > (In reply to Marcel de Rooy from comment #26) > > > If you browse the selection, it would imo be good to show that you are doing > > so (Browse selected results vs. Browse results). > > I like this suggestion too, but I think it could be handled in a follow-up. > > It looks to me like the contents of common.js could be put into global.js > and we could avoid having a separate file. Do you think there is a reason > not to? These patches have been submitted 3 years ago, and have been rewritten 3 times already. If we want additional behaviours they should go to another bug report. The commons.js content could be moved to global.js but note that bug 11311 is adding more content to this file. Maybe we could move it to something less vague than 'commons' but keep it apart from global. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 18 Oct '16

18 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56352|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0