October 2016 - Koha-bugs - lists.koha-community.org

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56360|0 |1 is obsolete| | --- Comment #118 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56592&action=ed… Bug 5670: [QA Followup] Improve template style. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove toggler class from form, improve look and layout of action buttons. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56359|0 |1 is obsolete| | --- Comment #117 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56591&action=ed… Bug 5670: remove useless call to ->new when ->search is enought Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56358|0 |1 is obsolete| | --- Comment #116 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56590&action=ed… Bug 5670: mv housebound_* to search_housebound_* I think it's better to prefix the subroutine names used to search with 'search_'. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56357|0 |1 is obsolete| | --- Comment #115 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56589&action=ed… Bug 5670: Add the 'required' class to required fields Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56356|0 |1 is obsolete| | --- Comment #114 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56588&action=ed… Bug 5670: [QA Followup] Fix `div.patroninfo`. * members/housebound.pl: Provide full patron hash keys, extended patron attributes & picture to template. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Refactor to use new information. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56355|0 |1 is obsolete| | --- Comment #113 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56587&action=ed… Bug 5670: [QA Followup] Small QA fixes. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove `console.log` invocations. * members/housebound.pl ($houseboundvisits, $chooser, $deliverer): Remove unused variables. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56354|0 |1 is obsolete| | --- Comment #112 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56586&action=ed… Bug 5670: [QA Followup] Housebound link from patron edit. * koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link to the housebound module view if it is switched on. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56353|0 |1 is obsolete| | --- Comment #111 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56585&action=ed… Bug 5670: [QA Followup] Avoid CGI::param in list context. * members/housebound.pl: Force `borrowernumber` to scalar context. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56351|0 |1 is obsolete| | --- Comment #110 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56584&action=ed… Bug 5670: [QA Followup] Don't force ISO dates. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use ".datepicker" class for date input, use `$KohaDates` to filter our iso dates. * members/housebound.pl: Use DateTime and Koha::DateUtils to parse incoming date to ISO format. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 17 Oct '16

17 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56350|0 |1 is obsolete| | --- Comment #109 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 56583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56583&action=ed… Bug 5670: [Followup] Refactor .pl; error messages. * members/housebound.pl: Refactor & store messages for encountered errors. * koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show messages. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0