October 2016 - Koha-bugs - lists.koha-community.org

[Bug 15147] Blocking Calls in Patron Search
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15147 Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #3 from Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> --- If anyone is working on this, see my comment on bug #1707 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |boutrosboutrosboutros@gmail | |.com --- Comment #3 from Petter Goksøyr Åsen <boutrosboutrosboutros(a)gmail.com> --- This is still a problem. I'd say the member search is dangerous and generates some horrible queries which takes many minutes to run if you have a large dataset. We have over 300,000 patrons. If someone search for something stupid like %29% - this is (part of) the generated query: https://gist.githubusercontent.com/boutros/db14414591ea77638b2a3a183a18ec00… -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #79 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- New Test Plan: Test plan: - Apply patches (DO NOT PUSH contain the schema updates). - Run atomic update script. - Run Unit Tests (t/db_dependent/Patron/Housebound*) - Optionally, add additional authorised values of 'Frequency' categories. - Enable HouseboundModule module. - On a patron page, you should see details of housebound roles - When editing or creating a patron you can set the housebound roles. - On a patron page, the Housebound menu should have been added. - create housebound profile + ensure Frequency values are from correct authorised values. - create 'housebound visits' (deliveries) + ensure chooser/deliverer lists are populated with patrons that have the Chooser or Deliverer Attribute type (none by default: you will have to grant some users those attributes). - edit the profile/instances. - delete the instances. - Switch off 'HouseboundModule' - the Housebound menu should disappear -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5670] Housebound Readers Module
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670 --- Comment #78 from Alex Sassmannshausen <alex.sassmannshausen(a)ptfs-europe.com> --- Created attachment 56308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56308&action=ed… DO NOT PUSH: Moar Housebound Schema files. * Koha/Schema/Result/Borrower.pm: New method. * Koha/Schema/Result/HouseboundRole.pm: New file. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 11217] The # in accountlines descriptions makes them un-writeoffable
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56304|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 56307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56307&action=ed… Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> Signed-off-by: Nick Clemens <nick(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11217] The # in accountlines descriptions makes them un-writeoffable
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Nick Clemens <nick(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15173] SubfieldsToAllowForRestrictedEditing not working properly
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15173 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire_gravely(a)hotmail.com Status|Needs Signoff |Failed QA --- Comment #3 from Claire Gravely <claire_gravely(a)hotmail.com> --- testing this I found that before applying patch I was able to edit all free text fields as reported. After applying the patch I could not edit anything, even with the exceptions defined in SubfieldsToAllowForRestrictedEditing. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14610] Add ability to place article requests in Koha
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14610 --- Comment #215 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Checked the source code and got some questions: To discuss: 1) Why did you put the new routines like can_article_request in Biblio.pm? I think Circulation.pm seems like a more obvious choice to me, as it already has CanBookBeIssued, CanBookBeReturned etc. 2) There is another routine with the same name 'can_article_request' in Items.pm - I know one is for record and one is for item level, but is that intentional? To fix: 3) In Patrons.pm there seems to have some extra code slipped in that shouldn't be part of this patch set: guarantor 4) Please add the new notices and slip to the other non-english installer directories as well! 5) Can you please put classes on the th elements in patron-article-requests.inc as well? The td are already all classed up :) 6) This little piece of code gives me trouble, publishercode is filled in the database, but it's not showing up. Same for pages in the same part of the code. It looks like the values from biblioitems specifically are not showing up. Also: if you catalog MARC21 there already is a ',', so there is no need to add another in the template. The comma can be removed. + <div class="ar-pubdata"> + [% ar.biblio.biblioitem.publishercode %] + + [% IF ar.biblio.biblioitem.publicationyear %] + , [% ar.biblio.biblioitem.publicationyear %] 6) Patch uniminifies opac.css! 7) Test fails... perl t/db_dependent/ArticleRequests.t 1..49 Bareword "C4::Context::only_my_library" not allowed while "strict subs" in use at Koha/Libraries.pm line 52. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11217] The # in accountlines descriptions makes them un-writeoffable
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #56078|0 |1 is obsolete| | --- Comment #6 from Claire Gravely <claire_gravely(a)hotmail.com> --- Created attachment 56304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56304&action=ed… Bug 11217: The # in accountlines descriptions makes them un-writeoffable This patch adds escaping to url params in mambers/pay.pl To test: - Apply patch - Go to Home > Patrons > Manual invoice and create an invoice with a description containing a # - Go to tab "Pay fines" - Write off the fine Expected result: Fine is written off and does no longer display in pay tab. Signed-off-by: Claire Gravely <claire_gravely(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11217] The # in accountlines descriptions makes them un-writeoffable
by bugzilla-daemon＠bugs.koha-community.org 13 Oct '16

13 Oct '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11217 Claire Gravely <claire_gravely(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0