November 2016 - Koha-bugs - lists.koha-community.org

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '16

29 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 David Cook <dcook(a)prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=17690 -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '16

29 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 --- Comment #16 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to Jonathan Druart from comment #14) > By using Koha::Issue I meant using it as an object (so no need to add you > subroutine to the module). > For instance: > $issue = Koha::Issue::GetIssue({issue_id => $issue_id}); > could be > $issue = Koha::Issues->find( $issue_id); > and $issue becomes a Koha::Object-based object, not an hashref > > SetIssueNote($issue_id, $clean_note) > could be > Koha::Issues->find( $issue_id )->set({ notedate => dt_from_string, note = > $clean_note })->store; > > > etc. Hi Jonathan, I'm having issues using Koha::Issues->find($issue_id). I'm receiving this error: Can't locate object method "_new_from_dbic" via package "Koha::Issue" at /home/vagrant/kohaclone/Koha/Objects.pm line 87 Do you know what could be causing this? Aleisha -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14224] patron notes about item shown at check in
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '16

29 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14224 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57763|0 |1 is obsolete| | --- Comment #15 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 57802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57802&action=ed… Bug 14224: Allow patron notes about item shown at check in This patch adds a "Note" input field to checked out items in the "your summary" section. The field allows patrons to write notes about the item checked out, such as "this DVD is scratched", "the binding was torn", etc. The note will be emailed to the library and displayed on item check in. Patch adds two fields to the "issues" table - "note" and "notedate". Patch adds syspref "AllowIssueNotes" - default off. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) Make sure the branch has an email address specified 4) Check out an item to a patron 5) Log in with the patron you checked out the item for 6) In "your summery", write a message in the new "Note" field for the item checked out. Hit ENTER to save/send. 7) Success message should be seen and an email sent to the email address specified for the branch which the item was checked out from. 8) Log in with staff account and check in the item 9) The note should be shown The note can be changed by the patron at any time while the item is checked out. Each change will send a new email to the branch. Only the latest note version will be shown on check in. =============================================================================== UPDATE 5: - This patch is still not ready for testing - am committing and attaching just to keep track of my changes. - So far I have - moved the ajax code into svc/patron_notes. - made use of the built-in letters and notices functions to send this email etc (easier to test, removes a lot of unnecessary code etc), so I have removed the opac-sendissuenote.tt file and instead added a note to the database in 'letters' table which will be added to the message queue when the note is submitted - GetIssue subroutine to return the matching issue - Created a new GetPatronNote subroutine to fetch the notes on the circulation.pl page (previously the librarian could only see the note on checkin on the returns.pl page, which is not the only place you can check in) - Fallback form for when JS is deactivated - Testing: - Schema needs to be rebuilt before testing - Turn on 'AllowIssueNote' syspref - Show message_queue in mysql to test the notice is being sent - Test with and without JS - will provide instructions for this later - Still to do: - Making use of Koha::Issue[s] as per Comment 11 and Comment 14 - Show patron notes on the staff client dashboard (the way suggestions and patron detail updates show up on the main page) so librarians can mark notes as 'seen' - will do in a new patch when this is complete Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13799] Add base for building RESTful API
by bugzilla-daemon＠bugs.koha-community.org 29 Nov '16

29 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13799 --- Comment #245 from David Cook <dcook(a)prosentient.com.au> --- (In reply to David Cook from comment #244) > Is there going to be some documentation for using and developing the REST > APIs? > Still wondering about this... I see lots of blockers but no coherent documentation of the REST API for Koha... -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6796] Overnight circulation of reference books
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57785|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57792&action=ed… Bug 13726: Make Koha::Acq::Bookseller using Koha::Object This patch create a Koha::Acquisition::Booksellers module and Koha::Acquisition::Bookseller::Contract[s] modules. All code in the acquisition module is adapted to use the CRUD methods of Koha::Object[s]. The former C4 routines are removed. Test plan: Since a lot of files are impacted by this patch, try a complete acquisition workflow and try to catch errors. Be focused on bookseller and bookseller' contacts data. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13726] Koha::Acquisition::Bookseller should use Koha::Object
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13726 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #17 from Josef Moravec <josef.moravec(a)gmail.com> --- I faced some ISE during testing (plack on): Supplier.pl: Can't locate object method "search" via package "Koha::Subscriptions" (perhaps you forgot to load "Koha::Subscriptions"?) at /home/vagrant/kohaclone/Koha/Acquisition/Bookseller.pm line 25. Invoices.pl op=do_search: Can't use string ("Koha::Acquisition::Bookseller") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/Koha/Object.pm line 219. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 Fridolin SOMERS <fridolin.somers(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers(a)biblibre.co | |m --- Comment #32 from Fridolin SOMERS <fridolin.somers(a)biblibre.com> --- Change in C4/Installer/PerlDependencies.pm is useless I think -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15293] Move the C4::Branch related code to Koha::Libraries
by bugzilla-daemon＠bugs.koha-community.org 28 Nov '16

28 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15293 Bug 15293 depends on bug 15758, which changed state. Bug 15758 Summary: Move the C4::Branch related code to Koha::Libraries - part 4 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15758 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.

1 0