November 2016 - Koha-bugs - lists.koha-community.org

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |8612 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 [Bug 8612] CSV export profile to have custom fields in export csv basket -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #11 from Josef Moravec <josef.moravec(a)gmail.com> --- Jonathan, everything works perfectly, I have just small doubt about UI - the purpose of 2nd select is not 100% obvious from my point of view... could you try to Merge these to select into one like this? - ISO2709 with items - ISO2709 without - CSV - profile1 - CSV - profile2 - ... OR Show/hide the second select dynamically based on actually selected format in first select? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 --- Comment #6 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57068&action=ed… Bug 1707: Do not return more than 100 patrons matching the attributes search As you can feel, this patch is not perfect as we are hardcodind the number of results to return. But this number should be correct in the most cases. Test plan: With a large number of patrons, using attributes, you can search for something very generic, like '%'. Without this patch, the MySQL server could be overloaded because of the generated query (built from borrowernumbers). -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 1707] Search for patron '%' returns all results
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=1707 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #10 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Josef Moravec from comment #6) > I'd like to sign-off, but patch doesn't apṕlied cleanly... > > Also, I like the ability to select from all available profiles, but I think > it should offer only 'marc' type of profile, because with 'sql' type > exporting of checkouts doesn't work... Indeed, done. Thanks for testing Josef! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 --- Comment #9 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57066&action=ed… Bug 15498: Do not display sql csv profiles -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50258|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57065&action=ed… Bug 15498: Add ExportCircHistory and remove ExportWithCsvProfile -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50257|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 57064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57064&action=ed… Bug 15498: Let the user choose the CSV profile to export circ history The way the export options are displayed at the bottom of the checkouts table was not consistent. Prior to this patch set, they are display if ExportRemoveFields or ExportWithCsvProfile is set. It does not make any sense, the user could want to export the checkouts in iso2709 format without having to define a csv profile and fill the pref. Moreover the behavior of this pref did not match its description: it's used as a default CSV profile when exporting records from the export tools or the command line. This patch set adds a new pref ExportCircHistory and remove ExportWithCsvProfile. The new pref is set if ExportWithCsvProfile or ExportRemoveFields were set. A new dropdown list with the CSV profile list will be displayed in the export area, at the bottom of the checkouts table. Note that now --csv_profile_id is mandatory for the export command line (misc/export_records.pl) if the export format is csv. Test plan: 0/ Do not execute the DB entry 1/ Clear both ExportWithCsvProfile and ExportRemoveFields prefs 2/ Execute the DB entry 3/ ExportCircHistory should not be set and the export options should not be displayed at the bottom of the checkouts table. 4/ Remove the pref DELETE FROM systempreferences WHERE variable='ExportCircHistory'; and reinsert the previous one, with a value: INSERT INTO systempreferences (variable, value) VALUES ('ExportWithCsvProfile', 'something'); Execute the DB entry again => The now pref should be now set 5/ Export some checkouts using the CSV entry 6/ Note that the export tool and commandline script still work using the csv format. You have to provide a --csv_profile_id option to make it work. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15498] Replace ExportWithCsvProfile with ExportCircHistory
by bugzilla-daemon＠bugs.koha-community.org 02 Nov '16

02 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15498 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0