November 2016 - Koha-bugs - lists.koha-community.org

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #37 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Apply? [(y)es, (n)o, (i)nteractive] Applying: Bug 8612 - System preference to have custom fields in export csv basket Using index info to reconstruct a base tree... M acqui/basket.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging acqui/basket.pl CONFLICT (content): Merge conflict in acqui/basket.pl -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11592] opac detail scripts do not respect MARC tag visibility
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11592 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17527 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17527 [Bug 17527] 245 $h Medium - hidden settings in MARC framework don't work correctly -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14874] Add ability to search for patrons by date of birth from checkout and patron quick searches
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14874 --- Comment #48 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #47) > Created attachment 57009 [details] [review] > Bug 14874: (followup) Fix typo introduced in sysprefs.sql > > Signed-off-by: Tomas Cohen Arazi <tomascohen(a)theke.io> I have just added a check to the QA script: commit b8479e5189f992c62a828fd88e1a7cc2e1206835 Lines should not terminate by semicolons in sysprefs.sql -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #36 from Josef Moravec <josef.moravec(a)gmail.com> --- (In reply to Katrin Fischer from comment #33) > Did a quick code review: > > 1) Could we make this a split button maybe (like the one in cataloguing for > z39.50 import)? (no blocker) Good point, I've done it > > 2) The button itself is labelled differently on a closed basket and an open > basket. Should be the same label for both. I'd suggest something in the > middle between both versions "Export as CSV"? Fixed > > 2) Please provide tests for changes to GetBasketAsCSV. Test added As have little experiences with writing test, feel free to point me to the right direction if it's not written as it should be. Thanks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #35 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57013&action=ed… Bug 8612: Add tests for GetBasketAsCSV -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 --- Comment #34 from Josef Moravec <josef.moravec(a)gmail.com> --- Created attachment 57012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57012&action=ed… Bug 8612: QA followup - Make export button split button, unify button labels -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8612] CSV export profile to have custom fields in export csv basket
by bugzilla-daemon＠bugs.koha-community.org 01 Nov '16

01 Nov '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8612 Josef Moravec <josef.moravec(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0