December 2016 - Koha-bugs - lists.koha-community.org

[Bug 14332] Skip title articles on Opac using ind2 of tag 245 (MARC21 only )
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14332 Tomás Cohen Arazi <tomascohen(a)gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen(a)gmail.com --- Comment #8 from Tomás Cohen Arazi <tomascohen(a)gmail.com> --- This implementation is causing some troubles because the koha-indexdefs-to-zebra.xsl is by no means MARC21-only or even biblio-only. To reproduce: - On current master, run: $ xsltproc etc/zebradb/xsl/koha-indexdefs-to-zebra.xsl etc/zebradb/marc_defs/unimarc/biblios/biblio-koha-indexdefs.xml > etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl - Run: $ git diff => FAIL: The following is added to etc/zebradb/marc_defs/unimarc/biblios/biblio-zebra-indexdefs.xsl, thus UNIMARC field 245 is being sent to the Title index @@ -42,6 +43,7 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) <xslo:apply-templates mode="index_match_heading"/> <xslo:apply-templates mode="index_subject_thesaurus"/> <xslo:apply-templates mode="index_all"/> + <xslo:apply-templates mode="index_sort_tit"/> </z:record> </xslo:template> <xslo:template match="marc:controlfield[@tag='001']"> @@ -2681,6 +2683,19 @@ definition file (probably something like {biblio,authority}-koha-indexdefs.xml) <xslo:value-of select="."/> </z:index> </xslo:template> + <xslo:template mode="index_sort_tit" match="marc:datafield[@tag='245']"> + <xslo:variable name="chop"> + <xslo:choose> + <xslo:when test="not(number(@ind2))">0</xslo:when> + <xslo:otherwise> + <xslo:value-of select="number(@ind2)"/> + </xslo:otherwise> + </xslo:choose> + </xslo:variable> + <z:index name="Title:s"> + <xslo:value-of select="substring(marc:subfield[@code='a'], $chop+1)"/> + </z:index> + </xslo:template> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12162] Add class="branchcode" to body tag to make OPAC CSS-styleable per branch
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12162 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17652 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17652 [Bug 17652] opac-account.pl does not include login branchcode -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10662] Build OAI-PMH Harvesting Client
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #112 from David Cook <dcook(a)prosentient.com.au> --- (In reply to Andreas Hedström Mace from comment #111) > Yes, I definitely think this will be good enough for now!!! Getting a better > matching and/or storing the incoming data to me sounds like future > enhancements! I spent some time today on these enhancements as they make the import much faster and more robust*, and I would've needed to do them soon for the RDFXML OAI-PMH downloads anyway**. I've ditched the import batches and I'm doing adds/updates/deletes more directly. If we need to track changes to bibliographic metadata records in Koha, I think it would make more sense to look at new functionality than relying on the existing batch system which has issues. In any case, I'll be working more on this early next week, and hopefully posting the API code here next week. *most matching will be done based on OAI-PMH identifier URI and repository URI in the database, so we won't need to worry about Zebra issues. However, in the event that there is no matching OAI-PMH identifier and repository URI, the API can be given an optional matcher code, and Koha's Zebra-based matcher will be used to find a match. This **The RDFXML OAI-PMH downloads will make use of this database-based matching, although if there's no OAI-PMH identifier URI and repository URI for that downloaded record, it'll be an error state, since only MARCXML can be used with the Zebra-based matcher. We may have to talk more about that at some point, although I suppose it's out of the scope of this bug report anyway. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15415] Warn when creating new printer profile for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47567|0 |1 is obsolete| | --- Comment #4 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 57876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57876&action=ed… Bug 15415: Warn when creating a new print profile As per Jonathan's comment in Comment 3, I've put that line of code in an if statement that will only call the get_attr method if we are editing an existing profile (therefore the profile id will exist). To test: 1) Go to Tools -> Patron Card Creator -> New printer profile 2) Notice warn 3) Apply patch 4) Refresh page 5) Confirm warn is gone and page still works as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15415] Warn when creating new printer profile for patron card creator
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15415 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54900|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 57873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57873&action=ed… Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) IMPORTANT STEP: Before you import, make sure that the authtypecode of the file you are going to import matches the Code of your new authority type. Use Vim or something similar to do a search and replace and change the codes in your file - do NOT use LibreOffice etc. because it tries to be too helpful and messes with the formatting of the file (this is what has broken the Import function in previous testing of this patch) 7) Import into your new authority type using the file you just exported (make sure you've done Step 6) 8) Confirm you are taken to auth_tag_structure.pl 9) Go back to Authority types 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13952] Import and export of authority types
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 6979] LDAP authentication fails during password comparison
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6979 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |alexbuckley(a)catalyst.net.nz --- Comment #24 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- The 'Update tests' patch fails to apply, when you try to apply this patch to koha. This is the result: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug #6979 Applying: Bug 6979 - Update tests Using index info to reconstruct a base tree... M t/db_dependent/Auth_with_ldap.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Auth_with_ldap.t CONFLICT (content): Merge conflict in t/db_dependent/Auth_with_ldap.t Failed to merge in the changes. Patch failed at 0001 Bug 6979 - Update tests The copy of the patch that failed is found in: /home/vagrant/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-6979---Update-tests-EmFl3l.patch -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 14541] Tax rate should not be forced to an arbitrary precision
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #57363|0 |1 is obsolete| | --- Comment #15 from Alex Buckley <alexbuckley(a)catalyst.net.nz> --- Created attachment 57872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=57872&action=ed… Bug 14541: Do not truncate tax rate values Tax rates are stored in decimal(6,4) fields which means that 4 decimals are allowed. If a tax rate is 8.42%, it is stored as 0.0842 If a tax rate has more precision than that, Koha won't deal correctly with it. We will need to update the DB structure. With this patch, the tax rate will be displayed with the same precision as in the DB. So if you enter 8.42, you will see 8.42% instead of 8.4% without this patch. Test plan: Do a full acquisition workflow with a tax rate like 8.42% and confirm that it is correctly displayed. Signed-off-by: Alex Buckley <alexbuckley(a)catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14541] Tax rate should not be forced to an arbitrary precision
by bugzilla-daemon＠bugs.koha-community.org 02 Dec '16

02 Dec '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541 Alex Buckley <alexbuckley(a)catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0