February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #10 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47972&action=ed… Bug 15479 [QA Followup] - Tidy sub to remove tabs causing qa script to fail Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 --- Comment #9 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47970&action=ed… Bug 15479 Add tests for ILS.pm This patch specifically adds a test for the sub added to resolve Bug 15479. As no test script existed to add this two added one which also tests that ILS objects can be instantiated correctly and offer the required interface NOTE: This does not apply without the first patch. Comment #3 suggested a unit test that would fail before and pass after. So while this code is good, it missed the before case. -- mtompset Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47811|0 |1 is obsolete| | Attachment #47812|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47969&action=ed… Bug 15479 Make ILS cardnumber comparison case insensitive The borrowers table is defined COLLATE=utf8_unicode_ci which means that cardnumbers may be saved in either lowercase or uppercase and these are considered equivalent. The server was performing a case sensitive comparison between the incoming patron identifier and that retrieved from the db As a result some renewals were rejected as being on loan to another borrower if the stored cardnumber differed in case. Make code comparison comply with db. Signed-off-by: Mark Tompsett <mtompset(a)hotmail.com> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15479] SIPserver rejects renewals for patrons with alphanumeric cardnumbers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15479 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 9021] Add SMS via email as an alternative to SMS services via SMS::Send drivers
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9021 --- Comment #82 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Kyle, please provide tests for the 2 new modules. See t/db_dependent/Koha/Cities.t for a generic example. You will need to cover the new patrons_using method as well. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15761] New: SIP2 can not save statistics
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15761 Bug ID: 15761 Summary: SIP2 can not save statistics Change sponsored?: --- Product: Koha Version: 3.22 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: SIP2 Assignee: koha-bugs(a)lists.koha-community.org Reporter: hblancoca(a)gmail.com QA Contact: testopia(a)bugs.koha-community.org CC: colin.campbell(a)ptfs-europe.com When i try to checkin an item from 3m selfcheckin machine get the following error in /var/log/koha/catalogo/sip-output.log DBD::mysql::st execute failed: Data truncated for column 'value' at row 1 [for Statement "INSERT INTO statistics -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 2

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt(a)gmail.com |jonathan.druart(a)bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Blocks| |15779 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15779 [Bug 15779] Remove unnecessary parts of C4::Koha -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 --- Comment #3 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 47968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47968&action=ed… Bug 5404: C4::Koha - remove subfield_is_koha_internal_p The commit b5ecefd485a75d54a5fa26fff5a0cc890541e2c3 Date: Mon Feb 3 18:46:00 2003 +0000 had a funny description: Added function to check if a MARC subfield name is "koha-internal" (instead of checking it for 'lib' and 'tag' everywhere); temporarily added to Koha.pm "Temporarily", since 2003, everything is relative, isn't it? :) The thing is that GetMarcStructure returns hash like field_200 => { subfield_a => { %attributes_of_subfield_a }, %attributes_of_field_200 } The attributes for field_200 can be 'repeatable', 'mandatory', 'tag', 'lib'. We don't want to loop on these values when looping on subfields. Since there are just { k => v } with v is a scalar (string), it's easier to test if we are processing a subfield testing the reference. At some places, we don't need to test that, we are looping on values from MARC::Field->subfields which are always valid subfields. Test plan: 1/ Edit items using the batch item mod tool 2/ display and edit items via the cataloguing module. You should not see any changes between before and after the patch applied. Tech notes: We need to check what we are processing when we loop on 'subfields' from GetMarcStructure, not from MARC::Field->subfields. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

1 0

[Bug 5404] C4::Koha::subfield_is_koha_internal_p no longer serves a purpose
by bugzilla-daemon＠bugs.koha-community.org 12 Feb '16

12 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5404 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

1 0