February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #21 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47712&action=ed… Bug 15629: Fix tests - Koha::Library does not have ->categories but ->get_categories Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #20 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47711&action=ed… Bug 15629: Koha::Libraries - Remove GetBranchInfo C4::Branch::GetBranchInfo was only used once in opac/opac-suggestions.pl The occurrence can easily be replaced by a call to Koha::Libraries->find Test plan: 1/ Create a suggestion for library A 2/ Enable OPACViewOthersSuggestions 3/ Use a patron from library B to see the suggestions 4/ The "Suggested for" value should be correctly filled with the library A name. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #19 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47710&action=ed… Bug 15629: Koha::Libraries - Remove ModBranch This subroutine was only used in tests to add/update a library. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #18 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47709&action=ed… Bug 15629: Koha::Libraries - Remove GetBranchDetail C4::Branch::GetBranchDetail retrieved library infos, it could be easily replaced with Koha::Libraries->find When this change needs other big changes, the unblessed method is called, to manipulate a hashref (as before) instead of a Koha::Library object (for instance when $library is sent to GetPreparedLetter). Test plan: 1/ Print a basket group, the library names should be correctly displayed. 2/ Enable emailLibrarianWhenHoldIsPlaced and place a hold, a HOLDPLACED notice will be generated (focus on the library name) 3/ Edit a patron and change his/her library 4/ Generate the advanced notices (misc/cronjobs/advance_notices.pl) and have a look at the generated notices 5/ Same of overdues notices 6/ Set IndependentBranches and use a non superlibrarian user to place a hold. The "pickup at" should be correctly filled. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47708&action=ed… Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (3) C4::Branch::GetBranchesInCategory is not used anymore and can be removed. Test plan: git grep GetBranchesInCategory should not return any result. Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47707&action=ed… Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (2) C4::Branch::GetBranchesInCategory can be replaced with Koha::LibraryCategory->libraries Test plan: 1/ Define some 1+ group of libraries with 1+ libraries each 2/ Go on the advanced search (OPAC and Staff) and select a group of libraries 3/ The result should be consistent and only include record from these libraries Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47518|0 |1 is obsolete| | Attachment #47519|0 |1 is obsolete| | Attachment #47520|0 |1 is obsolete| | Attachment #47521|0 |1 is obsolete| | Attachment #47522|0 |1 is obsolete| | Attachment #47523|0 |1 is obsolete| | Attachment #47553|0 |1 is obsolete| | Attachment #47701|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 47706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47706&action=ed… Bug 15629: Koha::Libraries - Remove GetBranchesInCategory (1) For consistency, the branchcodes method of Koha::LibraryCategory should be named libraries. At the moment, there is only one occurrence, in admin/branches.pl Signed-off-by: Owen Leonard <oleonard(a)myacpl.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15629] Move the C4::Branch related code to Koha::Libraries - part 3
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15629 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11976] show issue date instead of received date for serials in opac
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11976 Marjorie Barry-Vila <marjorie.barry-vila(a)ccsr.qc.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila(a)ccsr.qc | |.ca -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #25 from Nick Clemens <nick(a)bywatersolutions.com> --- Created attachment 47705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47705&action=ed… Bug 15343 [QA Followup] * Check for leading/trailing spaces in password * Check hashed password in tests -- You are receiving this mail because: You are watching all bug changes.

1 0