February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47558|0 |1 is obsolete| | --- Comment #27 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47673&action=ed… [SIGNED-OFF] Bug 14272: Show single news item (OPAC) This change makes the news shown on opac-main-pl have clickable headings which shows just that news item in isolation. This is to allow further patches that adds commentary functions. Sponsored-By: Halland County Library Test plan: * Apply this patch. * Go to OPAC main, you should see multiple news items by default. * If you do not see any, go to Staff interface and add a few. * Each nees item heading should be clickable. * When clicked only that item should be shown. * When 'news_id' is present, only a single news item should show. * The breadcrumb should say 'News item' after 'Home'. Updates: * Renamed URL parameter and local variables with 'news_' prefix. * Fixed Search-And-Replace error; 'news_news_id' => 'news_id' * Added breadcrumb for viewing single news item. * Updated OPAC to use new GetNewsToDisplay parameters * Fixed template formatting and calling of GetNewsToDisplay Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47670|0 |1 is obsolete| | --- Comment #26 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47672&action=ed… [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47669|0 |1 is obsolete| | --- Comment #25 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47671&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47557|0 |1 is obsolete| | --- Comment #24 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47670&action=ed… [SIGNED-OFF] Bug 14272: Show single news item (backend) Updates: * Date formatting added to get_opac_new() * Proper filtering by way of GetNewsToDisplay Sponsored-by: Halland County Library Signed-off-by: Aleisha <aleishaamohia(a)hotmail.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47668|0 |1 is obsolete| | --- Comment #23 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47669&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47667|0 |1 is obsolete| | --- Comment #22 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47668&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47666|0 |1 is obsolete| | --- Comment #21 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47667&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47665|0 |1 is obsolete| | --- Comment #20 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47666&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47556|0 |1 is obsolete| | --- Comment #19 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- Created attachment 47665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47665&action=ed… Bug 14272: Show single news item (tests) Updates tests to match the modified NewsChannels module. Sponsored-by: Halland County Library -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14272] Allow OPAC to show a single news item
by bugzilla-daemon＠bugs.koha-community.org 05 Feb '16

05 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia <aleishaamohia(a)hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleishaamohia(a)hotmail.com --- Comment #18 from Aleisha Amohia <aleishaamohia(a)hotmail.com> --- (In reply to M. Tompsett from comment #14) > Created attachment 47556 [details] [review] > Bug 14272: Show single news item (tests) > > Updates tests to match the modified NewsChannels module. > > Sponsored-by: Halland County Library The tests fail: t/db_dependent/NewsChannels.t .. 1/12 # Category CAT1 not found, inserting # Borrower BRWR1 not found, inserting # Failed test 'got back expected news item via get_opac_new - ID 1' # at t/db_dependent/NewsChannels.t line 131. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Failed test 'got back expected news item via get_opac_new - ID 2' # at t/db_dependent/NewsChannels.t line 158. # Structures begin differing at: # $got->{newdate} = Does not exist # $expected->{newdate} = '01/01/2000' # Looks like you failed 2 tests of 12. t/db_dependent/NewsChannels.t .. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/12 subtests Test Summary Report ------------------- t/db_dependent/NewsChannels.t (Wstat: 512 Tests: 12 Failed: 2) Failed tests: 8-9 Non-zero exit status: 2 Files=1, Tests=12, 1 wallclock secs ( 0.02 usr 0.00 sys + 0.59 cusr 0.04 csys = 0.65 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes.

1 0