February 2016 - Koha-bugs - lists.koha-community.org

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 --- Comment #6 from Frédéric Demians <frederic(a)tamil.fr> --- Created attachment 47501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47501&action=ed… Bug 14523 - Google jackets being blocked when OPAC using HTTPS Get the protocol of the current URL. This results is the correct prefix being used to serve the google jackets regarless of koha apache server setup. Signed-off-by: Frédéric Demians <f.demians(a)tamil.fr> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Frédéric Demians <frederic(a)tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart(a)bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15343] Allow patrons to choose their own password on self registration.
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15343 --- Comment #22 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Comment on attachment 47407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47407 Bug 15343 - Allow user to set password on opac-memberentry.pl Review of attachment 47407: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=153…) ----------------------------------------------------------------- There is a third case to check: if the password contain leading or trailing whitespaces, see bug 14509. ::: C4/Members.pm @@ +2482,5 @@ > $borrower{'cardnumber'} = fixup_cardnumber(); > > my $borrowernumber = AddMember(%borrower); > > + return ( $borrowernumber, $borrower{'password'} ); Why do you return the password? You should compare the hashed password (Koha::AuthUtils::hash_password) in the test. ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ +60,5 @@ > [% IF field == "email" %]<li>Contact information: <a href="#borrower_email">primary email address</a></li>[% END %] > [% IF field == "emailpro" %]<li>Contact information: <a href="#borrower_emailpro">secondary email address</a></li>[% END %] > [% IF field == "B_email" %]<li>Alternate address information: <a href="#borrower_B_email">email address</a></li>[% END %] > + [% IF field == "password_match" %]<li>Passwords do not match! <a href="#password">password</a></li>[% END %] > + [% IF field == "password_invalid" %]<li>Password does not meet minium requirements! <a href="#password">password</a></li>[% END %] typo minimum. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14523] Google jackets being blocked when OPAC using HTTPS
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14523 Barry Cannon <bc(a)interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47385|0 |1 is obsolete| | --- Comment #5 from Barry Cannon <bc(a)interleaf.ie> --- Created attachment 47500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47500&action=ed… Corrects problem with https sites accessing google jackets This patch adds prefix variable to the google-jackets.js file. This detects the current URL prefix and uses that to connect to google to retrieve images. Test Plan: 1) Enable Google Jackets 2) Ensure the Koha OPAC instance is configued to use HTTPS 3) Confirm Google jackets display correctly. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13618] Prevent XSS in the Staff Client and the OPAC
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 --- Comment #204 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- New test added to the QA script: commit a9ddabb936a0a1539d01992908b3e6484b6d6466 The html filter is not needed anymore (see bug 13618) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 13323] Change the tax rate on receiving
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13323 --- Comment #15 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 47499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47499&action=ed… Bug 13323: QA fix (trailing whitespace) -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 10612] Add ability to delete patrons with batch patron deletion tool
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10612 --- Comment #67 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Nick, it's much more better, but there is something wrong. The change to C4::Members::GetBorrowersToExpunge is not consistent: we expect the subroutine behaves the same for patron list than for other params. For instance, the category_code != 'S' and the guarantor tests are not done if patron list is passed. Moreover, it's not obvious that the patron_list_id is independent from other params. I'd say you should join the patron_list_patrons when the param is given. There is also a lack of tests. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15516] RFC: Allow to reserve first available item from a group of titles
by bugzilla-daemon＠bugs.koha-community.org 01 Feb '16

01 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #46392|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice(a)biblibre.com> --- Created attachment 47498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47498&action=ed… Bug 15516: Allow to reserve first available item from a group of titles Added missing atomicupdate file -- You are receiving this mail because: You are watching all bug changes.

1 0