February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 29 Feb '16

29 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #43 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48425&action=ed… Bug 15632 [QA Followup] - Get rid of use of uninitialized value errors for unit tests * Set $user to "" if not passed * Tidy sub -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 29 Feb '16

29 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #42 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48424&action=ed… Bug 15632: Koha::Patron::Messages - (follow-up) Remove AddMessage Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 29 Feb '16

29 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 --- Comment #41 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48423&action=ed… Bug 15632: Koha::Patron::Messages - Remove tests The messages related tests in t/db_dependent/Members.t are not deprecated and can be removed. Test plan: git grep AddMessage git grep DeleteMessage git grep GetMessagesCount git grep GetMessages should not return any result. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15632] Move the messages related code to Koha::Patron::Messages
by bugzilla-daemon＠bugs.koha-community.org 29 Feb '16

29 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15632 Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48014|0 |1 is obsolete| | Attachment #48015|0 |1 is obsolete| | Attachment #48016|0 |1 is obsolete| | Attachment #48017|0 |1 is obsolete| | Attachment #48018|0 |1 is obsolete| | Attachment #48020|0 |1 is obsolete| | --- Comment #40 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- Created attachment 48422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48422&action=ed… Bug 15632: Koha::Patron::Messages - Remove GetMessages This subroutine just retrieved the messages given some parameters. Some job should not have been done in this subroutine. It was called only 3 times, in circ/circulation.pl and opac-user.pl. Basically it was used to retrieved the message to displaye for a given patron ($borrowernumber) at the OPAC (B) or Staff (L). For the 3 calls, the 2 parameters $borrowernumber and $type (message_type) were passed, the "%" trick at the beginning of the subroutine was useless. Moreover, the date formatting should be done on the TT side, not in subroutine. The can_delete flag was set if the branchcode given in parameter was the same as the one of the message. This has been delegated to the template. Indeed the can_delete was not valid, since it must depend on the AllowAllMessageDeletion pref. The test is now: IF message.branchcode == branch OR Koha.Preference('AllowAllMessageDeletion'') There is not specific test plan for this patch, the changes have already been tested in previous patches. Signed-off-by: Marc Véron <veron(a)veron.ch> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15471] Add column settings and filters to Holds queue table
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15471 --- Comment #12 from Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> --- (In reply to Owen Leonard from comment #11) > (In reply to Kyle M Hall from comment #9) > > > Bug 15471 [QA Followup] - Fix error causing visibility button to not display > > In my system this follow-up causes an error rather than fixing one. > > SyntaxError: expected expression, got ';' > /cgi-bin/koha/circ/view_holdsqueue.pl?branchlimit=APL&run_report=1 > > Line 269: > > var columns_settings = ; This is because bug 13618 has been reverted. @RM Please revert this last patch. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8587] Add a serial lifespan to serial subscriptions
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8587 --- Comment #27 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Maxime, could you check if the new feature for adding additional fields to subscriptions can provide the same functionality that you were looking for with your patches? -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7403] CataloguingLog warning incorrect
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7403 --- Comment #5 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Separating the logs properly would make a lot of sense. But otherwise... calling it 3 times seems like overkill? Maybe hiding a bigger problem underneath. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15240] Performance issue running overdue_notices.pl
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15240 --- Comment #32 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- I have tested these patches in 3.22.3 now and all works well! -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 11081] Port Koha::Contrib::Tamil indexer into Koha code base
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11081 Chris Cormack <chris(a)bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris(a)bigballofwax.co.nz --- Comment #26 from Chris Cormack <chris(a)bigballofwax.co.nz> --- (In reply to Jonathan Druart from comment #20) > After the discussion on bug 11190, I thought we all agreed that Moo must be > used, instead of Moose. That was my understanding -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7224] Allow patrons to pick their own preferred language
by bugzilla-daemon＠bugs.koha-community.org 28 Feb '16

28 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7224 --- Comment #1 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- This could also be a first step to allow sending out notices in the preferred language to the user. -- You are receiving this mail because: You are watching all bug changes.

1 0