February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15071] In OPAC search results, "checked out" status should be more visible
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 --- Comment #17 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48356&action=ed… Bug 15071 [QA Followup] - Update compiled css again Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15071] In OPAC search results, "checked out" status should be more visible
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48354|0 |1 is obsolete| | --- Comment #16 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48355&action=ed… Bug 15071 - In OPAC search results, "checked out" status should be more visible Compiled CSS file. Signed-off-by: Nicole C Engard <nengard(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15071] In OPAC search results, "checked out" status should be more visible
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15071 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48277|0 |1 is obsolete| | Attachment #48278|0 |1 is obsolete| | --- Comment #15 from Kyle M Hall <kyle(a)bywatersolutions.com> --- Created attachment 48354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48354&action=ed… Bug 15071 - In OPAC search results, "checked out" status should be more visible The prog template in the OPAC designated a color for the "unavailable" class associated with items in search results which are checked out. This class never made it into the Bootstrap theme. This patch adds it to the Bootstrap theme's LESS file. To test, apply the patch and search the OPAC for terms that will return checked out items. In the list of search results, on the "availability" line, the "Checked out" text should now be red. The change is visible with XSLT on or off. Signed-off-by: Nicole C Engard <nengard(a)bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Jonathan Druart <jonathan.druart(a)bugs.koha-community.org> Signed-off-by: Kyle M Hall <kyle(a)bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #19 from bondiurbano <costalc(a)gmail.com> --- (In reply to Holger Meißner from comment #15) > Hi bondiurbano, please take your time. Don't work on the weekend. > > When you do test again, please include when exactly the cronjob is > scheduled, or if you run automatic_renewals.pl manually. Hi Holger! I do not want to bother you but this problem is generating confussion in most customers. Apart from automatic renewals, the standard procedure is working bad, i.e., the legend "No renewals before dd/mm/yyy" is correct (the date informed is OK) but Koha does not enable the renewal. For example, if date in the legend is 24/2 and today is 24/2 Koha does not enable the renewal to be set manually (neither in intranet nor OPAC). No matter what value of days is informed in the issuing rule, Koha never enables the renewals in this case. This erroneous behavoir occurs since last december, when bug 14101 was send to stable. Look at my comment 15 point 3 in bug 14101. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15904] New: Remove C4::Accounts::recordpayment
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15904 Bug ID: 15904 Summary: Remove C4::Accounts::recordpayment Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: gmcharlt(a)gmail.com Reporter: kyle(a)bywatersolutions.com QA Contact: testopia(a)bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes.

1 1

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 Katrin Fischer <katrin.fischer(a)bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard(a)myacpl.org --- Comment #22 from Katrin Fischer <katrin.fischer(a)bsz-bw.de> --- Adding Owen... maybe he has an idea about the client side Javascript checks -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 14060] Remove readonly on date inputs
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14060 --- Comment #21 from Marc Véron <veron(a)veron.ch> --- (In reply to Katrin Fischer from comment #20) > I'd really like to see this moving forward. So, if I understand correctly, > the current problem is that the validation is not triggered, when you enter > the date without using the datepicker? Hi Katrin, That seems to be one of the problems, but I think some problems hide other ones. I write down som notes I did while playing with the code, just pro memoria. One finding is that in borrower_debarments.inc, the id manual_restriction_form is not on the form, but on the fieldset: <fieldset class="rows" id="manual_restriction_form"> After moving the form tag, I was able to add a validation to the form, something like: mrform.on("submit",function(e) { var testDate = $("#rexpiration").val(); if (!validate_date( testDate )) { e.preventDefault(); return false; } return true; }); Then I tweaked is_valid_date(date) to return false if it gets dates like 1.1.2014 etc. (depending on the dateformat syspref), something like: function is_valid_date(date) { var dateformat = dateformat_str = '[% Koha.Preference('dateformat') %]'; if ( dateformat == 'us' ) { if (! date.match('[0-9]{2}/[0-9]{2}/[0-9]{4}') ) return 0; dateformat = 'mm/dd/yy'; dateformat_str = 'mm/dd/yyyy'; } else if ( dateformat == 'metric' ) { if (! date.match('[0-9]{2}/[0-9]{2}/[0-9]{4}') ) return 0; dateformat = 'dd/mm/yy'; dateformat_str = 'dd/mm/yyyy'; } else if (dateformat == 'iso' ) { if (! date.match('[0-9]{2}-[0-9]{2}-[0-9]{4}') ) return 0; dateformat = 'yy-mm-dd'; dateformat_str = 'yyyy-mm-dd'; } else if ( dateformat == 'dmydot' ) { if (! date.match('[0-9]{2}.[0-9]{2}.[0-9]{4}') ) return 0; dateformat = 'dd.mm.yy'; dateformat_str = 'dd.mm.yyyy'; } try { $.datepicker.parseDate(dateformat, date); } catch (e) { return 0; }; return 1; } Then I tweaked the function validate_date to return true / false (in calendar.inc) function validate_date (dateText, inst) { if ( !is_valid_date(dateText) ) { var dateformat_str = '[% Koha.Preference('dateformat') %]'; alert(MSG_PLEASE_ENTER_A_VALID_DATE.format(dateformat_str)); if (inst) { $('#'+inst.id).val(''); } return 0; } return 1; } (The if (inst) was to avoid a JavaScript error) Now I could trigger the validation. But one problem now was that empty dates could no longer be saved. I have no more time at the moment to dig deeper, but maybe the notes can help somebody else to find a solution. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15675] Add issue_id column to accountlines and use it for updating fines
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15675 Kyle M Hall <kyle(a)bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15895 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15895 [Bug 15895] Add Koha::Account module, replace recordpayment with Koha::Account::pay -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 --- Comment #291 from Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> --- Created attachment 48330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48330&action=ed… Bug 7143: Release team for 3.24 Recurring update for the about page, Koha team. Test plan: Check accuracy of changes with former about page (3.22 release team) and Roles for 3.24 page on the wiki. Signed-off-by: Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 7143] Bug for tracking changes to the about page
by bugzilla-daemon＠bugs.koha-community.org 24 Feb '16

24 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7143 Marcel de Rooy <m.de.rooy(a)rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0