February 2016 - Koha-bugs - lists.koha-community.org

[Bug 15666] Automatic_renewals.pl fails when OverduesBlockRenewing and RestrictionBlockRenewing are set to "block"
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15666 --- Comment #17 from bondiurbano <costalc(a)gmail.com> --- Holger, I have made a second test (including bug 14101) on my local virtual machine and the problem persists. - Release 3.22.3 + bug 14101 - Automatic renewal cronjob was executed manually by me - Same parameters in issuing rules that were set in the first test Tell me how can I help from now on please. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

1 0

[Bug 15349] Problem with email pattern check on forms
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15349 --- Comment #1 from Owen Leonard <oleonard(a)myacpl.org> --- Koha is inconsistent about where an email formatted that way is acceptable. I think before we could solve this we would need to either enable it everywhere or at least identify where it is and isn't possible. See bug 9815 - "<<branches.branchemail>> can't contain "The Library" <library(a)example.com>" -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15358] merge.pl does not populate values to merge
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15358 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #53 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.4 Thanks Jonathan and Josef -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15578] Authority tests skip and hide a bug
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15578 Julian Maurice <julian.maurice(a)biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #18 from Julian Maurice <julian.maurice(a)biblibre.com> --- Patches pushed to 3.22.x, will be in 3.22.4 Thanks Jonathan -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 12239] Errors loading script under https in chrome
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12239 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 8373] opacheader should not show in print layout
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8373 --- Comment #2 from Owen Leonard <oleonard(a)myacpl.org> --- (In reply to Marc Véron from comment #1) > Tested on current master with opac-shelves.pl: > > If I use the browser's print preview, it looks OK. If I use the icon > 'print', the whole page is printed, including the contents of the opacheader > system preference. I can't reproduce this bug either way. The opacheader <div> is contained within the #header-region <div> which has a class of "noprint." Seems like you'd have to have a display property applied to #opacheader to override the "noprint" class to make it show up in a printout. -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15669] alphabetize marc modification pulldowns
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15669 Owen Leonard <oleonard(a)myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard(a)myacpl.org |nick(a)bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.

1 0

[Bug 15849] New: Correct JSHint errors in additem.js
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15849 Bug ID: 15849 Summary: Correct JSHint errors in additem.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: hector.hecaxmmx(a)gmail.com, koha-bugs(a)lists.koha-community.org, testopia(a)bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in acq.js koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 5, col 41, Use '!==' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 10, col 76, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 19, col 17, Bad line breaking before '||'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 35, col 97, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 51, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 53, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 54, col 9, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 57, col 9, Creating global 'for' variable. Should be 'for (var i ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 68, col 25, Use '===' to compare with 'undefined'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 88, col 41, Use '!==' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 95, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 99, col 67, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 31, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 103, col 73, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 113, col 37, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 115, col 13, 'dont_copy_fields' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 116, col 13, Creating global 'for' variable. Should be 'for (var i ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 122, col 58, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 174, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 195, col 26, The object literal notation {} is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 9, ['field'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 196, col 30, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 9, ['value'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 197, col 30, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 202, col 11, Creating global 'for' variable. Should be 'for (var field ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 204, col 23, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 207, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 212, col 21, ['field'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 213, col 21, ['value'] is better written in dot notation. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 208, col 69, Don't make functions within a loop. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 222, col 21, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 223, col 21, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 230, col 18, Use '===' to compare with 'false'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 241, col 18, Creating global 'for' variable. Should be 'for (var field ...'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 247, col 25, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 248, col 29, Bad line breaking before '||'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 249, col 25, Bad line breaking before '+'. koha-tmpl/intranet-tmpl/prog/en/js/additem.js: line 256, col 18, Use '===' to compare with 'false'. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 15848] New: Correct JSHint errors in acq.js
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15848 Bug ID: 15848 Summary: Correct JSHint errors in acq.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs(a)lists.koha-community.org Reporter: oleonard(a)myacpl.org QA Contact: testopia(a)bugs.koha-community.org CC: hector.hecaxmmx(a)gmail.com, testopia(a)bugs.koha-community.org Following coding guideline JS8: "Follow guidelines set by JSHint," some errors should be corrected in acq.js koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 5, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 11, col 21, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 25, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 40, col 13, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 18, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 44, col 32, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 73, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 74, col 17, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 75, col 23, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 110, col 14, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 114, col 24, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 24, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 129, col 28, Missing '()' invoking a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 15, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 134, col 19, Missing '()' invoking a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 136, col 31, The array literal notation [] is preferable. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 140, col 27, Use '===' to compare with '0'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 147, col 19, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 148, col 16, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 150, col 14, 'i' is already defined. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 179, col 20, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 180, col 20, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 181, col 24, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 182, col 20, Do not use String as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 183, col 25, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 186, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 189, col 17, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 191, col 18, Do not use Number as a constructor. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 13, Use '===' to compare with 'null'. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 220, col 28, Use '===' to compare with ''. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 258, col 24, eval can be harmful. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 267, col 6, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 50, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 287, col 52, Unnecessary semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 66, Missing semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 288, col 67, Unnecessary semicolon. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 302, col 18, eval can be harmful. koha-tmpl/intranet-tmpl/prog/en/js/acq.js: line 336, col 18, eval can be harmful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

1 0

[Bug 14616] Introducing Koha::Object subclasses
by bugzilla-daemon＠bugs.koha-community.org 17 Feb '16

17 Feb '16

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14616 --- Comment #10 from M. Tompsett <mtompset(a)hotmail.com> --- Comment on attachment 41532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41532 Bug 14616 - Introducing Koha::Object subclasses Review of attachment 41532: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=146…) ----------------------------------------------------------------- ::: Koha/Biblio.pm @@ -44,5 @@ > } > > -=head1 AUTHOR > - > -Kyle M Hall <kyle(a)bywatersolutions.com> Why is this being removed? I don't think Biblio.pm shouldn't even be in this patch. ::: Koha/Biblios.pm @@ +1,3 @@ > package Koha::Biblios; > > +# Copyright Open Source Freedom Fighters This is an addition, not a replacement! @@ +36,5 @@ > } > > +sub _get_castable_unique_columns { > + return ['biblionumber']; > +} This is an addition, which is fine. @@ -55,5 @@ > > -=head1 AUTHOR > - > -Kyle M Hall <kyle(a)bywatersolutions.com> > - Again, why is this removed? ::: Koha/Item.pm @@ +1,4 @@ > package Koha::Item; > > # Copyright ByWater Solutions 2014 > +# Copyright Open Source Freedom Fighters Why add a copyright for nothing added? ::: Koha/Items.pm @@ +61,5 @@ > =cut > > +sub _get_castable_unique_columns { > + return ['itemnumber', 'barcode']; > +} Like this! Nice, sharing credit, with a functionality addition. -- You are receiving this mail because: You are watching all bug changes.

1 0